Hive
  1. Hive
  2. HIVE-4027

Thrift alter_table api doesnt validate column type

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Thrift alter_table api doesnt validate column type so that invalid column type can sneak it.

      1. HIVE-4027.patch.1
        6 kB
        Gang Tim Liu
      2. HIVE-4027.patch.2
        6 kB
        Gang Tim Liu
      3. HIVE-4027.patch.3
        7 kB
        Gang Tim Liu

        Activity

        Show
        Gang Tim Liu added a comment - https://reviews.facebook.net/D8643
        Hide
        Gang Tim Liu added a comment -

        patch is available for review

        Show
        Gang Tim Liu added a comment - patch is available for review
        Hide
        Namit Jain added a comment -

        +1

        Show
        Namit Jain added a comment - +1
        Hide
        Namit Jain added a comment -

        Lots of tests are failing. Can you debug ?

        Show
        Namit Jain added a comment - Lots of tests are failing. Can you debug ?
        Hide
        Gang Tim Liu added a comment -

        Yes. sorry

        Show
        Gang Tim Liu added a comment - Yes. sorry
        Hide
        Gang Tim Liu added a comment -

        patch is available.

        Show
        Gang Tim Liu added a comment - patch is available.
        Hide
        Namit Jain added a comment -

        Committed. Thanks Tim

        Show
        Namit Jain added a comment - Committed. Thanks Tim
        Hide
        Hudson added a comment -

        Integrated in hive-trunk-hadoop1 #93 (See https://builds.apache.org/job/hive-trunk-hadoop1/93/)
        HIVE-4027 Thrift alter_table api doesnt validate column type
        (Gang Tim Liu via namit) (Revision 1448138)

        Result = ABORTED
        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1448138
        Files :

        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
        Show
        Hudson added a comment - Integrated in hive-trunk-hadoop1 #93 (See https://builds.apache.org/job/hive-trunk-hadoop1/93/ ) HIVE-4027 Thrift alter_table api doesnt validate column type (Gang Tim Liu via namit) (Revision 1448138) Result = ABORTED namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1448138 Files : /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
        Hide
        Gang Tim Liu added a comment -

        Namit, thank you very much.

        Sent from my iPhone

        Show
        Gang Tim Liu added a comment - Namit, thank you very much. Sent from my iPhone
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #130 (See https://builds.apache.org/job/Hive-trunk-hadoop2/130/)
        HIVE-4027 Thrift alter_table api doesnt validate column type
        (Gang Tim Liu via namit) (Revision 1448138)

        Result = FAILURE
        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1448138
        Files :

        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #130 (See https://builds.apache.org/job/Hive-trunk-hadoop2/130/ ) HIVE-4027 Thrift alter_table api doesnt validate column type (Gang Tim Liu via namit) (Revision 1448138) Result = FAILURE namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1448138 Files : /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1978 (See https://builds.apache.org/job/Hive-trunk-h0.21/1978/)
        HIVE-4027 Thrift alter_table api doesnt validate column type
        (Gang Tim Liu via namit) (Revision 1448138)

        Result = SUCCESS
        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1448138
        Files :

        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1978 (See https://builds.apache.org/job/Hive-trunk-h0.21/1978/ ) HIVE-4027 Thrift alter_table api doesnt validate column type (Gang Tim Liu via namit) (Revision 1448138) Result = SUCCESS namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1448138 Files : /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java

          People

          • Assignee:
            Gang Tim Liu
            Reporter:
            Gang Tim Liu
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development