Hive
  1. Hive
  2. HIVE-4001

Add o.a.h.h.serde.Constants for backward compatibility

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It's renamed to 'serdeConstants' in hive-0.10.0. But the class can be referenced by all of the custom implementations including UDFs, Serdes, StorageHandlers, etc.

        Activity

        Hide
        Phabricator added a comment -

        navis requested code review of "HIVE-4001 [jira] Add o.a.h.h.serde.Constants for backward compatibility".

        Reviewers: JIRA

        HIVE-4001 Add o.a.h.h.serde.Constants for backward compatibility

        It's renamed to 'serde2.serdeConstants' in hive-0.10.0. But the class can be referenced by all of the custom implementations including UDFs, Serdes, StorageHandlers, etc.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D8457

        AFFECTED FILES
        serde/src/java/org/apache/hadoop/hive/serde/Constants.java

        MANAGE HERALD RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/20625/

        To: JIRA, navis

        Show
        Phabricator added a comment - navis requested code review of " HIVE-4001 [jira] Add o.a.h.h.serde.Constants for backward compatibility". Reviewers: JIRA HIVE-4001 Add o.a.h.h.serde.Constants for backward compatibility It's renamed to 'serde2.serdeConstants' in hive-0.10.0. But the class can be referenced by all of the custom implementations including UDFs, Serdes, StorageHandlers, etc. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D8457 AFFECTED FILES serde/src/java/org/apache/hadoop/hive/serde/Constants.java MANAGE HERALD RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/20625/ To: JIRA, navis
        Hide
        Shreepadma Venugopalan added a comment -

        Looks good. +1.

        Show
        Shreepadma Venugopalan added a comment - Looks good. +1.
        Hide
        Phabricator added a comment -

        shreepadma has commented on the revision "HIVE-4001 [jira] Add o.a.h.h.serde.Constants for backward compatibility".

        Looks good.

        REVISION DETAIL
        https://reviews.facebook.net/D8457

        To: JIRA, navis
        Cc: shreepadma

        Show
        Phabricator added a comment - shreepadma has commented on the revision " HIVE-4001 [jira] Add o.a.h.h.serde.Constants for backward compatibility". Looks good. REVISION DETAIL https://reviews.facebook.net/D8457 To: JIRA, navis Cc: shreepadma
        Hide
        Namit Jain added a comment -

        +1

        Show
        Namit Jain added a comment - +1
        Hide
        Namit Jain added a comment -

        Committed. Thanks Navis

        Show
        Namit Jain added a comment - Committed. Thanks Navis
        Hide
        Hudson added a comment -

        Integrated in hive-trunk-hadoop1 #77 (See https://builds.apache.org/job/hive-trunk-hadoop1/77/)
        HIVE-4001 Add o.a.h.h.serde.Constants for backward compatibility
        (Navis via namit) (Revision 1444404)

        Result = ABORTED
        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1444404
        Files :

        • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde
        • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde/Constants.java
        Show
        Hudson added a comment - Integrated in hive-trunk-hadoop1 #77 (See https://builds.apache.org/job/hive-trunk-hadoop1/77/ ) HIVE-4001 Add o.a.h.h.serde.Constants for backward compatibility (Navis via namit) (Revision 1444404) Result = ABORTED namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1444404 Files : /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde/Constants.java
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1964 (See https://builds.apache.org/job/Hive-trunk-h0.21/1964/)
        HIVE-4001 Add o.a.h.h.serde.Constants for backward compatibility
        (Navis via namit) (Revision 1444404)

        Result = FAILURE
        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1444404
        Files :

        • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde
        • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde/Constants.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1964 (See https://builds.apache.org/job/Hive-trunk-h0.21/1964/ ) HIVE-4001 Add o.a.h.h.serde.Constants for backward compatibility (Navis via namit) (Revision 1444404) Result = FAILURE namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1444404 Files : /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde/Constants.java
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #116 (See https://builds.apache.org/job/Hive-trunk-hadoop2/116/)
        HIVE-4001 Add o.a.h.h.serde.Constants for backward compatibility
        (Navis via namit) (Revision 1444404)

        Result = FAILURE
        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1444404
        Files :

        • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde
        • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde/Constants.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #116 (See https://builds.apache.org/job/Hive-trunk-hadoop2/116/ ) HIVE-4001 Add o.a.h.h.serde.Constants for backward compatibility (Navis via namit) (Revision 1444404) Result = FAILURE namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1444404 Files : /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde/Constants.java

          People

          • Assignee:
            Navis
            Reporter:
            Navis
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development