Hive
  1. Hive
  2. HIVE-3864

Avoid unnecessary array copy in hbase handler

    Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: HBase Handler
    • Labels:
      None

      Description

      KeyValue[] in hbase.Result is created for each row and need not to be copied. And also values are not needed to be copied.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        4m 56s 1 Navis 06/Jan/13 05:49
        Phabricator made changes -
        Attachment HIVE-3864.D7785.1.patch [ 12563461 ]
        Hide
        Phabricator added a comment -

        navis requested code review of "HIVE-3864 [jira] Avoid unnecessary array copy in hbase handler".
        Reviewers: JIRA

        DPAL-1958 Avoid unnecessary array copy in hbase handler

        KeyValue[] in hbase.Result is created for each row and need not to be copied. And also values are not needed to be copied.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D7785

        AFFECTED FILES
        hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseResult.java
        hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java
        hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java
        hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseCellMap.java
        hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseRow.java
        hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/18723/

        To: JIRA, navis

        Show
        Phabricator added a comment - navis requested code review of " HIVE-3864 [jira] Avoid unnecessary array copy in hbase handler". Reviewers: JIRA DPAL-1958 Avoid unnecessary array copy in hbase handler KeyValue[] in hbase.Result is created for each row and need not to be copied. And also values are not needed to be copied. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D7785 AFFECTED FILES hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseResult.java hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseCellMap.java hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseRow.java hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/18723/ To: JIRA, navis
        Navis made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Navis created issue -

          People

          • Assignee:
            Navis
            Reporter:
            Navis
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development