Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
None
-
None
-
None
Description
There are 10 files which seem to have CRLF endings in the Hive repo right now. This becomes visible when using Mac OS X and cloning Hive's git repository.
HIVE-3839 introduced a new .gitattributes file which will make sure that going forward no code containing CRLF gets checked-in going forward. However, I am not sure if we took care of existing code that already contains CRLF.
In Hadoop, HADOOP-8912 introduced the .gitattributes file but HADOOP-8911 normalized existing files to get rid of their CRLF endings. I can't find a similar check-in in Hive before we commited HIVE-3839.
But that's ok, it's not too late. This check-in will normalize any files in Hive that presently have one or more CRLF endings.
The following are the 10 files I could find:
# modified: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardUnionObjectInspector.java # modified: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionObjectInspector.java # modified: serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ListTypeInfo.java # modified: serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/MapTypeInfo.java # modified: serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java # modified: serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/StructTypeInfo.java # modified: serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java # modified: serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java # modified: serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java # modified: serde/src/test/org/apache/hadoop/hive/serde2/thrift_test/CreateSequenceFile.java