Details

      Description

      The subtask to track changes in the core hive components for HiveServer2 implementation

        Issue Links

          Activity

          Hide
          Prasad Mujumdar added a comment -

          Code review request on https://reviews.facebook.net/D7281

          Show
          Prasad Mujumdar added a comment - Code review request on https://reviews.facebook.net/D7281
          Hide
          Mark Grover added a comment -

          FWIW, this patch doesn't apply cleanly on trunk. There is a conflict with conf/hive-default.xml.template

          ***************
          *** 1581,1590 ****
            </property>
            
            <property>
          -    <name>hive.decode.partition.name</name>
          -    <value>false</value>
          -    <description>Whether to show the unquoted partition names in query results.</description>
            </property>
            
            </configuration>
            
          --- 1580,1660 ----
            </property>
            
            <property>
          +   <name>hive.server2.thrift.min.worker.threads</name>
          +   <value>5</value>
          +   <description>Minimum number of Thrift worker threads</description>
          + </property>
          + 
          + <property>
          +   <name>hive.server2.thrift.max.worker.threads</name>
          +   <value>100</value>
          +   <description>Maximum number of Thrift worker threads</description>
          + </property>
          + 
          

          I don't it's necessary to refresh the patch now (but it wouldn't hurt) since we are still waiting for review but it would need to be refreshed before submission.

          Show
          Mark Grover added a comment - FWIW, this patch doesn't apply cleanly on trunk. There is a conflict with conf/hive-default.xml.template *************** *** 1581,1590 **** </property> <property> - <name>hive.decode.partition.name</name> - <value> false </value> - <description>Whether to show the unquoted partition names in query results.</description> </property> </configuration> --- 1580,1660 ---- </property> <property> + <name>hive.server2.thrift.min.worker.threads</name> + <value>5</value> + <description>Minimum number of Thrift worker threads</description> + </property> + + <property> + <name>hive.server2.thrift.max.worker.threads</name> + <value>100</value> + <description>Maximum number of Thrift worker threads</description> + </property> + I don't it's necessary to refresh the patch now (but it wouldn't hurt) since we are still waiting for review but it would need to be refreshed before submission.
          Hide
          Namit Jain added a comment -

          initial comments

          Show
          Namit Jain added a comment - initial comments
          Hide
          Namit Jain added a comment -

          I am sorry for the delay on my part.
          Can you refresh ? I will definitely review this time.

          Show
          Namit Jain added a comment - I am sorry for the delay on my part. Can you refresh ? I will definitely review this time.
          Hide
          Namit Jain added a comment -
          Show
          Namit Jain added a comment - cc Mark Grover , Prasad Mujumdar
          Hide
          Prasad Mujumdar added a comment -

          Thanks Namit.
          I will rebase the patch and upload the new diff.

          Show
          Prasad Mujumdar added a comment - Thanks Namit. I will rebase the patch and upload the new diff.
          Hide
          Thejas M Nair added a comment -

          Hi Namit Jain Rebased patch has been uploaded by Prasad in HIVE-2935. Can you please review it using the phabricator link there ? The phabricator upload has only files that have changed.

          Show
          Thejas M Nair added a comment - Hi Namit Jain Rebased patch has been uploaded by Prasad in HIVE-2935 . Can you please review it using the phabricator link there ? The phabricator upload has only files that have changed.

            People

            • Assignee:
              Prasad Mujumdar
              Reporter:
              Prasad Mujumdar
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development