Details

      Description

      The subtask to track changes in the core hive components for HiveServer2 implementation

        Issue Links

          Activity

          Hide
          prasadm Prasad Mujumdar added a comment -

          Code review request on https://reviews.facebook.net/D7281

          Show
          prasadm Prasad Mujumdar added a comment - Code review request on https://reviews.facebook.net/D7281
          Hide
          mgrover Mark Grover added a comment -

          FWIW, this patch doesn't apply cleanly on trunk. There is a conflict with conf/hive-default.xml.template

          ***************
          *** 1581,1590 ****
            </property>
            
            <property>
          -    <name>hive.decode.partition.name</name>
          -    <value>false</value>
          -    <description>Whether to show the unquoted partition names in query results.</description>
            </property>
            
            </configuration>
            
          --- 1580,1660 ----
            </property>
            
            <property>
          +   <name>hive.server2.thrift.min.worker.threads</name>
          +   <value>5</value>
          +   <description>Minimum number of Thrift worker threads</description>
          + </property>
          + 
          + <property>
          +   <name>hive.server2.thrift.max.worker.threads</name>
          +   <value>100</value>
          +   <description>Maximum number of Thrift worker threads</description>
          + </property>
          + 
          

          I don't it's necessary to refresh the patch now (but it wouldn't hurt) since we are still waiting for review but it would need to be refreshed before submission.

          Show
          mgrover Mark Grover added a comment - FWIW, this patch doesn't apply cleanly on trunk. There is a conflict with conf/hive-default.xml.template *************** *** 1581,1590 **** </property> <property> - <name>hive.decode.partition.name</name> - <value> false </value> - <description>Whether to show the unquoted partition names in query results.</description> </property> </configuration> --- 1580,1660 ---- </property> <property> + <name>hive.server2.thrift.min.worker.threads</name> + <value>5</value> + <description>Minimum number of Thrift worker threads</description> + </property> + + <property> + <name>hive.server2.thrift.max.worker.threads</name> + <value>100</value> + <description>Maximum number of Thrift worker threads</description> + </property> + I don't it's necessary to refresh the patch now (but it wouldn't hurt) since we are still waiting for review but it would need to be refreshed before submission.
          Hide
          namit Namit Jain added a comment -

          initial comments

          Show
          namit Namit Jain added a comment - initial comments
          Hide
          namit Namit Jain added a comment -

          I am sorry for the delay on my part.
          Can you refresh ? I will definitely review this time.

          Show
          namit Namit Jain added a comment - I am sorry for the delay on my part. Can you refresh ? I will definitely review this time.
          Hide
          namit Namit Jain added a comment -
          Show
          namit Namit Jain added a comment - cc Mark Grover , Prasad Mujumdar
          Hide
          prasadm Prasad Mujumdar added a comment -

          Thanks Namit.
          I will rebase the patch and upload the new diff.

          Show
          prasadm Prasad Mujumdar added a comment - Thanks Namit. I will rebase the patch and upload the new diff.
          Hide
          thejas Thejas M Nair added a comment -

          Hi Namit Jain Rebased patch has been uploaded by Prasad in HIVE-2935. Can you please review it using the phabricator link there ? The phabricator upload has only files that have changed.

          Show
          thejas Thejas M Nair added a comment - Hi Namit Jain Rebased patch has been uploaded by Prasad in HIVE-2935 . Can you please review it using the phabricator link there ? The phabricator upload has only files that have changed.

            People

            • Assignee:
              prasadm Prasad Mujumdar
              Reporter:
              prasadm Prasad Mujumdar
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development