Hive
  1. Hive
  2. HIVE-3724

Metastore tests use hardcoded ports

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.10.0
    • Component/s: Tests
    • Labels:
      None

      Description

      Several of the metastore tests use hardcoded ports for remote metastore Thrift servers. This is causing transient failures in Jenkins, e.g. https://builds.apache.org/job/Hive-trunk-h0.21/1804/

      A few tests already dynamically determine free ports, and this logic can be shared.

      1. hive-3724.svn-0.10.patch
        13 kB
        Sushanth Sowmyan
      2. HIVE-3724.2.patch.txt
        13 kB
        Kevin Wilfong
      3. HIVE-3724.1.patch.txt
        11 kB
        Kevin Wilfong

        Activity

        Hide
        Ashutosh Chauhan added a comment -

        This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

        Show
        Ashutosh Chauhan added a comment - This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-3724 : Metastore tests use hardcoded ports (Kevin Wilfong via Ashutosh Chauhan) (Revision 1415917)

        Result = ABORTED
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415917
        Files :

        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEndFunctionListener.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestSetUGIOnOnlyClient.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestSetUGIOnOnlyServer.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-3724 : Metastore tests use hardcoded ports (Kevin Wilfong via Ashutosh Chauhan) (Revision 1415917) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415917 Files : /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEndFunctionListener.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestSetUGIOnOnlyClient.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestSetUGIOnOnlyServer.java
        Hide
        Ashutosh Chauhan added a comment -

        Committed to 0.10 branch. Thanks, Sushanth for backport!

        Show
        Ashutosh Chauhan added a comment - Committed to 0.10 branch. Thanks, Sushanth for backport!
        Hide
        Sushanth Sowmyan added a comment -

        Adding 0.10 version of the patch.

        Show
        Sushanth Sowmyan added a comment - Adding 0.10 version of the patch.
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1828 (See https://builds.apache.org/job/Hive-trunk-h0.21/1828/)
        HIVE-3724 : Metastore tests use hardcoded ports (Kevin Wilfong via Ashutosh Chauhan) (Revision 1415917)

        Result = FAILURE
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415917
        Files :

        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEndFunctionListener.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestSetUGIOnOnlyClient.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestSetUGIOnOnlyServer.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1828 (See https://builds.apache.org/job/Hive-trunk-h0.21/1828/ ) HIVE-3724 : Metastore tests use hardcoded ports (Kevin Wilfong via Ashutosh Chauhan) (Revision 1415917) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415917 Files : /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEndFunctionListener.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestSetUGIOnOnlyClient.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestSetUGIOnOnlyServer.java
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Kevin!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Kevin!
        Hide
        Mark Grover added a comment -

        +1 (non-committer)

        Show
        Mark Grover added a comment - +1 (non-committer)
        Hide
        Ashutosh Chauhan added a comment -

        +1

        Show
        Ashutosh Chauhan added a comment - +1
        Hide
        Kevin Wilfong added a comment -

        Thanks Ashutosh, switched to using that method in the refactored tests, and deleted the duplicate method.

        Show
        Kevin Wilfong added a comment - Thanks Ashutosh, switched to using that method in the refactored tests, and deleted the duplicate method.
        Hide
        Ashutosh Chauhan added a comment -

        We can reuse MetaStoreUtils::startMetaStore() for some of this refactoring which has a nice property of not waiting for fixed amount of time. See, its usage in TestMetaStoreAuthorization::testMetaStoreAuthorization.

        Show
        Ashutosh Chauhan added a comment - We can reuse MetaStoreUtils::startMetaStore() for some of this refactoring which has a nice property of not waiting for fixed amount of time. See, its usage in TestMetaStoreAuthorization::testMetaStoreAuthorization.
        Show
        Kevin Wilfong added a comment - https://reviews.facebook.net/D6825

          People

          • Assignee:
            Kevin Wilfong
            Reporter:
            Kevin Wilfong
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development