Hive
  1. Hive
  2. HIVE-3718

Add check to determine whether partition can be dropped at Semantic Analysis time

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: CLI
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HIVE-3718.6.patch.txt
      9 kB
      Pamela Vagata
    2. HIVE-3718.5.patch.txt
      3 kB
      Pamela Vagata
    3. hive.3718.4.patch
      3 kB
      Namit Jain
    4. HIVE-3718.3.patch.txt
      3 kB
      Pamela Vagata
    5. HIVE-3718.2.patch.txt
      3 kB
      Pamela Vagata
    6. HIVE-3718.1.patch.txt
      3 kB
      Pamela Vagata

      Activity

      Hide
      Hudson added a comment -

      Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
      HIVE-3718 Add check to determine whether partition can be dropped at
      Semantic Analysis time (Pamela Vagata via namit) (Revision 1428704)

      Result = ABORTED
      namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1428704
      Files :

      • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
      • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
      • /hive/trunk/ql/src/test/queries/clientnegative/sa_fail_hook3.q
      • /hive/trunk/ql/src/test/results/clientnegative/alter_partition_nodrop.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/protectmode_part_no_drop.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/protectmode_tbl7.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/protectmode_tbl8.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/sa_fail_hook3.q.out
      Show
      Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-3718 Add check to determine whether partition can be dropped at Semantic Analysis time (Pamela Vagata via namit) (Revision 1428704) Result = ABORTED namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1428704 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java /hive/trunk/ql/src/test/queries/clientnegative/sa_fail_hook3.q /hive/trunk/ql/src/test/results/clientnegative/alter_partition_nodrop.q.out /hive/trunk/ql/src/test/results/clientnegative/protectmode_part_no_drop.q.out /hive/trunk/ql/src/test/results/clientnegative/protectmode_tbl7.q.out /hive/trunk/ql/src/test/results/clientnegative/protectmode_tbl8.q.out /hive/trunk/ql/src/test/results/clientnegative/sa_fail_hook3.q.out
      Hide
      Hudson added a comment -

      Integrated in Hive-trunk-h0.21 #1893 (See https://builds.apache.org/job/Hive-trunk-h0.21/1893/)
      HIVE-3718 Add check to determine whether partition can be dropped at
      Semantic Analysis time (Pamela Vagata via namit) (Revision 1428704)

      Result = SUCCESS
      namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1428704
      Files :

      • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
      • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
      • /hive/trunk/ql/src/test/queries/clientnegative/sa_fail_hook3.q
      • /hive/trunk/ql/src/test/results/clientnegative/alter_partition_nodrop.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/protectmode_part_no_drop.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/protectmode_tbl7.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/protectmode_tbl8.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/sa_fail_hook3.q.out
      Show
      Hudson added a comment - Integrated in Hive-trunk-h0.21 #1893 (See https://builds.apache.org/job/Hive-trunk-h0.21/1893/ ) HIVE-3718 Add check to determine whether partition can be dropped at Semantic Analysis time (Pamela Vagata via namit) (Revision 1428704) Result = SUCCESS namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1428704 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java /hive/trunk/ql/src/test/queries/clientnegative/sa_fail_hook3.q /hive/trunk/ql/src/test/results/clientnegative/alter_partition_nodrop.q.out /hive/trunk/ql/src/test/results/clientnegative/protectmode_part_no_drop.q.out /hive/trunk/ql/src/test/results/clientnegative/protectmode_tbl7.q.out /hive/trunk/ql/src/test/results/clientnegative/protectmode_tbl8.q.out /hive/trunk/ql/src/test/results/clientnegative/sa_fail_hook3.q.out
      Hide
      Namit Jain added a comment -

      Committed. Thanks Pamela

      Show
      Namit Jain added a comment - Committed. Thanks Pamela
      Hide
      Namit Jain added a comment -

      +1

      running tests

      Show
      Namit Jain added a comment - +1 running tests
      Show
      Pamela Vagata added a comment - Updated diff https://reviews.facebook.net/differential/diff/24891/
      Hide
      Pamela Vagata added a comment -

      I ran all the tests, looks like the test (sa_fail_hook3.q) included with the diff is actually failing - I'll fix it up.

      Show
      Pamela Vagata added a comment - I ran all the tests, looks like the test (sa_fail_hook3.q) included with the diff is actually failing - I'll fix it up.
      Hide
      Namit Jain added a comment -

      Did you run the following test : drop_partitions_ignore_protection.q ?
      Seems like it would fail.

      Show
      Namit Jain added a comment - Did you run the following test : drop_partitions_ignore_protection.q ? Seems like it would fail.
      Hide
      Pamela Vagata added a comment -
      Show
      Pamela Vagata added a comment - updated https://reviews.facebook.net/D6783
      Hide
      Namit Jain added a comment -

      Can you create a phabricator entry also ?
      It is much easier to review.

      Show
      Namit Jain added a comment - Can you create a phabricator entry also ? It is much easier to review.
      Hide
      Pamela Vagata added a comment -

      there isn't a code difference, the hive-3718.3.patch.txt was produced so that the file names had prefixes on them, which is why you couldn't run the tests; I ran git diff --no-prefix to produce hive-3718.5.patch.txt and ran the tests to make sure it would work.

      Show
      Pamela Vagata added a comment - there isn't a code difference, the hive-3718.3.patch.txt was produced so that the file names had prefixes on them, which is why you couldn't run the tests; I ran git diff --no-prefix to produce hive-3718.5.patch.txt and ran the tests to make sure it would work.
      Hide
      Namit Jain added a comment -

      HIVE-3718.5.patch.txt and HIVE-3718.3.patch.txt are exactly the same

      Show
      Namit Jain added a comment - HIVE-3718 .5.patch.txt and HIVE-3718 .3.patch.txt are exactly the same
      Hide
      Pamela Vagata added a comment -

      Sorry about the previous patch - forgot to run git diff with option --no-prefix, I ran the tests with this patch and it all passes.

      Show
      Pamela Vagata added a comment - Sorry about the previous patch - forgot to run git diff with option --no-prefix, I ran the tests with this patch and it all passes.
      Hide
      Namit Jain added a comment -

      drop_partitions_ignore_protection.q fails

      Show
      Namit Jain added a comment - drop_partitions_ignore_protection.q fails
      Hide
      Namit Jain added a comment -

      For some reason, I could not run parallel tests on the git patch - applying a new patch to run tests

      Show
      Namit Jain added a comment - For some reason, I could not run parallel tests on the git patch - applying a new patch to run tests
      Hide
      Namit Jain added a comment -

      Running tests

      Show
      Namit Jain added a comment - Running tests
      Hide
      Pamela Vagata added a comment -

      done, thanks!

      Show
      Pamela Vagata added a comment - done, thanks!
      Hide
      Namit Jain added a comment -

      +1

      The patch file looks good. Can you refresh the phabricator entry also ?

      Show
      Namit Jain added a comment - +1 The patch file looks good. Can you refresh the phabricator entry also ?
      Hide
      Pamela Vagata added a comment -

      patch 3 is updated to use 30011 error message

      Show
      Pamela Vagata added a comment - patch 3 is updated to use 30011 error message
      Hide
      Pamela Vagata added a comment -

      ping Just wanted to make sure this didn't fall off the radar

      Show
      Pamela Vagata added a comment - ping Just wanted to make sure this didn't fall off the radar
      Hide
      Pamela Vagata added a comment -

      Got it, I've updated to use 30011

      Show
      Pamela Vagata added a comment - Got it, I've updated to use 30011
      Hide
      Namit Jain added a comment -

      30005 is already being used. Can you use a new error code ?

      Show
      Namit Jain added a comment - 30005 is already being used. Can you use a new error code ?
      Hide
      Pamela Vagata added a comment -

      I just refreshed and attached new patch, it doesn't look different from the previous one though.

      Show
      Pamela Vagata added a comment - I just refreshed and attached new patch, it doesn't look different from the previous one though.
      Hide
      Namit Jain added a comment -

      Can you refresh ? This conflicts with patch which got checked in.

      Show
      Namit Jain added a comment - Can you refresh ? This conflicts with patch which got checked in.
      Hide
      Kevin Wilfong added a comment -

      +1

      Show
      Kevin Wilfong added a comment - +1
      Show
      Kevin Wilfong added a comment - https://reviews.facebook.net/D6783

        People

        • Assignee:
          Pamela Vagata
          Reporter:
          Pamela Vagata
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development