Hive
  1. Hive
  2. HIVE-3622

reflect udf cannot find method which has arguments of primitive types and String, Binary, Timestamp types mixed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: UDF
    • Labels:
      None

      Description

      From http://mail-archives.apache.org/mod_mbox/hive-user/201210.mbox/%3CCANkN6JApahvYrVuiy-j4VJ0dO2tzTpePwi7LUNCp12Vwj6d6xw%40mail.gmail.com%3E
      <noformat>
      Query
      select reflect('java.lang.Integer', 'parseInt', 'a', 16) from src limit 1;

      throws java.lang.NoSuchMethodException: java.lang.Integer.parseInt(null, int)
      <noformat>

      1. HIVE-3622.D6201.1.patch
        5 kB
        Phabricator
      2. HIVE-3622.D6201.2.patch
        9 kB
        Phabricator

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-3622 : reflect udf cannot find method which has arguments of primitive types and String, Binary, Timestamp types mixed (Navis via Ashutosh Chauhan) (Revision 1419577)

        Result = ABORTED
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1419577
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect.java
        • /hive/trunk/ql/src/test/queries/clientpositive/udf_reflect.q
        • /hive/trunk/ql/src/test/results/clientpositive/udf_reflect.q.out
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-3622 : reflect udf cannot find method which has arguments of primitive types and String, Binary, Timestamp types mixed (Navis via Ashutosh Chauhan) (Revision 1419577) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1419577 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect.java /hive/trunk/ql/src/test/queries/clientpositive/udf_reflect.q /hive/trunk/ql/src/test/results/clientpositive/udf_reflect.q.out
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1849 (See https://builds.apache.org/job/Hive-trunk-h0.21/1849/)
        HIVE-3622 : reflect udf cannot find method which has arguments of primitive types and String, Binary, Timestamp types mixed (Navis via Ashutosh Chauhan) (Revision 1419577)

        Result = FAILURE
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1419577
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect.java
        • /hive/trunk/ql/src/test/queries/clientpositive/udf_reflect.q
        • /hive/trunk/ql/src/test/results/clientpositive/udf_reflect.q.out
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1849 (See https://builds.apache.org/job/Hive-trunk-h0.21/1849/ ) HIVE-3622 : reflect udf cannot find method which has arguments of primitive types and String, Binary, Timestamp types mixed (Navis via Ashutosh Chauhan) (Revision 1419577) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1419577 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect.java /hive/trunk/ql/src/test/queries/clientpositive/udf_reflect.q /hive/trunk/ql/src/test/results/clientpositive/udf_reflect.q.out
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Navis!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Navis!
        Hide
        Ashutosh Chauhan added a comment -

        +1

        Show
        Ashutosh Chauhan added a comment - +1
        Hide
        Phabricator added a comment -

        navis updated the revision "HIVE-3622 [jira] reflect udf cannot find method which has arguments of primitive types and String, Binary, Timestamp types mixed".
        Reviewers: JIRA, cwsteinbach

        Addressed comments & rebased on trunk

        REVISION DETAIL
        https://reviews.facebook.net/D6201

        AFFECTED FILES
        ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect.java
        ql/src/test/queries/clientpositive/udf_reflect.q
        ql/src/test/results/clientpositive/udf_reflect.q.out

        To: JIRA, cwsteinbach, navis

        Show
        Phabricator added a comment - navis updated the revision " HIVE-3622 [jira] reflect udf cannot find method which has arguments of primitive types and String, Binary, Timestamp types mixed". Reviewers: JIRA, cwsteinbach Addressed comments & rebased on trunk REVISION DETAIL https://reviews.facebook.net/D6201 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect.java ql/src/test/queries/clientpositive/udf_reflect.q ql/src/test/results/clientpositive/udf_reflect.q.out To: JIRA, cwsteinbach, navis
        Hide
        Ashutosh Chauhan added a comment -

        Navis Can you update the patch? I will take care of testing and committing it.

        Show
        Ashutosh Chauhan added a comment - Navis Can you update the patch? I will take care of testing and committing it.
        Hide
        Phabricator added a comment -

        cwsteinbach has accepted the revision "HIVE-3622 [jira] reflect udf cannot find method which has arguments of primitive types and String, Binary, Timestamp types mixed".

        INLINE COMMENTS
        ql/src/test/queries/clientpositive/udf_reflect.q:25 May as well save some test time and add this to the first query.
        ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect.java:196 Please expand on this comment. What's ambiguous?

        REVISION DETAIL
        https://reviews.facebook.net/D6201

        BRANCH
        DPAL-1923

        To: JIRA, cwsteinbach, navis

        Show
        Phabricator added a comment - cwsteinbach has accepted the revision " HIVE-3622 [jira] reflect udf cannot find method which has arguments of primitive types and String, Binary, Timestamp types mixed". INLINE COMMENTS ql/src/test/queries/clientpositive/udf_reflect.q:25 May as well save some test time and add this to the first query. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect.java:196 Please expand on this comment. What's ambiguous? REVISION DETAIL https://reviews.facebook.net/D6201 BRANCH DPAL-1923 To: JIRA, cwsteinbach, navis
        Hide
        Carl Steinbach added a comment -

        +1

        @Navis: I left two small comments on Phabricator, neither of which requires a second review round. Can you please test and commit this on your own? Thanks.

        Show
        Carl Steinbach added a comment - +1 @Navis: I left two small comments on Phabricator, neither of which requires a second review round. Can you please test and commit this on your own? Thanks.
        Hide
        Phabricator added a comment -

        navis requested code review of "HIVE-3622 [jira] reflect udf cannot find method which has arguments of primitive types and String, Binary, Timestamp types mixed".
        Reviewers: JIRA

        DPAL-1923 reflect udf cannot find method which has arguments of primitive types and String, Binary, Timestamp types mixed

        From http://mail-archives.apache.org/mod_mbox/hive-user/201210.mbox/%3CCANkN6JApahvYrVuiy-j4VJ0dO2tzTpePwi7LUNCp12Vwj6d6xw%40mail.gmail.com%3E
        <noformat>
        Query
        select reflect('java.lang.Integer', 'parseInt', 'a', 16) from src limit 1;

        throws java.lang.NoSuchMethodException: java.lang.Integer.parseInt(null, int)
        <noformat>

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D6201

        AFFECTED FILES
        ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect.java
        ql/src/test/queries/clientpositive/udf_reflect.q
        ql/src/test/results/clientpositive/udf_reflect.q.out

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/14799/

        To: JIRA, navis

        Show
        Phabricator added a comment - navis requested code review of " HIVE-3622 [jira] reflect udf cannot find method which has arguments of primitive types and String, Binary, Timestamp types mixed". Reviewers: JIRA DPAL-1923 reflect udf cannot find method which has arguments of primitive types and String, Binary, Timestamp types mixed From http://mail-archives.apache.org/mod_mbox/hive-user/201210.mbox/%3CCANkN6JApahvYrVuiy-j4VJ0dO2tzTpePwi7LUNCp12Vwj6d6xw%40mail.gmail.com%3E <noformat> Query select reflect('java.lang.Integer', 'parseInt', 'a', 16) from src limit 1; throws java.lang.NoSuchMethodException: java.lang.Integer.parseInt(null, int) <noformat> TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D6201 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect.java ql/src/test/queries/clientpositive/udf_reflect.q ql/src/test/results/clientpositive/udf_reflect.q.out MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/14799/ To: JIRA, navis

          People

          • Assignee:
            Navis
            Reporter:
            Navis
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development