Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-3621

Make prompt in Hive CLI configurable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.0
    • Fix Version/s: 0.10.0
    • Component/s: CLI
    • Labels:

      Description

      Right now the Hive CLI prompt just says "hive>", for users (primarily power users) who run in different clusters it can be easy to forget which cluster your Hive CLI is pointing to. If we change the Hive CLI prompt to be something like "hive(silver)>" it would be much clearer. We could potentially extend this to namespaces as well.

      1. HIVE-3621.patch.1.txt
        2 kB
        Jingwei Lu
      2. HIVE-3621.patch.2.txt
        2 kB
        Jingwei Lu

        Activity

        Hide
        ashutoshc Ashutosh Chauhan added a comment -

        This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

        Show
        ashutoshc Ashutosh Chauhan added a comment - This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.
        Hide
        hudson Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-3621. Make prompt in Hive CLI configurable. (Jingwei Lu via kevinwilfong) (Revision 1407581)

        Result = ABORTED
        kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1407581
        Files :

        • /hive/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
        • /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
        • /hive/trunk/conf/hive-default.xml.template
        Show
        hudson Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-3621 . Make prompt in Hive CLI configurable. (Jingwei Lu via kevinwilfong) (Revision 1407581) Result = ABORTED kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1407581 Files : /hive/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java /hive/trunk/conf/hive-default.xml.template
        Hide
        hudson Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1787 (See https://builds.apache.org/job/Hive-trunk-h0.21/1787/)
        HIVE-3621. Make prompt in Hive CLI configurable. (Jingwei Lu via kevinwilfong) (Revision 1407581)

        Result = FAILURE
        kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1407581
        Files :

        • /hive/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
        • /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
        • /hive/trunk/conf/hive-default.xml.template
        Show
        hudson Hudson added a comment - Integrated in Hive-trunk-h0.21 #1787 (See https://builds.apache.org/job/Hive-trunk-h0.21/1787/ ) HIVE-3621 . Make prompt in Hive CLI configurable. (Jingwei Lu via kevinwilfong) (Revision 1407581) Result = FAILURE kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1407581 Files : /hive/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java /hive/trunk/conf/hive-default.xml.template
        Hide
        kevinwilfong Kevin Wilfong added a comment -

        Committed, thanks Jingwei.

        Show
        kevinwilfong Kevin Wilfong added a comment - Committed, thanks Jingwei.
        Hide
        kevinwilfong Kevin Wilfong added a comment -

        Thanks +1

        Show
        kevinwilfong Kevin Wilfong added a comment - Thanks +1
        Hide
        jingweilu Jingwei Lu added a comment -

        I had trouble to amend the old diff. Create a new diff to respond the comment.

        https://reviews.facebook.net/D6573

        Show
        jingweilu Jingwei Lu added a comment - I had trouble to amend the old diff. Create a new diff to respond the comment. https://reviews.facebook.net/D6573
        Hide
        kevinwilfong Kevin Wilfong added a comment -

        One minor comment on Phabricator, otherwise looks good.

        Show
        kevinwilfong Kevin Wilfong added a comment - One minor comment on Phabricator, otherwise looks good.
        Hide
        mgrover Mark Grover added a comment -

        Nevermind, I missed it. Looks good to me. Thanks!

        Show
        mgrover Mark Grover added a comment - Nevermind, I missed it. Looks good to me. Thanks!
        Hide
        jingweilu Jingwei Lu added a comment -

        I do explicitly state that hiveconf can be used in the new configuration. If it is not clear, your suggestion are welcome.

        Show
        jingweilu Jingwei Lu added a comment - I do explicitly state that hiveconf can be used in the new configuration. If it is not clear, your suggestion are welcome.
        Hide
        mgrover Mark Grover added a comment -

        +1 on the idea!

        I would suggest explicitly specifying in the description section that users can refer to hive-conf variables in the value for this property.

        Show
        mgrover Mark Grover added a comment - +1 on the idea! I would suggest explicitly specifying in the description section that users can refer to hive-conf variables in the value for this property.
        Show
        jingweilu Jingwei Lu added a comment - https://reviews.facebook.net/D6387
        Hide
        kevinwilfong Kevin Wilfong added a comment -

        Can you give a link to your Phabricator diff in a comment and hit the Submit Patch button if you're ready for review.

        Show
        kevinwilfong Kevin Wilfong added a comment - Can you give a link to your Phabricator diff in a comment and hit the Submit Patch button if you're ready for review.

          People

          • Assignee:
            jingweilu Jingwei Lu
            Reporter:
            jingweilu Jingwei Lu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 48h
              48h
              Remaining:
              Remaining Estimate - 48h
              48h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development