Hive
  1. Hive
  2. HIVE-3553

Support binary qualifiers for Hive/HBase integration

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 0.9.0
    • Fix Version/s: None
    • Component/s: HBase Handler
    • Labels:
      None

      Description

      Along with regular qualifiers, we should support binary HBase qualifiers as well.

      1. HIVE-3553.1.patch.txt
        5 kB
        Swarnim Kulkarni

        Activity

        Hide
        Brock Noland added a comment -

        Sounds good! And thank you for the test

        Show
        Brock Noland added a comment - Sounds good! And thank you for the test
        Hide
        Swarnim Kulkarni added a comment -

        Sounds good to me as well. I'll make the change and try to have an updated patch soon.

        Show
        Swarnim Kulkarni added a comment - Sounds good to me as well. I'll make the change and try to have an updated patch soon.
        Hide
        Brock Noland added a comment -

        Ahh ok, that makes sense. So the change to Bytes.toBytesBinary() will break some users and we'll need to create our own utility method to do the conversion.

        Show
        Brock Noland added a comment - Ahh ok, that makes sense. So the change to Bytes.toBytesBinary() will break some users and we'll need to create our own utility method to do the conversion.
        Hide
        Navis added a comment -

        Brock Noland Bytes.toBytes() makes byte[] by String.getBytes("UTF8"). But Bytes.toBytesBinary() regards all input chars as ascii. I was implying that.

        Show
        Navis added a comment - Brock Noland Bytes.toBytes() makes byte[] by String.getBytes("UTF8"). But Bytes.toBytesBinary() regards all input chars as ascii. I was implying that.
        Hide
        Brock Noland added a comment -

        Feedback provided on RB.

        Show
        Brock Noland added a comment - Feedback provided on RB.
        Hide
        Brock Noland added a comment -

        Navis is there a place we aren't correctly using UTF-8 charset? Or am I misunderstanding your comment?

        Show
        Brock Noland added a comment - Navis is there a place we aren't correctly using UTF-8 charset? Or am I misunderstanding your comment?
        Hide
        Navis added a comment -

        I've seen some cases using UTF string as qualifier. I think we should make utility method which can convert both side of usage.

        Show
        Navis added a comment - I've seen some cases using UTF string as qualifier. I think we should make utility method which can convert both side of usage.
        Hide
        Swarnim Kulkarni added a comment -

        If someone can take a quick look at this patch, I will highly appreciate that. Should be pretty quick. Thanks!

        Show
        Swarnim Kulkarni added a comment - If someone can take a quick look at this patch, I will highly appreciate that. Should be pretty quick. Thanks!
        Hide
        Swarnim Kulkarni added a comment -
        Show
        Swarnim Kulkarni added a comment - Review request: https://reviews.apache.org/r/9275/
        Hide
        Swarnim Kulkarni added a comment -

        This is a very small patch which is ready for review. Should I open up a phabricator review for this to get reviewed or the patch should be good enough to review directly?

        Show
        Swarnim Kulkarni added a comment - This is a very small patch which is ready for review. Should I open up a phabricator review for this to get reviewed or the patch should be good enough to review directly?
        Hide
        Swarnim Kulkarni added a comment -

        This patch should be up for review now.

        Show
        Swarnim Kulkarni added a comment - This patch should be up for review now.

          People

          • Assignee:
            Swarnim Kulkarni
            Reporter:
            Swarnim Kulkarni
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:

              Development