njain has commented on the revision "
HIVE-3381 [jira] Result of outer join is not valid".
Navis, I know I am asking pretty naive questions here, but I am not able to proceed.
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java:363 Can you add more comments everywhere ?
I know that the old code also did not have many good comments, but it would be really
It is really difficult for me to be sure.
I reviewed some test results, and they look fine.
As you correctly said, this is hard. It would really help if you have a small example
explained in comments in the code. It would really increase the maintainability of this
code bigtime. Something like:
for Query :::
where the data is :::
the aliasFilterTags will be::
I know I am asking for too much, but this code is too risky to change.
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java:396 General comment: please add lots of comments for all the private functions.
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java:352 What is a skipvector ? Going to the comment below, can you explain with a query/data
example. Same for offsets.
To: JIRA, navis