Hive
  1. Hive
  2. HIVE-3268

expressions in cluster by are not working

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: Query Processor
    • Labels:
      None

      Description

      The following query fails:

      select key+key, value from src cluster by key+key, value;

      1. hive.3268.1.patch
        18 kB
        Namit Jain
      2. hive.3268.2.patch
        22 kB
        Namit Jain

        Issue Links

          Activity

          Steven Wong made changes -
          Link This issue is superceded by HIVE-3573 [ HIVE-3573 ]
          Ashutosh Chauhan made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Ashutosh Chauhan added a comment -

          This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

          Show
          Ashutosh Chauhan added a comment - This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.
          Hide
          Hudson added a comment -

          Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
          HIVE-3573. Revert HIVE-3268. (njain via kevinwilfong) (Revision 1397994)
          HIVE-3268. expressions in cluster by are not working. (njain via kevinwilfong) (Revision 1373918)

          Result = ABORTED
          kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397994
          Files :

          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_clusterby1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby_sortby_1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_orderby1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_sortby1.q
          • /hive/trunk/ql/src/test/results/clientnegative/expr_clusterby1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby_sortby_1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/expr_orderby1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/expr_sortby1.q.out

          kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373918
          Files :

          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_clusterby1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby_sortby_1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_orderby1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_sortby1.q
          • /hive/trunk/ql/src/test/results/clientnegative/expr_clusterby1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby_sortby_1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/expr_orderby1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/expr_sortby1.q.out
          Show
          Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-3573 . Revert HIVE-3268 . (njain via kevinwilfong) (Revision 1397994) HIVE-3268 . expressions in cluster by are not working. (njain via kevinwilfong) (Revision 1373918) Result = ABORTED kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397994 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java /hive/trunk/ql/src/test/queries/clientnegative/expr_clusterby1.q /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby1.q /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby_sortby_1.q /hive/trunk/ql/src/test/queries/clientnegative/expr_orderby1.q /hive/trunk/ql/src/test/queries/clientnegative/expr_sortby1.q /hive/trunk/ql/src/test/results/clientnegative/expr_clusterby1.q.out /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby1.q.out /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby_sortby_1.q.out /hive/trunk/ql/src/test/results/clientnegative/expr_orderby1.q.out /hive/trunk/ql/src/test/results/clientnegative/expr_sortby1.q.out kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373918 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java /hive/trunk/ql/src/test/queries/clientnegative/expr_clusterby1.q /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby1.q /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby_sortby_1.q /hive/trunk/ql/src/test/queries/clientnegative/expr_orderby1.q /hive/trunk/ql/src/test/queries/clientnegative/expr_sortby1.q /hive/trunk/ql/src/test/results/clientnegative/expr_clusterby1.q.out /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby1.q.out /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby_sortby_1.q.out /hive/trunk/ql/src/test/results/clientnegative/expr_orderby1.q.out /hive/trunk/ql/src/test/results/clientnegative/expr_sortby1.q.out
          Hide
          Hudson added a comment -

          Integrated in Hive-trunk-h0.21 #1737 (See https://builds.apache.org/job/Hive-trunk-h0.21/1737/)
          HIVE-3573. Revert HIVE-3268. (njain via kevinwilfong) (Revision 1397994)

          Result = FAILURE
          kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397994
          Files :

          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_clusterby1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby_sortby_1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_orderby1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_sortby1.q
          • /hive/trunk/ql/src/test/results/clientnegative/expr_clusterby1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby_sortby_1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/expr_orderby1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/expr_sortby1.q.out
          Show
          Hudson added a comment - Integrated in Hive-trunk-h0.21 #1737 (See https://builds.apache.org/job/Hive-trunk-h0.21/1737/ ) HIVE-3573 . Revert HIVE-3268 . (njain via kevinwilfong) (Revision 1397994) Result = FAILURE kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397994 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java /hive/trunk/ql/src/test/queries/clientnegative/expr_clusterby1.q /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby1.q /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby_sortby_1.q /hive/trunk/ql/src/test/queries/clientnegative/expr_orderby1.q /hive/trunk/ql/src/test/queries/clientnegative/expr_sortby1.q /hive/trunk/ql/src/test/results/clientnegative/expr_clusterby1.q.out /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby1.q.out /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby_sortby_1.q.out /hive/trunk/ql/src/test/results/clientnegative/expr_orderby1.q.out /hive/trunk/ql/src/test/results/clientnegative/expr_sortby1.q.out
          Kevin Wilfong made changes -
          Link This issue breaks HIVE-3572 [ HIVE-3572 ]
          Carl Steinbach made changes -
          Component/s Query Processor [ 12312586 ]
          Hide
          Hudson added a comment -

          Integrated in Hive-trunk-h0.21 #1611 (See https://builds.apache.org/job/Hive-trunk-h0.21/1611/)
          HIVE-3268. expressions in cluster by are not working. (njain via kevinwilfong) (Revision 1373918)

          Result = SUCCESS
          kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373918
          Files :

          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_clusterby1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby_sortby_1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_orderby1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/expr_sortby1.q
          • /hive/trunk/ql/src/test/results/clientnegative/expr_clusterby1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby_sortby_1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/expr_orderby1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/expr_sortby1.q.out
          Show
          Hudson added a comment - Integrated in Hive-trunk-h0.21 #1611 (See https://builds.apache.org/job/Hive-trunk-h0.21/1611/ ) HIVE-3268 . expressions in cluster by are not working. (njain via kevinwilfong) (Revision 1373918) Result = SUCCESS kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1373918 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java /hive/trunk/ql/src/test/queries/clientnegative/expr_clusterby1.q /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby1.q /hive/trunk/ql/src/test/queries/clientnegative/expr_distributeby_sortby_1.q /hive/trunk/ql/src/test/queries/clientnegative/expr_orderby1.q /hive/trunk/ql/src/test/queries/clientnegative/expr_sortby1.q /hive/trunk/ql/src/test/results/clientnegative/expr_clusterby1.q.out /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby1.q.out /hive/trunk/ql/src/test/results/clientnegative/expr_distributeby_sortby_1.q.out /hive/trunk/ql/src/test/results/clientnegative/expr_orderby1.q.out /hive/trunk/ql/src/test/results/clientnegative/expr_sortby1.q.out
          Kevin Wilfong made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.10.0 [ 12320745 ]
          Resolution Fixed [ 1 ]
          Hide
          Kevin Wilfong added a comment -

          Committed, thanks Namit.

          Show
          Kevin Wilfong added a comment - Committed, thanks Namit.
          Hide
          Kevin Wilfong added a comment -

          Carl Steinbach It's been a week without further comments.

          I remain +1 on it.

          Show
          Kevin Wilfong added a comment - Carl Steinbach It's been a week without further comments. I remain +1 on it.
          Namit Jain made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Namit Jain added a comment -

          comments addressed, latest patch attached

          Show
          Namit Jain added a comment - comments addressed, latest patch attached
          Namit Jain made changes -
          Attachment hive.3268.2.patch [ 12539425 ]
          Hide
          Carl Steinbach added a comment -

          @Namit: I added comments on phabricator. Thanks.

          Show
          Carl Steinbach added a comment - @Namit: I added comments on phabricator. Thanks.
          Carl Steinbach made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Carl Steinbach added a comment -

          Please attach the latest version of this patch to the ticket.

          Show
          Carl Steinbach added a comment - Please attach the latest version of this patch to the ticket.
          Hide
          Kevin Wilfong added a comment -

          +1

          Show
          Kevin Wilfong added a comment - +1
          Hide
          Namit Jain added a comment -

          refresh

          Show
          Namit Jain added a comment - refresh
          Namit Jain made changes -
          Attachment hive.3268.1.patch [ 12538128 ]
          Namit Jain made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Namit Jain made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Namit Jain added a comment -

          Some tests failed - debugging

          Show
          Namit Jain added a comment - Some tests failed - debugging
          Namit Jain made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Namit Jain added a comment -

          Currently, we get a random error.
          It would be much nicer to throw a good semantic error instead.

          Show
          Namit Jain added a comment - Currently, we get a random error. It would be much nicer to throw a good semantic error instead.
          Show
          Namit Jain added a comment - https://reviews.facebook.net/D4269
          Namit Jain made changes -
          Field Original Value New Value
          Assignee Namit Jain [ namit ]
          Namit Jain created issue -

            People

            • Assignee:
              Namit Jain
              Reporter:
              Namit Jain
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development