Hive
  1. Hive
  2. HIVE-3081

ROFL Moment. Numberator and denaminator typos

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.0
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. hive-3081.2.patch.txt
      2 kB
      Edward Capriolo
    2. HIVE-3081.patch.1.txt
      1.0 kB
      Edward Capriolo

      Activity

      Hide
      Edward Capriolo added a comment -

      hive> SELECT * from numbers TABLESAMPLE(BUCKET 11 OUT OF 10 ON number) s;
      FAILED: Error in semantic analysis: Numberator should not be bigger than denaminator in sample clause for table numbers

      Show
      Edward Capriolo added a comment - hive> SELECT * from numbers TABLESAMPLE(BUCKET 11 OUT OF 10 ON number) s; FAILED: Error in semantic analysis: Numberator should not be bigger than denaminator in sample clause for table numbers
      Hide
      Namit Jain added a comment -

      Can you add a test ?

      I am assuming there is no test for this, otherwise you need to change the output for that test

      Show
      Namit Jain added a comment - Can you add a test ? I am assuming there is no test for this, otherwise you need to change the output for that test
      Hide
      Edward Capriolo added a comment -

      Your right. It is in a negative q. test will send another patch.

      Show
      Edward Capriolo added a comment - Your right. It is in a negative q. test will send another patch.
      Hide
      Namit Jain added a comment -

      +1

      Show
      Namit Jain added a comment - +1
      Hide
      Namit Jain added a comment -

      Committed. Thanks Edward

      Show
      Namit Jain added a comment - Committed. Thanks Edward
      Hide
      Hudson added a comment -

      Integrated in Hive-trunk-h0.21 #1484 (See https://builds.apache.org/job/Hive-trunk-h0.21/1484/)
      HIVE-3081 ROFL Moment. Numberator and denaminator typos
      (Edward Capriolo via namit) (Revision 1349584)

      Result = FAILURE
      namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349584
      Files :

      • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
      • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
      • /hive/trunk/ql/src/test/results/clientnegative/sample.q.out
      Show
      Hudson added a comment - Integrated in Hive-trunk-h0.21 #1484 (See https://builds.apache.org/job/Hive-trunk-h0.21/1484/ ) HIVE-3081 ROFL Moment. Numberator and denaminator typos (Edward Capriolo via namit) (Revision 1349584) Result = FAILURE namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349584 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java /hive/trunk/ql/src/test/results/clientnegative/sample.q.out
      Hide
      Hudson added a comment -

      Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
      HIVE-3081 ROFL Moment. Numberator and denaminator typos
      (Edward Capriolo via namit) (Revision 1349584)

      Result = ABORTED
      namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349584
      Files :

      • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
      • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
      • /hive/trunk/ql/src/test/results/clientnegative/sample.q.out
      Show
      Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-3081 ROFL Moment. Numberator and denaminator typos (Edward Capriolo via namit) (Revision 1349584) Result = ABORTED namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349584 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java /hive/trunk/ql/src/test/results/clientnegative/sample.q.out
      Hide
      Ashutosh Chauhan added a comment -

      This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

      Show
      Ashutosh Chauhan added a comment - This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

        People

        • Assignee:
          Edward Capriolo
          Reporter:
          Edward Capriolo
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development