Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:

      Description

      Running ant docs does not work for two reasons:

      a) ant, when called from the docs target, doesn't know what to do with ivy, presumably because the ivy-init-antlib target hasn't been called.
      b) The velocity jar is not pulled in by ivy, since there's no dependency added to it in ivy.

        Issue Links

          Activity

          Hide
          Phabricator added a comment -

          khorgath requested code review of "HIVE-3031 [jira] hive docs target does not work".
          Reviewers: JIRA

          build fixes to make docs target work

          Running ant docs does not work for two reasons:

          a) ant, when called from the docs target, doesn't know what to do with ivy, presumably because the ivy-init-antlib target hasn't been called.
          b) The velocity jar is not pulled in by ivy, since there's no dependency added to it in ivy.

          TEST PLAN
          running 'ant docs' works

          REVISION DETAIL
          https://reviews.facebook.net/D3279

          AFFECTED FILES
          build.xml
          ivy.xml

          MANAGE HERALD DIFFERENTIAL RULES
          https://reviews.facebook.net/herald/view/differential/

          WHY DID I GET THIS EMAIL?
          https://reviews.facebook.net/herald/transcript/7467/

          To: JIRA, khorgath

          Show
          Phabricator added a comment - khorgath requested code review of " HIVE-3031 [jira] hive docs target does not work". Reviewers: JIRA build fixes to make docs target work Running ant docs does not work for two reasons: a) ant, when called from the docs target, doesn't know what to do with ivy, presumably because the ivy-init-antlib target hasn't been called. b) The velocity jar is not pulled in by ivy, since there's no dependency added to it in ivy. TEST PLAN running 'ant docs' works REVISION DETAIL https://reviews.facebook.net/D3279 AFFECTED FILES build.xml ivy.xml MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/7467/ To: JIRA, khorgath
          Hide
          Phabricator added a comment -

          khorgath has added reviewers to the revision "HIVE-3031 [jira] hive docs target does not work".
          Added Reviewers: ashutoshc

          REVISION DETAIL
          https://reviews.facebook.net/D3279

          To: JIRA, ashutoshc, khorgath

          Show
          Phabricator added a comment - khorgath has added reviewers to the revision " HIVE-3031 [jira] hive docs target does not work". Added Reviewers: ashutoshc REVISION DETAIL https://reviews.facebook.net/D3279 To: JIRA, ashutoshc, khorgath
          Hide
          Phabricator added a comment -

          ashutoshc has requested changes to the revision "HIVE-3031 [jira] hive docs target does not work".

          INLINE COMMENTS
          build.xml:187 It will be less invasive if we make docs target to depend on ivy-init-antlib, instead of modifying ivy-init-settings target.

          REVISION DETAIL
          https://reviews.facebook.net/D3279

          BRANCH
          HIVE-3031

          To: JIRA, ashutoshc, khorgath

          Show
          Phabricator added a comment - ashutoshc has requested changes to the revision " HIVE-3031 [jira] hive docs target does not work". INLINE COMMENTS build.xml:187 It will be less invasive if we make docs target to depend on ivy-init-antlib, instead of modifying ivy-init-settings target. REVISION DETAIL https://reviews.facebook.net/D3279 BRANCH HIVE-3031 To: JIRA, ashutoshc, khorgath
          Hide
          Phabricator added a comment -

          khorgath updated the revision "HIVE-3031 [jira] hive docs target does not work".
          Reviewers: JIRA, ashutoshc

          Changed per ashutosh's suggestions. ivy-init-antlib is now called directly from docs

          REVISION DETAIL
          https://reviews.facebook.net/D3279

          AFFECTED FILES
          build.xml
          ivy.xml

          To: JIRA, ashutoshc, khorgath

          Show
          Phabricator added a comment - khorgath updated the revision " HIVE-3031 [jira] hive docs target does not work". Reviewers: JIRA, ashutoshc Changed per ashutosh's suggestions. ivy-init-antlib is now called directly from docs REVISION DETAIL https://reviews.facebook.net/D3279 AFFECTED FILES build.xml ivy.xml To: JIRA, ashutoshc, khorgath
          Hide
          Phabricator added a comment -

          ashutoshc has accepted the revision "HIVE-3031 [jira] hive docs target does not work".

          +1

          REVISION DETAIL
          https://reviews.facebook.net/D3279

          BRANCH
          HIVE-3031

          To: JIRA, ashutoshc, khorgath

          Show
          Phabricator added a comment - ashutoshc has accepted the revision " HIVE-3031 [jira] hive docs target does not work". +1 REVISION DETAIL https://reviews.facebook.net/D3279 BRANCH HIVE-3031 To: JIRA, ashutoshc, khorgath
          Hide
          Ashutosh Chauhan added a comment -

          Committed to trunk. Thanks, Sushanth!

          Show
          Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Sushanth!
          Hide
          Hudson added a comment -

          Integrated in Hive-trunk-h0.21 #1440 (See https://builds.apache.org/job/Hive-trunk-h0.21/1440/)
          HIVE-3031 : hive docs target does not work (Sushanth Sowmyan via Ashutosh Chauhan) (Revision 1340348)

          Result = FAILURE
          hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1340348
          Files :

          • /hive/trunk/build.xml
          • /hive/trunk/ivy.xml
          Show
          Hudson added a comment - Integrated in Hive-trunk-h0.21 #1440 (See https://builds.apache.org/job/Hive-trunk-h0.21/1440/ ) HIVE-3031 : hive docs target does not work (Sushanth Sowmyan via Ashutosh Chauhan) (Revision 1340348) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1340348 Files : /hive/trunk/build.xml /hive/trunk/ivy.xml
          Hide
          Hudson added a comment -

          Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
          HIVE-3031 : hive docs target does not work (Sushanth Sowmyan via Ashutosh Chauhan) (Revision 1340348)

          Result = ABORTED
          hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1340348
          Files :

          • /hive/trunk/build.xml
          • /hive/trunk/ivy.xml
          Show
          Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-3031 : hive docs target does not work (Sushanth Sowmyan via Ashutosh Chauhan) (Revision 1340348) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1340348 Files : /hive/trunk/build.xml /hive/trunk/ivy.xml
          Hide
          Ashutosh Chauhan added a comment -

          This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

          Show
          Ashutosh Chauhan added a comment - This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

            People

            • Assignee:
              Sushanth Sowmyan
              Reporter:
              Sushanth Sowmyan
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development