Hive
  1. Hive
  2. HIVE-2995

Fix broken pdk test dependency on junit

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Issue Links

        Activity

        Hide
        Ashutosh Chauhan added a comment -

        Since, we want HIVE-2646 on 0.9 also, lets do that. As per Carl's comments, this problem will go away but we may have to redo some bits of HIVE-2970 again.

        Show
        Ashutosh Chauhan added a comment - Since, we want HIVE-2646 on 0.9 also, lets do that. As per Carl's comments, this problem will go away but we may have to redo some bits of HIVE-2970 again.
        Hide
        Carl Steinbach added a comment -

        This failure can be easily reproduced on branch-0.9 by applying the following patch, and then running 'ant clean package test':

        diff --git build.xml build.xml
        index 6cc92a3..94906f5 100644
        --- build.xml
        +++ build.xml
        @@ -343,12 +343,9 @@
           
           <target name="test" depends="clean-test,jar-test,ivy-retrieve-hadoop-test" description="Run tests">
             <echo message="Project: ${ant.project.name}"/>
        -    <antcall target="test-shims">
        -      <param name="hadoop.version.ant-internal" value="${hadoop.security.version}" />
        -    </antcall>
             <for keepgoing="${test.continue.on.failure}" param="file">
               <path>
        -        <fileset dir="." includes="*/build.xml" excludes="ant/*,odbc/*,shims/*"/>
        +        <fileset dir="." includes="pdk/build.xml" excludes="ant/*,odbc/*,shims/*"/>
               </path>
               <sequential>
                 <ant antfile="@{file}" target="test" inheritAll="false" inheritRefs="true">
        
        Show
        Carl Steinbach added a comment - This failure can be easily reproduced on branch-0.9 by applying the following patch, and then running 'ant clean package test': diff --git build.xml build.xml index 6cc92a3..94906f5 100644 --- build.xml +++ build.xml @@ -343,12 +343,9 @@ <target name="test" depends="clean-test,jar-test,ivy-retrieve-hadoop-test" description="Run tests"> <echo message="Project: ${ant.project.name}"/> - <antcall target="test-shims"> - <param name="hadoop.version.ant-internal" value="${hadoop.security.version}" /> - </antcall> <for keepgoing="${test.continue.on.failure}" param="file"> <path> - <fileset dir="." includes="*/build.xml" excludes="ant/*,odbc/*,shims/*"/> + <fileset dir="." includes="pdk/build.xml" excludes="ant/*,odbc/*,shims/*"/> </path> <sequential> <ant antfile="@{file}" target="test" inheritAll="false" inheritRefs="true">
        Carl Steinbach made changes -
        Field Original Value New Value
        Link This issue is broken by HIVE-2970 [ HIVE-2970 ]
        Hide
        Carl Steinbach added a comment -

        builtins and pdk test failure on branch-0.9:

        /Users/carl/Work/repos/hive3/build.xml:321: The following error occurred while executing this line:
        /Users/carl/Work/repos/hive3/builtins/build.xml:45: The following error occurred while executing this line:
        /Users/carl/Work/repos/hive3/pdk/scripts/build-plugin.xml:122: The <classpath> for <junit> must include junit.jar if not in Ant's own classpath
        

        This error was introduced by HIVE-2970 which removed a bunch of JARs from Hive's lib directory, including the junit jar. On trunk this problem was masked by the subsequent commit of HIVE-2646, but on branch-0.9 it's still an issue.

        Show
        Carl Steinbach added a comment - builtins and pdk test failure on branch-0.9: /Users/carl/Work/repos/hive3/build.xml:321: The following error occurred while executing this line: /Users/carl/Work/repos/hive3/builtins/build.xml:45: The following error occurred while executing this line: /Users/carl/Work/repos/hive3/pdk/scripts/build-plugin.xml:122: The <classpath> for <junit> must include junit.jar if not in Ant's own classpath This error was introduced by HIVE-2970 which removed a bunch of JARs from Hive's lib directory, including the junit jar. On trunk this problem was masked by the subsequent commit of HIVE-2646 , but on branch-0.9 it's still an issue.
        Carl Steinbach created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Carl Steinbach
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development