Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.1, 0.10.0
    • Component/s: Build Infrastructure
    • Labels:
      None
    1. HIVE-2976-maven.diff.txt
      0.9 kB
      Andrew Bayer
    2. HIVE-2976.patch
      0.5 kB
      Thomas Weise

      Issue Links

        Activity

        Hide
        Thomas Weise added a comment -

        With this change:

        ant clean package maven-build

        ...

        BUILD SUCCESSFUL
        Total time: 1 minute 55 seconds

        Show
        Thomas Weise added a comment - With this change: ant clean package maven-build ... BUILD SUCCESSFUL Total time: 1 minute 55 seconds
        Hide
        Ashutosh Chauhan added a comment -

        @Thomas,

        Carl also has a fix for this, albeit a different one at https://reviews.facebook.net/D2937 I am not sure why didn't get published back on jira.

        Show
        Ashutosh Chauhan added a comment - @Thomas, Carl also has a fix for this, albeit a different one at https://reviews.facebook.net/D2937 I am not sure why didn't get published back on jira.
        Hide
        Thomas Weise added a comment -

        The change from Carl will sidestep the issue. The change I made will keep it consistent with the other modules.

        Show
        Thomas Weise added a comment - The change from Carl will sidestep the issue. The change I made will keep it consistent with the other modules.
        Hide
        Thomas Weise added a comment -

        Please note that in any case, maven-build will require that package has run before. That's due to the way the builtins module is setup currently.

        Show
        Thomas Weise added a comment - Please note that in any case, maven-build will require that package has run before. That's due to the way the builtins module is setup currently.
        Hide
        Carl Steinbach added a comment -

        Thomas's approach is better than mine.

        @Thomas: Can you update your patch so that the maven-build target depends on package instead of jar?

        Show
        Carl Steinbach added a comment - Thomas's approach is better than mine. @Thomas: Can you update your patch so that the maven-build target depends on package instead of jar?
        Hide
        Andrew Bayer added a comment -

        Switched the maven-build dependency to package.

        Show
        Andrew Bayer added a comment - Switched the maven-build dependency to package.
        Hide
        Carl Steinbach added a comment -

        +1

        Committed to trunk. Thanks Thomas and Andrew!

        Show
        Carl Steinbach added a comment - +1 Committed to trunk. Thanks Thomas and Andrew!
        Hide
        Thomas Weise added a comment -

        Seems to work fine (Andrew already updated the patch). It would mean though that package runs multiple times depending how you run the build. For reference, test also does not depend on package, you need to run

        ant package test

        Show
        Thomas Weise added a comment - Seems to work fine (Andrew already updated the patch). It would mean though that package runs multiple times depending how you run the build. For reference, test also does not depend on package, you need to run ant package test
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1394 (See https://builds.apache.org/job/Hive-trunk-h0.21/1394/)
        HIVE-2976. Fix maven-build Ant target (Thomas Weise and Andrew Bayer via cws) (Revision 1329997)

        Result = FAILURE
        cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1329997
        Files :

        • /hive/trunk/build.xml
        • /hive/trunk/builtins/build.xml
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1394 (See https://builds.apache.org/job/Hive-trunk-h0.21/1394/ ) HIVE-2976 . Fix maven-build Ant target (Thomas Weise and Andrew Bayer via cws) (Revision 1329997) Result = FAILURE cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1329997 Files : /hive/trunk/build.xml /hive/trunk/builtins/build.xml
        Hide
        Ashutosh Chauhan added a comment -

        Merged in branch 0.9

        Show
        Ashutosh Chauhan added a comment - Merged in branch 0.9
        Hide
        Hudson added a comment -

        Integrated in Hive-0.9.1-SNAPSHOT-h0.21-keepgoing=false #3 (See https://builds.apache.org/job/Hive-0.9.1-SNAPSHOT-h0.21-keepgoing=false/3/)
        HIVE-2976 Fix maven-build Ant target Merged in from trunk. (Andrew Bayer and Thomas Weise) (Revision 1333095)

        Result = FAILURE
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333095
        Files :

        • /hive/branches/branch-0.9
        • /hive/branches/branch-0.9/build.xml
        • /hive/branches/branch-0.9/builtins/build.xml
        Show
        Hudson added a comment - Integrated in Hive-0.9.1-SNAPSHOT-h0.21-keepgoing=false #3 (See https://builds.apache.org/job/Hive-0.9.1-SNAPSHOT-h0.21-keepgoing=false/3/ ) HIVE-2976 Fix maven-build Ant target Merged in from trunk. (Andrew Bayer and Thomas Weise) (Revision 1333095) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333095 Files : /hive/branches/branch-0.9 /hive/branches/branch-0.9/build.xml /hive/branches/branch-0.9/builtins/build.xml
        Hide
        Hudson added a comment -

        Integrated in Hive-0.9.1-SNAPSHOT-h0.21 #3 (See https://builds.apache.org/job/Hive-0.9.1-SNAPSHOT-h0.21/3/)
        HIVE-2976 Fix maven-build Ant target Merged in from trunk. (Andrew Bayer and Thomas Weise) (Revision 1333095)

        Result = ABORTED
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333095
        Files :

        • /hive/branches/branch-0.9
        • /hive/branches/branch-0.9/build.xml
        • /hive/branches/branch-0.9/builtins/build.xml
        Show
        Hudson added a comment - Integrated in Hive-0.9.1-SNAPSHOT-h0.21 #3 (See https://builds.apache.org/job/Hive-0.9.1-SNAPSHOT-h0.21/3/ ) HIVE-2976 Fix maven-build Ant target Merged in from trunk. (Andrew Bayer and Thomas Weise) (Revision 1333095) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333095 Files : /hive/branches/branch-0.9 /hive/branches/branch-0.9/build.xml /hive/branches/branch-0.9/builtins/build.xml
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-2976. Fix maven-build Ant target (Thomas Weise and Andrew Bayer via cws) (Revision 1329997)

        Result = ABORTED
        cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1329997
        Files :

        • /hive/trunk/build.xml
        • /hive/trunk/builtins/build.xml
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2976 . Fix maven-build Ant target (Thomas Weise and Andrew Bayer via cws) (Revision 1329997) Result = ABORTED cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1329997 Files : /hive/trunk/build.xml /hive/trunk/builtins/build.xml
        Hide
        Ashutosh Chauhan added a comment -

        This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

        Show
        Ashutosh Chauhan added a comment - This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

          People

          • Assignee:
            Thomas Weise
            Reporter:
            Carl Steinbach
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development