Hive
  1. Hive
  2. HIVE-2959

TestRemoteHiveMetaStoreIpAddress always uses the same port

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed.

      There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead.

        Activity

        Hide
        Ashutosh Chauhan added a comment -

        This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

        Show
        Ashutosh Chauhan added a comment - This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port
        (Kevin Wilfong via Ashutosh Chauhan)

        Summary:
        https://issues.apache.org/jira/browse/HIVE-2959

        TestRemoteHiveMetaStoreIpAddress now uses the standard way of finding a free
        port using Java's ServerSocket class.

        TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if
        another process happens to be using that port, the tests cannot succeed.

        There seems to be a standard way of finding a free port using Java's
        ServerSocket class, this should be used instead.

        Test Plan: Ran TestRemoteHiveMetaStoreIpAddress and
        TestRemoteUGIHiveMetaStoreIpAddress, the two tests which would be affected by
        this change. I verified they passed and did not use port 39083.

        Reviewers: JIRA, njain, ashutoshc

        Reviewed By: ashutoshc

        Differential Revision: https://reviews.facebook.net/D2841 (Revision 1327591)

        Result = ABORTED
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327591
        Files :

        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port (Kevin Wilfong via Ashutosh Chauhan) Summary: https://issues.apache.org/jira/browse/HIVE-2959 TestRemoteHiveMetaStoreIpAddress now uses the standard way of finding a free port using Java's ServerSocket class. TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed. There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead. Test Plan: Ran TestRemoteHiveMetaStoreIpAddress and TestRemoteUGIHiveMetaStoreIpAddress, the two tests which would be affected by this change. I verified they passed and did not use port 39083. Reviewers: JIRA, njain, ashutoshc Reviewed By: ashutoshc Differential Revision: https://reviews.facebook.net/D2841 (Revision 1327591) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327591 Files : /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1382 (See https://builds.apache.org/job/Hive-trunk-h0.21/1382/)
        HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port
        (Kevin Wilfong via Ashutosh Chauhan)

        Summary:
        https://issues.apache.org/jira/browse/HIVE-2959

        TestRemoteHiveMetaStoreIpAddress now uses the standard way of finding a free
        port using Java's ServerSocket class.

        TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if
        another process happens to be using that port, the tests cannot succeed.

        There seems to be a standard way of finding a free port using Java's
        ServerSocket class, this should be used instead.

        Test Plan: Ran TestRemoteHiveMetaStoreIpAddress and
        TestRemoteUGIHiveMetaStoreIpAddress, the two tests which would be affected by
        this change. I verified they passed and did not use port 39083.

        Reviewers: JIRA, njain, ashutoshc

        Reviewed By: ashutoshc

        Differential Revision: https://reviews.facebook.net/D2841 (Revision 1327591)

        Result = SUCCESS
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327591
        Files :

        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1382 (See https://builds.apache.org/job/Hive-trunk-h0.21/1382/ ) HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port (Kevin Wilfong via Ashutosh Chauhan) Summary: https://issues.apache.org/jira/browse/HIVE-2959 TestRemoteHiveMetaStoreIpAddress now uses the standard way of finding a free port using Java's ServerSocket class. TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed. There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead. Test Plan: Ran TestRemoteHiveMetaStoreIpAddress and TestRemoteUGIHiveMetaStoreIpAddress, the two tests which would be affected by this change. I verified they passed and did not use port 39083. Reviewers: JIRA, njain, ashutoshc Reviewed By: ashutoshc Differential Revision: https://reviews.facebook.net/D2841 (Revision 1327591) Result = SUCCESS hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327591 Files : /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java
        Hide
        Phabricator added a comment -

        kevinwilfong has committed the revision "HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port".

        Change committed by hashutosh.

        REVISION DETAIL
        https://reviews.facebook.net/D2841

        COMMIT
        https://reviews.facebook.net/rHIVE1327591

        Show
        Phabricator added a comment - kevinwilfong has committed the revision " HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port". Change committed by hashutosh. REVISION DETAIL https://reviews.facebook.net/D2841 COMMIT https://reviews.facebook.net/rHIVE1327591
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Kevin!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Kevin!
        Hide
        Phabricator added a comment -

        ashutoshc has accepted the revision "HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port".

        +1 will commit if tests pass.

        REVISION DETAIL
        https://reviews.facebook.net/D2841

        BRANCH
        svn

        Show
        Phabricator added a comment - ashutoshc has accepted the revision " HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port". +1 will commit if tests pass. REVISION DETAIL https://reviews.facebook.net/D2841 BRANCH svn
        Hide
        Phabricator added a comment -

        kevinwilfong requested code review of "HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port".
        Reviewers: JIRA

        https://issues.apache.org/jira/browse/HIVE-2959

        TestRemoteHiveMetaStoreIpAddress now uses the standard way of finding a free port using Java's ServerSocket class.

        TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed.

        There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D2841

        AFFECTED FILES
        metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/6435/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - kevinwilfong requested code review of " HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port". Reviewers: JIRA https://issues.apache.org/jira/browse/HIVE-2959 TestRemoteHiveMetaStoreIpAddress now uses the standard way of finding a free port using Java's ServerSocket class. TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed. There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D2841 AFFECTED FILES metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/6435/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.

          People

          • Assignee:
            Kevin Wilfong
            Reporter:
            Kevin Wilfong
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development