Hive
  1. Hive
  2. HIVE-2946

Hive metastore does not have any log messages while shutting itself down.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Metastore
    • Labels:

      Description

      When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class.

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-2946 [jira] Hive metastore does not have any log messages while shutting
        itself down.
        (Vandana Kasavajjala via Ashutosh Chauhan)

        Summary:
        https://issues.apache.org/jira/browse/HIVE-2946

        Addressed Ashutosh's comments.

        When hive metastore is started, the event is logged with good amount of
        information. But when it is stopped ( using a kill) command, no information is
        being written to the logs. It will be good if we can add a shutdown event to the
        HiveMetastore class.

        Test Plan: EMPTY

        Reviewers: JIRA, ashutoshc

        Reviewed By: ashutoshc

        Differential Revision: https://reviews.facebook.net/D2787 (Revision 1327323)

        Result = ABORTED
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327323
        Files :

        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down. (Vandana Kasavajjala via Ashutosh Chauhan) Summary: https://issues.apache.org/jira/browse/HIVE-2946 Addressed Ashutosh's comments. When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class. Test Plan: EMPTY Reviewers: JIRA, ashutoshc Reviewed By: ashutoshc Differential Revision: https://reviews.facebook.net/D2787 (Revision 1327323) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327323 Files : /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        Hide
        Ashutosh Chauhan added a comment -

        This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

        Show
        Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1380 (See https://builds.apache.org/job/Hive-trunk-h0.21/1380/)
        HIVE-2946 [jira] Hive metastore does not have any log messages while shutting
        itself down.
        (Vandana Kasavajjala via Ashutosh Chauhan)

        Summary:
        https://issues.apache.org/jira/browse/HIVE-2946

        Addressed Ashutosh's comments.

        When hive metastore is started, the event is logged with good amount of
        information. But when it is stopped ( using a kill) command, no information is
        being written to the logs. It will be good if we can add a shutdown event to the
        HiveMetastore class.

        Test Plan: EMPTY

        Reviewers: JIRA, ashutoshc

        Reviewed By: ashutoshc

        Differential Revision: https://reviews.facebook.net/D2787 (Revision 1327323)

        Result = SUCCESS
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327323
        Files :

        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1380 (See https://builds.apache.org/job/Hive-trunk-h0.21/1380/ ) HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down. (Vandana Kasavajjala via Ashutosh Chauhan) Summary: https://issues.apache.org/jira/browse/HIVE-2946 Addressed Ashutosh's comments. When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class. Test Plan: EMPTY Reviewers: JIRA, ashutoshc Reviewed By: ashutoshc Differential Revision: https://reviews.facebook.net/D2787 (Revision 1327323) Result = SUCCESS hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327323 Files : /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        Hide
        Phabricator added a comment -

        avandana has committed the revision "HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down.".

        Change committed by hashutosh.

        REVISION DETAIL
        https://reviews.facebook.net/D2787

        COMMIT
        https://reviews.facebook.net/rHIVE1327323

        Show
        Phabricator added a comment - avandana has committed the revision " HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down.". Change committed by hashutosh. REVISION DETAIL https://reviews.facebook.net/D2787 COMMIT https://reviews.facebook.net/rHIVE1327323
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk and 0.9 Thanks, Vandana!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk and 0.9 Thanks, Vandana!
        Hide
        Phabricator added a comment -

        ashutoshc has accepted the revision "HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down.".

        +1 will commit soon.

        REVISION DETAIL
        https://reviews.facebook.net/D2787

        BRANCH
        svn

        Show
        Phabricator added a comment - ashutoshc has accepted the revision " HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down.". +1 will commit soon. REVISION DETAIL https://reviews.facebook.net/D2787 BRANCH svn
        Hide
        Phabricator added a comment -

        avandana requested code review of "HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down.".
        Reviewers: JIRA

        https://issues.apache.org/jira/browse/HIVE-2946

        Addressed Ashutosh's comments.

        When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D2787

        AFFECTED FILES
        metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/6315/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - avandana requested code review of " HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down.". Reviewers: JIRA https://issues.apache.org/jira/browse/HIVE-2946 Addressed Ashutosh's comments. When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D2787 AFFECTED FILES metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/6315/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        ashutoshc has commented on the revision "HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down.".

        INLINE COMMENTS
        metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:2956 Just like for start message you can also add
        if (cli.isVerbose())

        { System.err.println(msg); }

        REVISION DETAIL
        https://reviews.facebook.net/D2745

        Show
        Phabricator added a comment - ashutoshc has commented on the revision " HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down.". INLINE COMMENTS metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:2956 Just like for start message you can also add if (cli.isVerbose()) { System.err.println(msg); } REVISION DETAIL https://reviews.facebook.net/D2745
        Hide
        Phabricator added a comment -

        avandana requested code review of "HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down.".
        Reviewers: JIRA

        https://issues.apache.org/jira/browse/HIVE-2946

        Added shutdown hook to log message while shutting down metastore.

        When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D2745

        AFFECTED FILES
        metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/6273/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - avandana requested code review of " HIVE-2946 [jira] Hive metastore does not have any log messages while shutting itself down.". Reviewers: JIRA https://issues.apache.org/jira/browse/HIVE-2946 Added shutdown hook to log message while shutting down metastore. When hive metastore is started, the event is logged with good amount of information. But when it is stopped ( using a kill) command, no information is being written to the logs. It will be good if we can add a shutdown event to the HiveMetastore class. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D2745 AFFECTED FILES metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/6273/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.

          People

          • Assignee:
            Vandana Ayyalasomayajula
            Reporter:
            Vandana Ayyalasomayajula
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development