kevinwilfong requested code review of "
HIVE-2931 [jira] conf settings may be ignored".
Unfortunately, Namit's patch did not pass the tests and he is away. I offer this patch as a different solution. The issue is that before
HIVE-2716, Hive would alway have its needsRefresh set to true. Now, however, this is no longer the case. This exposed the issue that the Hive class uses config variables which are not metavariables. This seems perfectly reasonable, except that its HiveConf instance is only updated if a metavariable changes. It should be updated regardless. A metavariable changing should only determine if it needs to connect to a new metastore instance.
This is a pretty serious problem.
If a conf variable is changed, Hive may not pick up the variable unless the metastore variables are changed.
When any session variables are changed, it might be simpler to update the corresponding Hive conf.
MANAGE HERALD DIFFERENTIAL RULES
WHY DID I GET THIS EMAIL?
Tip: use the X-Herald-Rules header to filter Herald messages in your client.