Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.10.0
    • Component/s: CLI
    • Labels:
      None

      Description

      Currently, the .hiverc files are loaded from:

      $HIVE_HOME/bin/.hiverc
      ~/.hiverc
      

      It seems more ops-friendly to have it in the config directory.

      $HIVE_HOME/bin/.hiverc  <- for backwards compatibility
      $HIVE_CONF_DIR/.hiverc
      ~/.hiverc
      

        Activity

        Hide
        Phabricator added a comment -

        omalley requested code review of "HIVE-2911 [jira] Move global .hiverc file".
        Reviewers: JIRA

        HIVE-2911

        Move the location of the global hiverc file to $HIVE_CONF_DIR/.hiverc.

        Currently, the .hiverc files are loaded from:

        $HIVE_HOME/bin/.hiverc
        ~/.hiverc

        It seems more ops-friendly to have it in the config directory.

        $HIVE_HOME/bin/.hiverc <- for backwards compatibility
        $HIVE_CONF_DIR/.hiverc
        ~/.hiverc

        TEST PLAN
        Can't test cli driver.

        REVISION DETAIL
        https://reviews.facebook.net/D2529

        AFFECTED FILES
        cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/5733/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - omalley requested code review of " HIVE-2911 [jira] Move global .hiverc file". Reviewers: JIRA HIVE-2911 Move the location of the global hiverc file to $HIVE_CONF_DIR/.hiverc. Currently, the .hiverc files are loaded from: $HIVE_HOME/bin/.hiverc ~/.hiverc It seems more ops-friendly to have it in the config directory. $HIVE_HOME/bin/.hiverc <- for backwards compatibility $HIVE_CONF_DIR/.hiverc ~/.hiverc TEST PLAN Can't test cli driver. REVISION DETAIL https://reviews.facebook.net/D2529 AFFECTED FILES cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/5733/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        omalley updated the revision "HIVE-2911 [jira] Move global .hiverc file".
        Reviewers: JIRA

        Changed the printInfo to printError so that the user actually sees the warning.

        REVISION DETAIL
        https://reviews.facebook.net/D2529

        AFFECTED FILES
        cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java

        Show
        Phabricator added a comment - omalley updated the revision " HIVE-2911 [jira] Move global .hiverc file". Reviewers: JIRA Changed the printInfo to printError so that the user actually sees the warning. REVISION DETAIL https://reviews.facebook.net/D2529 AFFECTED FILES cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
        Hide
        Owen O'Malley added a comment -

        I tested this on a cluster and it worked as expected.

        Show
        Owen O'Malley added a comment - I tested this on a cluster and it worked as expected.
        Hide
        Namit Jain added a comment -

        This is a backward incompatible change.

        Show
        Namit Jain added a comment - This is a backward incompatible change.
        Hide
        Owen O'Malley added a comment -

        Namit,
        How is it backward incompatible? It still reads the file from $HIVE_HOME/bin/.hiverc, if it is there.

        Show
        Owen O'Malley added a comment - Namit, How is it backward incompatible? It still reads the file from $HIVE_HOME/bin/.hiverc, if it is there.
        Hide
        Edward Capriolo added a comment -

        +1. I think we are fine here. We are just adding and extra place to possibly load the .hiverc file from and suggesting a new position which makes more sense. (I do not remember my rational for loading the .hiverc file from /bin) I will take a look tomorrow.

        Show
        Edward Capriolo added a comment - +1. I think we are fine here. We are just adding and extra place to possibly load the .hiverc file from and suggesting a new position which makes more sense. (I do not remember my rational for loading the .hiverc file from /bin) I will take a look tomorrow.
        Hide
        Namit Jain added a comment -

        +1

        Owen, my bad. I dont know why I thought it was incompatible.
        Edward, I am assuming you will take care of committing this.

        Show
        Namit Jain added a comment - +1 Owen, my bad. I dont know why I thought it was incompatible. Edward, I am assuming you will take care of committing this.
        Hide
        Edward Capriolo added a comment -

        Committed. Nice work Owen.

        Show
        Edward Capriolo added a comment - Committed. Nice work Owen.
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1484 (See https://builds.apache.org/job/Hive-trunk-h0.21/1484/)
        HIVE-2911 Move Global .hiverc file (Owen O'Malley via egc) (Revision 1349611)

        Result = FAILURE
        ecapriolo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349611
        Files :

        • /hive/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1484 (See https://builds.apache.org/job/Hive-trunk-h0.21/1484/ ) HIVE-2911 Move Global .hiverc file (Owen O'Malley via egc) (Revision 1349611) Result = FAILURE ecapriolo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349611 Files : /hive/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-2911 Move Global .hiverc file (Owen O'Malley via egc) (Revision 1349611)

        Result = ABORTED
        ecapriolo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349611
        Files :

        • /hive/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2911 Move Global .hiverc file (Owen O'Malley via egc) (Revision 1349611) Result = ABORTED ecapriolo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349611 Files : /hive/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
        Hide
        Ashutosh Chauhan added a comment -

        This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

        Show
        Ashutosh Chauhan added a comment - This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

          People

          • Assignee:
            Owen O'Malley
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development