Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: Web UI
    • Labels:

      Description

      I've made some improvements to the HWI interface with the Twitter bootstrap system. I'm looking for feedback on the new design.

      1. glyphicons-halflings-white.png
        4 kB
        Hugo Trippaers
      2. glyphicons-halflings.png
        4 kB
        Hugo Trippaers
      3. hive-2910.4.patch.txt
        144 kB
        Hugo Trippaers
      4. hive-2910.3.patch.txt
        144 kB
        Hugo Trippaers
      5. hive-2910.3.patch.log
        2 kB
        Hugo Trippaers
      6. hive-hwi-2.patch
        144 kB
        Hugo Trippaers
      7. screenie002.PNG
        25 kB
        Hugo Trippaers
      8. screenie001.PNG
        30 kB
        Hugo Trippaers
      9. hive-hwi.patch
        140 kB
        Hugo Trippaers

        Activity

        Hide
        Hugo Trippaers added a comment -

        Patch (generated by Eclipse)

        Show
        Hugo Trippaers added a comment - Patch (generated by Eclipse)
        Hide
        Hugo Trippaers added a comment -

        Sample screenshots

        Show
        Hugo Trippaers added a comment - Sample screenshots
        Hide
        Hugo Trippaers added a comment -

        Some more updates, this replaces the first patch

        Show
        Hugo Trippaers added a comment - Some more updates, this replaces the first patch
        Hide
        Edward Capriolo added a comment -

        Looks nice. I will review the code. This has needed a face lift for a long time

        Show
        Edward Capriolo added a comment - Looks nice. I will review the code. This has needed a face lift for a long time
        Hide
        Edward Capriolo added a comment -

        +1. Very nice. As a follow up we might want to trim the QUERY box as it seems to have funky white space issues, but those were probably around before this patch.

        Show
        Edward Capriolo added a comment - +1. Very nice. As a follow up we might want to trim the QUERY box as it seems to have funky white space issues, but those were probably around before this patch.
        Hide
        Edward Capriolo added a comment -

        @Huge

        Can you please regenerate the patch, so it can apply cleanly with patch -p0 < ../path-to-patch

        --------------------------
        |Index: hwi/web/session_list.jsp
        |===================================================================
        |--- hwi/web/session_list.jsp	(revision 1305928)
        |+++ hwi/web/session_list.jsp	(working copy)
        --------------------------
        Patching file hwi/web/session_list.jsp using Plan A...
        Hunk #1 succeeded at 14.
        Hmm...  The next patch looks like a unified diff to me...
        The text leading up to this was:
        

        The best way to do this is:
        cd hive-trunk
        svn diff > /tmp/hive-2910.3.patch.txt

        Then please mark this issue as patch available, and I will commit.

        Show
        Edward Capriolo added a comment - @Huge Can you please regenerate the patch, so it can apply cleanly with patch -p0 < ../path-to-patch -------------------------- |Index: hwi/web/session_list.jsp |=================================================================== |--- hwi/web/session_list.jsp (revision 1305928) |+++ hwi/web/session_list.jsp (working copy) -------------------------- Patching file hwi/web/session_list.jsp using Plan A... Hunk #1 succeeded at 14. Hmm... The next patch looks like a unified diff to me... The text leading up to this was: The best way to do this is: cd hive-trunk svn diff > /tmp/hive-2910.3.patch.txt Then please mark this issue as patch available, and I will commit.
        Hide
        Hugo Trippaers added a comment -

        This patch applies cleanly to revision 1308170. See patch.log

        Show
        Hugo Trippaers added a comment - This patch applies cleanly to revision 1308170. See patch.log
        Hide
        Ashutosh Chauhan added a comment -

        Ran the test with patch. All passed. I don't much about this part of code, but since Ed (who is the expert in this area) has already +1ed, will commit it.

        Show
        Ashutosh Chauhan added a comment - Ran the test with patch. All passed. I don't much about this part of code, but since Ed (who is the expert in this area) has already +1ed, will commit it.
        Hide
        Ashutosh Chauhan added a comment -

        Seems like there are few binary resources (icon png images) which needs to be checked-in but aren't uploaded yet. Hugo, can you upload them here with license granted to ASF.

        Show
        Ashutosh Chauhan added a comment - Seems like there are few binary resources (icon png images) which needs to be checked-in but aren't uploaded yet. Hugo, can you upload them here with license granted to ASF.
        Hide
        venkat added a comment -

        Hi All,

        I am using hive-0.7.1-cdh3u3 . is it ok if i apply this patch ?
        And also how to apply this patch ? please help.

        I want to get rid of the below error :-

        An error occurred at line: 40 in the jsp file: /admin_list_jobs.jsp
        Generated servlet error:
        The field ExecDriver.runningJobKillURIs is not visible

        An error occurred at line: 43 in the jsp file: /admin_list_jobs.jsp
        Generated servlet error:
        The field ExecDriver.runningJobKillURIs is not visible
        ..

        Regards,
        Naga.

        Show
        venkat added a comment - Hi All, I am using hive-0.7.1-cdh3u3 . is it ok if i apply this patch ? And also how to apply this patch ? please help. I want to get rid of the below error :- An error occurred at line: 40 in the jsp file: /admin_list_jobs.jsp Generated servlet error: The field ExecDriver.runningJobKillURIs is not visible An error occurred at line: 43 in the jsp file: /admin_list_jobs.jsp Generated servlet error: The field ExecDriver.runningJobKillURIs is not visible .. Regards, Naga.
        Hide
        Edward Capriolo added a comment -

        CDH much be running an older version. That page has been removed from HWI entirely because that information is no longer available.

        Show
        Edward Capriolo added a comment - CDH much be running an older version. That page has been removed from HWI entirely because that information is no longer available.
        Hide
        Hugo Trippaers added a comment -

        Ashutosh Chauhan, i don't know much about the license stuff. The images distributed as part of twitter bootstrap (http://twitter.github.com/bootstrap/) which i used to build the css. The images itself are from the site http://glyphicons.com/ and are release under the Creative Commons V3 (http://creativecommons.org/licenses/by/3.0/deed.en)

        Is this ok for inclusion?

        Show
        Hugo Trippaers added a comment - Ashutosh Chauhan, i don't know much about the license stuff. The images distributed as part of twitter bootstrap ( http://twitter.github.com/bootstrap/ ) which i used to build the css. The images itself are from the site http://glyphicons.com/ and are release under the Creative Commons V3 ( http://creativecommons.org/licenses/by/3.0/deed.en ) Is this ok for inclusion?
        Hide
        Owen O'Malley added a comment -

        Did you modify hwi/web/css/bootstrap.min.css when you copied it from bootstrap? You'll need to replace the header with the Apache header and mention the bootstrap and glypicons parts in the NOTICE file.

        Show
        Owen O'Malley added a comment - Did you modify hwi/web/css/bootstrap.min.css when you copied it from bootstrap? You'll need to replace the header with the Apache header and mention the bootstrap and glypicons parts in the NOTICE file.
        Hide
        Hugo Trippaers added a comment -

        This patch included the required changes to the NOTICE file for inclusion of both Bootstrap and Glyphicons. The images are included separately and should be placed in hwi/src/web/img

        Show
        Hugo Trippaers added a comment - This patch included the required changes to the NOTICE file for inclusion of both Bootstrap and Glyphicons. The images are included separately and should be placed in hwi/src/web/img
        Hide
        Hugo Trippaers added a comment -

        Owen, the bootstrap.min.css is not modified by me. It's generated by the webform at the bootstrap site on github. I've updated the notice file and added a new patch with these changes.

        Show
        Hugo Trippaers added a comment - Owen, the bootstrap.min.css is not modified by me. It's generated by the webform at the bootstrap site on github. I've updated the notice file and added a new patch with these changes.
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Hugo!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Hugo!
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1370 (See https://builds.apache.org/job/Hive-trunk-h0.21/1370/)
        HIVE-2910 : Improve the HWI interface (Hugo Trippaers via Ashutosh Chauhan) (Revision 1325492)

        Result = SUCCESS
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325492
        Files :

        • /hive/trunk/NOTICE
        • /hive/trunk/hwi/web/authorize.jsp
        • /hive/trunk/hwi/web/css
        • /hive/trunk/hwi/web/css/bootstrap.min.css
        • /hive/trunk/hwi/web/diagnostics.jsp
        • /hive/trunk/hwi/web/error_page.jsp
        • /hive/trunk/hwi/web/img
        • /hive/trunk/hwi/web/img/glyphicons-halflings-white.png
        • /hive/trunk/hwi/web/img/glyphicons-halflings.png
        • /hive/trunk/hwi/web/index.jsp
        • /hive/trunk/hwi/web/left_navigation.jsp
        • /hive/trunk/hwi/web/navbar.jsp
        • /hive/trunk/hwi/web/session_create.jsp
        • /hive/trunk/hwi/web/session_diagnostics.jsp
        • /hive/trunk/hwi/web/session_history.jsp
        • /hive/trunk/hwi/web/session_kill.jsp
        • /hive/trunk/hwi/web/session_list.jsp
        • /hive/trunk/hwi/web/session_manage.jsp
        • /hive/trunk/hwi/web/session_remove.jsp
        • /hive/trunk/hwi/web/session_result.jsp
        • /hive/trunk/hwi/web/show_database.jsp
        • /hive/trunk/hwi/web/show_databases.jsp
        • /hive/trunk/hwi/web/show_table.jsp
        • /hive/trunk/hwi/web/view_file.jsp
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1370 (See https://builds.apache.org/job/Hive-trunk-h0.21/1370/ ) HIVE-2910 : Improve the HWI interface (Hugo Trippaers via Ashutosh Chauhan) (Revision 1325492) Result = SUCCESS hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325492 Files : /hive/trunk/NOTICE /hive/trunk/hwi/web/authorize.jsp /hive/trunk/hwi/web/css /hive/trunk/hwi/web/css/bootstrap.min.css /hive/trunk/hwi/web/diagnostics.jsp /hive/trunk/hwi/web/error_page.jsp /hive/trunk/hwi/web/img /hive/trunk/hwi/web/img/glyphicons-halflings-white.png /hive/trunk/hwi/web/img/glyphicons-halflings.png /hive/trunk/hwi/web/index.jsp /hive/trunk/hwi/web/left_navigation.jsp /hive/trunk/hwi/web/navbar.jsp /hive/trunk/hwi/web/session_create.jsp /hive/trunk/hwi/web/session_diagnostics.jsp /hive/trunk/hwi/web/session_history.jsp /hive/trunk/hwi/web/session_kill.jsp /hive/trunk/hwi/web/session_list.jsp /hive/trunk/hwi/web/session_manage.jsp /hive/trunk/hwi/web/session_remove.jsp /hive/trunk/hwi/web/session_result.jsp /hive/trunk/hwi/web/show_database.jsp /hive/trunk/hwi/web/show_databases.jsp /hive/trunk/hwi/web/show_table.jsp /hive/trunk/hwi/web/view_file.jsp
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-2910 : Improve the HWI interface (Hugo Trippaers via Ashutosh Chauhan) (Revision 1325492)

        Result = ABORTED
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325492
        Files :

        • /hive/trunk/NOTICE
        • /hive/trunk/hwi/web/authorize.jsp
        • /hive/trunk/hwi/web/css
        • /hive/trunk/hwi/web/css/bootstrap.min.css
        • /hive/trunk/hwi/web/diagnostics.jsp
        • /hive/trunk/hwi/web/error_page.jsp
        • /hive/trunk/hwi/web/img
        • /hive/trunk/hwi/web/img/glyphicons-halflings-white.png
        • /hive/trunk/hwi/web/img/glyphicons-halflings.png
        • /hive/trunk/hwi/web/index.jsp
        • /hive/trunk/hwi/web/left_navigation.jsp
        • /hive/trunk/hwi/web/navbar.jsp
        • /hive/trunk/hwi/web/session_create.jsp
        • /hive/trunk/hwi/web/session_diagnostics.jsp
        • /hive/trunk/hwi/web/session_history.jsp
        • /hive/trunk/hwi/web/session_kill.jsp
        • /hive/trunk/hwi/web/session_list.jsp
        • /hive/trunk/hwi/web/session_manage.jsp
        • /hive/trunk/hwi/web/session_remove.jsp
        • /hive/trunk/hwi/web/session_result.jsp
        • /hive/trunk/hwi/web/show_database.jsp
        • /hive/trunk/hwi/web/show_databases.jsp
        • /hive/trunk/hwi/web/show_table.jsp
        • /hive/trunk/hwi/web/view_file.jsp
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2910 : Improve the HWI interface (Hugo Trippaers via Ashutosh Chauhan) (Revision 1325492) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325492 Files : /hive/trunk/NOTICE /hive/trunk/hwi/web/authorize.jsp /hive/trunk/hwi/web/css /hive/trunk/hwi/web/css/bootstrap.min.css /hive/trunk/hwi/web/diagnostics.jsp /hive/trunk/hwi/web/error_page.jsp /hive/trunk/hwi/web/img /hive/trunk/hwi/web/img/glyphicons-halflings-white.png /hive/trunk/hwi/web/img/glyphicons-halflings.png /hive/trunk/hwi/web/index.jsp /hive/trunk/hwi/web/left_navigation.jsp /hive/trunk/hwi/web/navbar.jsp /hive/trunk/hwi/web/session_create.jsp /hive/trunk/hwi/web/session_diagnostics.jsp /hive/trunk/hwi/web/session_history.jsp /hive/trunk/hwi/web/session_kill.jsp /hive/trunk/hwi/web/session_list.jsp /hive/trunk/hwi/web/session_manage.jsp /hive/trunk/hwi/web/session_remove.jsp /hive/trunk/hwi/web/session_result.jsp /hive/trunk/hwi/web/show_database.jsp /hive/trunk/hwi/web/show_databases.jsp /hive/trunk/hwi/web/show_table.jsp /hive/trunk/hwi/web/view_file.jsp
        Hide
        Ashutosh Chauhan added a comment -

        This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

        Show
        Ashutosh Chauhan added a comment - This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

          People

          • Assignee:
            Hugo Trippaers
            Reporter:
            Hugo Trippaers
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development