Hive
  1. Hive
  2. HIVE-2881

Remove redundant key comparing in SMBMapJoinOperator

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Query Processor
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently, SMBJoin compares keys twice in #findSmallestKey and #joinObject.

        Activity

        Hide
        Phabricator added a comment -

        navis requested code review of "HIVE-2881 [jira] Remove redundant key comparing in SMBMapJoinOperator".
        Reviewers: JIRA

        DPAL-988 Remove redundant key comparing in SMBMapJoinOperator

        Currently, SMBJoin compares keys twice in #findSmallestKey and #joinObject.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D2379

        AFFECTED FILES
        ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/5331/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - navis requested code review of " HIVE-2881 [jira] Remove redundant key comparing in SMBMapJoinOperator". Reviewers: JIRA DPAL-988 Remove redundant key comparing in SMBMapJoinOperator Currently, SMBJoin compares keys twice in #findSmallestKey and #joinObject. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D2379 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/5331/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Navis added a comment -

        Passed all tests.

        Show
        Navis added a comment - Passed all tests.
        Hide
        Namit Jain added a comment -

        Committed. Thanks Navis

        Show
        Namit Jain added a comment - Committed. Thanks Navis
        Hide
        Phabricator added a comment -

        njain has accepted the revision "HIVE-2881 [jira] Remove redundant key comparing in SMBMapJoinOperator".

        Looks good -

        I know this did not have good comments to start with, but it would be great if you can
        add more comments for changes like this. It took me a very long time to go over the
        code and make sure we are not missing any boundary condition. An example would
        have really helped.

        REVISION DETAIL
        https://reviews.facebook.net/D2379

        BRANCH
        DPAL-988

        Show
        Phabricator added a comment - njain has accepted the revision " HIVE-2881 [jira] Remove redundant key comparing in SMBMapJoinOperator". Looks good - I know this did not have good comments to start with, but it would be great if you can add more comments for changes like this. It took me a very long time to go over the code and make sure we are not missing any boundary condition. An example would have really helped. REVISION DETAIL https://reviews.facebook.net/D2379 BRANCH DPAL-988
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1346 (See https://builds.apache.org/job/Hive-trunk-h0.21/1346/)
        HIVE-2881 Remove redundant key comparing in SMBMapJoinOperator
        (Navis via namit) (Revision 1308241)

        Result = ABORTED
        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1308241
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1346 (See https://builds.apache.org/job/Hive-trunk-h0.21/1346/ ) HIVE-2881 Remove redundant key comparing in SMBMapJoinOperator (Navis via namit) (Revision 1308241) Result = ABORTED namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1308241 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
        Hide
        Ashutosh Chauhan added a comment -

        This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

        Show
        Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-2881 Remove redundant key comparing in SMBMapJoinOperator
        (Navis via namit) (Revision 1308241)

        Result = ABORTED
        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1308241
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2881 Remove redundant key comparing in SMBMapJoinOperator (Navis via namit) (Revision 1308241) Result = ABORTED namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1308241 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java

          People

          • Assignee:
            Navis
            Reporter:
            Navis
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development