Hive
  1. Hive
  2. HIVE-2879

Add "rat" target to build to look for missing license headers

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Build Infrastructure
    • Labels:
      None

      Description

      We should have a "rat" target that can generate an Apache RAT report. RAT is used for finding missing license headers.

        Activity

        Hide
        Phabricator added a comment -

        omalley requested code review of "HIVE-2879 [jira] Add "rat" target to build to look for missing license headers".
        Reviewers: JIRA

        <<Enter Revision Title>>

        Add "rat" target to look for missing license headers.

        We should have a "rat" target that can generate an Apache RAT report. RAT is used for finding missing license headers.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D2373

        AFFECTED FILES
        build.xml
        ivy.xml
        ivy/libraries.properties

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/5319/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - omalley requested code review of " HIVE-2879 [jira] Add "rat" target to build to look for missing license headers". Reviewers: JIRA <<Enter Revision Title>> Add "rat" target to look for missing license headers. We should have a "rat" target that can generate an Apache RAT report. RAT is used for finding missing license headers. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D2373 AFFECTED FILES build.xml ivy.xml ivy/libraries.properties MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/5319/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Owen O'Malley added a comment -

        I got the exclude patterns so that there are only 81 files being reported, most of which look like files that should have the header.

        Show
        Owen O'Malley added a comment - I got the exclude patterns so that there are only 81 files being reported, most of which look like files that should have the header.
        Hide
        Owen O'Malley added a comment -

        Unsurprisingly, tests pass.

        Show
        Owen O'Malley added a comment - Unsurprisingly, tests pass.
        Hide
        Phabricator added a comment -

        ashutoshc has requested changes to the revision "HIVE-2879 [jira] Add "rat" target to build to look for missing license headers".

        Bunch of excludes needs to be excluded. Headers in them can be tracked in separate jira.

        INLINE COMMENTS
        build.xml:810 This dir contains sources written by Hive project. This shouldn't be excluded.
        build.xml:812 This is also in svn. Shouldn't be excluded
        build.xml:813 This is also in svn. Shouldn't be excluded
        build.xml:820 These are metastore upgrade scripts. Shouldn't be excluded.
        build.xml:822 Duplication

        REVISION DETAIL
        https://reviews.facebook.net/D2373

        BRANCH
        rat

        Show
        Phabricator added a comment - ashutoshc has requested changes to the revision " HIVE-2879 [jira] Add "rat" target to build to look for missing license headers". Bunch of excludes needs to be excluded. Headers in them can be tracked in separate jira. INLINE COMMENTS build.xml:810 This dir contains sources written by Hive project. This shouldn't be excluded. build.xml:812 This is also in svn. Shouldn't be excluded build.xml:813 This is also in svn. Shouldn't be excluded build.xml:820 These are metastore upgrade scripts. Shouldn't be excluded. build.xml:822 Duplication REVISION DETAIL https://reviews.facebook.net/D2373 BRANCH rat
        Hide
        Phabricator added a comment -

        omalley updated the revision "HIVE-2879 [jira] Add "rat" target to build to look for missing license headers".
        Reviewers: JIRA, ashutoshc

        address Ashutosh's comments and add some additional thrift generated files

        REVISION DETAIL
        https://reviews.facebook.net/D2373

        AFFECTED FILES
        build.xml
        ivy.xml
        ivy/libraries.properties

        Show
        Phabricator added a comment - omalley updated the revision " HIVE-2879 [jira] Add "rat" target to build to look for missing license headers". Reviewers: JIRA, ashutoshc address Ashutosh's comments and add some additional thrift generated files REVISION DETAIL https://reviews.facebook.net/D2373 AFFECTED FILES build.xml ivy.xml ivy/libraries.properties
        Hide
        Phabricator added a comment -

        omalley updated the revision "HIVE-2879 [jira] Add "rat" target to build to look for missing license headers".
        Reviewers: JIRA, ashutoshc

        Missed removing the */.sql line.

        REVISION DETAIL
        https://reviews.facebook.net/D2373

        AFFECTED FILES
        build.xml
        ivy.xml
        ivy/libraries.properties

        Show
        Phabricator added a comment - omalley updated the revision " HIVE-2879 [jira] Add "rat" target to build to look for missing license headers". Reviewers: JIRA, ashutoshc Missed removing the * / .sql line. REVISION DETAIL https://reviews.facebook.net/D2373 AFFECTED FILES build.xml ivy.xml ivy/libraries.properties
        Hide
        Phabricator added a comment -

        ashutoshc has accepted the revision "HIVE-2879 [jira] Add "rat" target to build to look for missing license headers".

        +1 will commit if tests pass

        REVISION DETAIL
        https://reviews.facebook.net/D2373

        BRANCH
        h-2879

        Show
        Phabricator added a comment - ashutoshc has accepted the revision " HIVE-2879 [jira] Add "rat" target to build to look for missing license headers". +1 will commit if tests pass REVISION DETAIL https://reviews.facebook.net/D2373 BRANCH h-2879
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Owen!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Owen!
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1354 (See https://builds.apache.org/job/Hive-trunk-h0.21/1354/)
        HIVE-2879 : Add rat target to build to look for missing license headers (Owen Omalley via Ashutosh Chauhan) (Revision 1309676)

        Result = FAILURE
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309676
        Files :

        • /hive/trunk/build.xml
        • /hive/trunk/ivy.xml
        • /hive/trunk/ivy/libraries.properties
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1354 (See https://builds.apache.org/job/Hive-trunk-h0.21/1354/ ) HIVE-2879 : Add rat target to build to look for missing license headers (Owen Omalley via Ashutosh Chauhan) (Revision 1309676) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309676 Files : /hive/trunk/build.xml /hive/trunk/ivy.xml /hive/trunk/ivy/libraries.properties
        Hide
        Ashutosh Chauhan added a comment -

        This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

        Show
        Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-2879 : Add rat target to build to look for missing license headers (Owen Omalley via Ashutosh Chauhan) (Revision 1309676)

        Result = ABORTED
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309676
        Files :

        • /hive/trunk/build.xml
        • /hive/trunk/ivy.xml
        • /hive/trunk/ivy/libraries.properties
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2879 : Add rat target to build to look for missing license headers (Owen Omalley via Ashutosh Chauhan) (Revision 1309676) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309676 Files : /hive/trunk/build.xml /hive/trunk/ivy.xml /hive/trunk/ivy/libraries.properties

          People

          • Assignee:
            Owen O'Malley
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development