Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      There are also zero-length non-source files that need to be removed.

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-2850 [jira] Remove zero length files
        (Owen O'Malley via Ashutosh Chauhan)

        Summary:
        <<Enter Revision Title>>

        Remove empty files

        There are also zero-length non-source files that need to be removed.

        Test Plan: EMPTY

        Reviewers: JIRA, ashutoshc

        Reviewed By: ashutoshc

        Differential Revision: https://reviews.facebook.net/D2163 (Revision 1301629)

        Result = ABORTED
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301629
        Files :

        • /hive/trunk/data/warehouse/src/.gitignore
        • /hive/trunk/hwi/web/set_processor.jsp
        • /hive/trunk/metastore/src/gen-py/_init_.py
        • /hive/trunk/metastore/src/gen/thrift/gen-py/_init_.py
        • /hive/trunk/ql/src/gen/thrift/gen-py/_init_.py
        • /hive/trunk/ql/src/test/queries/clientpositive/describe_function.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_avg.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_count.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_max.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_min.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_std.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_stddev_samp.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_sum.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_var_samp.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_variance.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udf_divider.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udf_hour_minute_second.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udf_json.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udf_lpad_rpad.q
        • /hive/trunk/ql/src/test/results/clientpositive/describe_function.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_avg.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_count.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_max.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_min.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_std.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_stddev_samp.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_sum.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_var_samp.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_variance.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udf_divider.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udf_hour_minute_second.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udf_json.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udf_lpad_rpad.q.out
        • /hive/trunk/ql/src/test/results/compiler/errors/invalid_function_param1.q.out
        • /hive/trunk/ql/src/test/results/compiler/errors/unknown_function5.q.out
        • /hive/trunk/serde/src/gen-py/_init_.py
        • /hive/trunk/serde/src/gen/thrift/gen-py/_init_.py
        • /hive/trunk/service/src/gen-py/_init_.py
        • /hive/trunk/service/src/gen/thrift/gen-py/_init_.py
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2850 [jira] Remove zero length files (Owen O'Malley via Ashutosh Chauhan) Summary: <<Enter Revision Title>> Remove empty files There are also zero-length non-source files that need to be removed. Test Plan: EMPTY Reviewers: JIRA, ashutoshc Reviewed By: ashutoshc Differential Revision: https://reviews.facebook.net/D2163 (Revision 1301629) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301629 Files : /hive/trunk/data/warehouse/src/.gitignore /hive/trunk/hwi/web/set_processor.jsp /hive/trunk/metastore/src/gen-py/_ init _.py /hive/trunk/metastore/src/gen/thrift/gen-py/_ init _.py /hive/trunk/ql/src/gen/thrift/gen-py/_ init _.py /hive/trunk/ql/src/test/queries/clientpositive/describe_function.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_avg.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_count.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_max.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_min.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_std.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_stddev_samp.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_sum.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_var_samp.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_variance.q /hive/trunk/ql/src/test/queries/clientpositive/udf_divider.q /hive/trunk/ql/src/test/queries/clientpositive/udf_hour_minute_second.q /hive/trunk/ql/src/test/queries/clientpositive/udf_json.q /hive/trunk/ql/src/test/queries/clientpositive/udf_lpad_rpad.q /hive/trunk/ql/src/test/results/clientpositive/describe_function.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_avg.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_count.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_max.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_min.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_std.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_stddev_samp.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_sum.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_var_samp.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_variance.q.out /hive/trunk/ql/src/test/results/clientpositive/udf_divider.q.out /hive/trunk/ql/src/test/results/clientpositive/udf_hour_minute_second.q.out /hive/trunk/ql/src/test/results/clientpositive/udf_json.q.out /hive/trunk/ql/src/test/results/clientpositive/udf_lpad_rpad.q.out /hive/trunk/ql/src/test/results/compiler/errors/invalid_function_param1.q.out /hive/trunk/ql/src/test/results/compiler/errors/unknown_function5.q.out /hive/trunk/serde/src/gen-py/_ init _.py /hive/trunk/serde/src/gen/thrift/gen-py/_ init _.py /hive/trunk/service/src/gen-py/_ init _.py /hive/trunk/service/src/gen/thrift/gen-py/_ init _.py
        Ashutosh Chauhan made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Ashutosh Chauhan added a comment -

        This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

        Show
        Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1316 (See https://builds.apache.org/job/Hive-trunk-h0.21/1316/)
        HIVE-2850 [jira] Remove zero length files
        (Owen O'Malley via Ashutosh Chauhan)

        Summary:
        <<Enter Revision Title>>

        Remove empty files

        There are also zero-length non-source files that need to be removed.

        Test Plan: EMPTY

        Reviewers: JIRA, ashutoshc

        Reviewed By: ashutoshc

        Differential Revision: https://reviews.facebook.net/D2163 (Revision 1301629)

        Result = FAILURE
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301629
        Files :

        • /hive/trunk/data/warehouse/src/.gitignore
        • /hive/trunk/hwi/web/set_processor.jsp
        • /hive/trunk/metastore/src/gen-py/_init_.py
        • /hive/trunk/metastore/src/gen/thrift/gen-py/_init_.py
        • /hive/trunk/ql/src/gen/thrift/gen-py/_init_.py
        • /hive/trunk/ql/src/test/queries/clientpositive/describe_function.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_avg.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_count.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_max.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_min.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_std.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_stddev_samp.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_sum.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_var_samp.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udaf_variance.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udf_divider.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udf_hour_minute_second.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udf_json.q
        • /hive/trunk/ql/src/test/queries/clientpositive/udf_lpad_rpad.q
        • /hive/trunk/ql/src/test/results/clientpositive/describe_function.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_avg.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_count.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_max.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_min.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_std.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_stddev_samp.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_sum.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_var_samp.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udaf_variance.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udf_divider.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udf_hour_minute_second.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udf_json.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udf_lpad_rpad.q.out
        • /hive/trunk/ql/src/test/results/compiler/errors/invalid_function_param1.q.out
        • /hive/trunk/ql/src/test/results/compiler/errors/unknown_function5.q.out
        • /hive/trunk/serde/src/gen-py/_init_.py
        • /hive/trunk/serde/src/gen/thrift/gen-py/_init_.py
        • /hive/trunk/service/src/gen-py/_init_.py
        • /hive/trunk/service/src/gen/thrift/gen-py/_init_.py
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1316 (See https://builds.apache.org/job/Hive-trunk-h0.21/1316/ ) HIVE-2850 [jira] Remove zero length files (Owen O'Malley via Ashutosh Chauhan) Summary: <<Enter Revision Title>> Remove empty files There are also zero-length non-source files that need to be removed. Test Plan: EMPTY Reviewers: JIRA, ashutoshc Reviewed By: ashutoshc Differential Revision: https://reviews.facebook.net/D2163 (Revision 1301629) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301629 Files : /hive/trunk/data/warehouse/src/.gitignore /hive/trunk/hwi/web/set_processor.jsp /hive/trunk/metastore/src/gen-py/_ init _.py /hive/trunk/metastore/src/gen/thrift/gen-py/_ init _.py /hive/trunk/ql/src/gen/thrift/gen-py/_ init _.py /hive/trunk/ql/src/test/queries/clientpositive/describe_function.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_avg.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_count.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_max.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_min.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_std.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_stddev_samp.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_sum.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_var_samp.q /hive/trunk/ql/src/test/queries/clientpositive/udaf_variance.q /hive/trunk/ql/src/test/queries/clientpositive/udf_divider.q /hive/trunk/ql/src/test/queries/clientpositive/udf_hour_minute_second.q /hive/trunk/ql/src/test/queries/clientpositive/udf_json.q /hive/trunk/ql/src/test/queries/clientpositive/udf_lpad_rpad.q /hive/trunk/ql/src/test/results/clientpositive/describe_function.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_avg.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_count.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_max.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_min.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_std.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_stddev_samp.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_sum.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_var_samp.q.out /hive/trunk/ql/src/test/results/clientpositive/udaf_variance.q.out /hive/trunk/ql/src/test/results/clientpositive/udf_divider.q.out /hive/trunk/ql/src/test/results/clientpositive/udf_hour_minute_second.q.out /hive/trunk/ql/src/test/results/clientpositive/udf_json.q.out /hive/trunk/ql/src/test/results/clientpositive/udf_lpad_rpad.q.out /hive/trunk/ql/src/test/results/compiler/errors/invalid_function_param1.q.out /hive/trunk/ql/src/test/results/compiler/errors/unknown_function5.q.out /hive/trunk/serde/src/gen-py/_ init _.py /hive/trunk/serde/src/gen/thrift/gen-py/_ init _.py /hive/trunk/service/src/gen-py/_ init _.py /hive/trunk/service/src/gen/thrift/gen-py/_ init _.py
        Hide
        Phabricator added a comment -

        omalley has committed the revision "HIVE-2850 [jira] Remove zero length files".

        Change committed by hashutosh.

        REVISION DETAIL
        https://reviews.facebook.net/D2163

        COMMIT
        https://reviews.facebook.net/rHIVE1301629

        Show
        Phabricator added a comment - omalley has committed the revision " HIVE-2850 [jira] Remove zero length files". Change committed by hashutosh. REVISION DETAIL https://reviews.facebook.net/D2163 COMMIT https://reviews.facebook.net/rHIVE1301629
        Ashutosh Chauhan made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.9.0 [ 12317742 ]
        Resolution Fixed [ 1 ]
        Hide
        Ashutosh Chauhan added a comment -

        Committed. Thanks, Owen!

        Show
        Ashutosh Chauhan added a comment - Committed. Thanks, Owen!
        Hide
        Phabricator added a comment -

        ashutoshc has accepted the revision "HIVE-2850 [jira] Remove zero length files".

        Thanks , Owen for running tests. Will commit soon.

        REVISION DETAIL
        https://reviews.facebook.net/D2163

        BRANCH
        emptyfile

        Show
        Phabricator added a comment - ashutoshc has accepted the revision " HIVE-2850 [jira] Remove zero length files". Thanks , Owen for running tests. Will commit soon. REVISION DETAIL https://reviews.facebook.net/D2163 BRANCH emptyfile
        Owen O'Malley made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Owen O'Malley added a comment -

        Tests pass with files removed.

        Show
        Owen O'Malley added a comment - Tests pass with files removed.
        Phabricator made changes -
        Field Original Value New Value
        Attachment HIVE-2850.D2163.1.patch [ 12517374 ]
        Hide
        Phabricator added a comment -

        omalley requested code review of "HIVE-2850 [jira] Remove zero length files".
        Reviewers: JIRA

        <<Enter Revision Title>>

        Remove empty files

        There are also zero-length non-source files that need to be removed.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D2163

        AFFECTED FILES
        data/warehouse/src/.gitignore
        hwi/web/set_processor.jsp
        metastore/src/gen-py/_init_.py
        metastore/src/gen/thrift/gen-py/_init_.py
        ql/src/gen/thrift/gen-py/_init_.py
        ql/src/test/queries/clientpositive/describe_function.q
        ql/src/test/queries/clientpositive/udaf_avg.q
        ql/src/test/queries/clientpositive/udaf_count.q
        ql/src/test/queries/clientpositive/udaf_max.q
        ql/src/test/queries/clientpositive/udaf_min.q
        ql/src/test/queries/clientpositive/udaf_std.q
        ql/src/test/queries/clientpositive/udaf_stddev_samp.q
        ql/src/test/queries/clientpositive/udaf_sum.q
        ql/src/test/queries/clientpositive/udaf_var_samp.q
        ql/src/test/queries/clientpositive/udaf_variance.q
        ql/src/test/queries/clientpositive/udf_divider.q
        ql/src/test/queries/clientpositive/udf_hour_minute_second.q
        ql/src/test/queries/clientpositive/udf_json.q
        ql/src/test/queries/clientpositive/udf_lpad_rpad.q
        ql/src/test/results/clientpositive/describe_function.q.out
        ql/src/test/results/clientpositive/udaf_avg.q.out
        ql/src/test/results/clientpositive/udaf_count.q.out
        ql/src/test/results/clientpositive/udaf_max.q.out
        ql/src/test/results/clientpositive/udaf_min.q.out
        ql/src/test/results/clientpositive/udaf_std.q.out
        ql/src/test/results/clientpositive/udaf_stddev_samp.q.out
        ql/src/test/results/clientpositive/udaf_sum.q.out
        ql/src/test/results/clientpositive/udaf_var_samp.q.out
        ql/src/test/results/clientpositive/udaf_variance.q.out
        ql/src/test/results/clientpositive/udf_divider.q.out
        ql/src/test/results/clientpositive/udf_hour_minute_second.q.out
        ql/src/test/results/clientpositive/udf_json.q.out
        ql/src/test/results/clientpositive/udf_lpad_rpad.q.out
        ql/src/test/results/compiler/errors/invalid_function_param1.q.out
        ql/src/test/results/compiler/errors/unknown_function5.q.out
        serde/src/gen-py/_init_.py
        serde/src/gen/thrift/gen-py/_init_.py
        service/src/gen-py/_init_.py
        service/src/gen/thrift/gen-py/_init_.py

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/4731/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - omalley requested code review of " HIVE-2850 [jira] Remove zero length files". Reviewers: JIRA <<Enter Revision Title>> Remove empty files There are also zero-length non-source files that need to be removed. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D2163 AFFECTED FILES data/warehouse/src/.gitignore hwi/web/set_processor.jsp metastore/src/gen-py/_ init _.py metastore/src/gen/thrift/gen-py/_ init _.py ql/src/gen/thrift/gen-py/_ init _.py ql/src/test/queries/clientpositive/describe_function.q ql/src/test/queries/clientpositive/udaf_avg.q ql/src/test/queries/clientpositive/udaf_count.q ql/src/test/queries/clientpositive/udaf_max.q ql/src/test/queries/clientpositive/udaf_min.q ql/src/test/queries/clientpositive/udaf_std.q ql/src/test/queries/clientpositive/udaf_stddev_samp.q ql/src/test/queries/clientpositive/udaf_sum.q ql/src/test/queries/clientpositive/udaf_var_samp.q ql/src/test/queries/clientpositive/udaf_variance.q ql/src/test/queries/clientpositive/udf_divider.q ql/src/test/queries/clientpositive/udf_hour_minute_second.q ql/src/test/queries/clientpositive/udf_json.q ql/src/test/queries/clientpositive/udf_lpad_rpad.q ql/src/test/results/clientpositive/describe_function.q.out ql/src/test/results/clientpositive/udaf_avg.q.out ql/src/test/results/clientpositive/udaf_count.q.out ql/src/test/results/clientpositive/udaf_max.q.out ql/src/test/results/clientpositive/udaf_min.q.out ql/src/test/results/clientpositive/udaf_std.q.out ql/src/test/results/clientpositive/udaf_stddev_samp.q.out ql/src/test/results/clientpositive/udaf_sum.q.out ql/src/test/results/clientpositive/udaf_var_samp.q.out ql/src/test/results/clientpositive/udaf_variance.q.out ql/src/test/results/clientpositive/udf_divider.q.out ql/src/test/results/clientpositive/udf_hour_minute_second.q.out ql/src/test/results/clientpositive/udf_json.q.out ql/src/test/results/clientpositive/udf_lpad_rpad.q.out ql/src/test/results/compiler/errors/invalid_function_param1.q.out ql/src/test/results/compiler/errors/unknown_function5.q.out serde/src/gen-py/_ init _.py serde/src/gen/thrift/gen-py/_ init _.py service/src/gen-py/_ init _.py service/src/gen/thrift/gen-py/_ init _.py MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/4731/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Owen O'Malley created issue -

          People

          • Assignee:
            Owen O'Malley
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development