Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-28305

ProfileServlet: add html to output formats and prepare for profiler 3.0

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 4.1.0
    • None

    Description

      query-executor <14>1 2024-06-05T12:12:59.188Z query-executor-0-0 query-executor 1 8a250c32-ca6d-4fb8-a5a7-00569a3141d3 [mdc@18060 class="util.ProcessUtils" level="INFO" thread="llap-web-49"] Running command async: [/async-profiler/async-profiler-2.9-linux-x64/profiler.sh, -e, cpu, -d, 15, -o, svg, -f, /tmp/prof-output/async-prof-pid-1-cpu-1.svg, 1]
      query-executor [WARN] Unknown argument: svg
      query-executor [ERROR] SVG format is obsolete, use .html for FlameGraph
      

      https://github.com/apache/hive/blob/529fd45c6556c2e9e7f647297234b97c4060a031/common/src/java/org/apache/hive/http/ProfileServlet.java#L137-L145

      in recent versions of async-profiler, SVG is not accepted at all, and unfortunately, HTML cannot even be chosen due to a strict parse:
      https://github.com/apache/hive/blob/529fd45c6556c2e9e7f647297234b97c4060a031/common/src/java/org/apache/hive/http/ProfileServlet.java#L346

      for backward compatibility, SVG is fine, but HTML should be added to the enum

      Attachments

        1. async-prof-pid-21327-cpu-2.html
          17 kB
          László Bodor

        Issue Links

          Activity

            People

              abstractdog László Bodor
              abstractdog László Bodor
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: