[HIVE-28063] Drop PerfLogger#setPerfLogger method and unused fields/methods

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0
• Component/s: Hive, Standalone Metastore
• Labels: pull-request-available
• Assignee: Stamatis Zampetakis
• Reporter: Stamatis Zampetakis
• Created: 06/Feb/24 09:37
• Updated: 29/Mar/24 17:50
• Resolved: 29/Feb/24 09:50

Description

The PerfLogger#setPerfLogger is redundant and error-prone.

The small number of current uses could be replaced by simply calling the respective getter (which implicitly changes the underlying ThreadLocal variable).

Ideally thread local variable should never be set after obtaining the initial value. Moreover, allowing any caller to change the thread local variable can affect the correctness of the program.

Dropping this method improves the encapsulation and readability of the class.

The org.apache.hadoop.hive.metastore.metrics.PerfLogger has various unused fields/methods that can be removed as well to improve encapsulation, readability, and maintenance.

Issue Links

• links to: GitHub Pull Request #5066