Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.8.1, 0.9.0
    • Fix Version/s: 0.9.0
    • Component/s: Build Infrastructure
    • Labels:
      None

      Description

      After HIVE-2391 it is retrieved from maven repo via ivy, we can get rid of it from our lib/

      1. ASF.LICENSE.NOT.GRANTED--HIVE-2761.D1911.1.patch
        13 kB
        Phabricator
      2. ASF.LICENSE.NOT.GRANTED--HIVE-2761.D1911.2.patch
        14 kB
        Phabricator
      3. HIVE-2761.2.patch.txt
        14 kB
        Edward Capriolo
      4. HIVE-2761.3.patch.txt
        15 kB
        Edward Capriolo

        Activity

        Hide
        Carl Steinbach added a comment -

        We're not managing javaewah with Ivy because it's not available from any of the public Maven repos (as far as I know).

        Show
        Carl Steinbach added a comment - We're not managing javaewah with Ivy because it's not available from any of the public Maven repos (as far as I know).
        Hide
        Ashutosh Chauhan added a comment -

        Looking at http://code.google.com/p/javaewah/ it seems its now available via maven.

        Show
        Ashutosh Chauhan added a comment - Looking at http://code.google.com/p/javaewah/ it seems its now available via maven.
        Hide
        Daniel Lemire added a comment -

        That is correct. We upgraded the version of JavaEWAH to 0.3.1 when we posted it to the Maven central repository. Version 0.3.2 is simply a revision of the documentation (I corrected a few typos in the comments).

        You should be able to call on JavaEWAH as a dependency in the following manner:

        <dependencies>
        <dependency>
        <groupId>com.googlecode.javaewah</groupId>
        <artifactId>JavaEWAH</artifactId>
        <version>0.3.2</version>
        </dependency>
        </dependencies>

        The upgrade from 0.3.0 to 0.3.2 should be harmless.

        Show
        Daniel Lemire added a comment - That is correct. We upgraded the version of JavaEWAH to 0.3.1 when we posted it to the Maven central repository. Version 0.3.2 is simply a revision of the documentation (I corrected a few typos in the comments). You should be able to call on JavaEWAH as a dependency in the following manner: <dependencies> <dependency> <groupId>com.googlecode.javaewah</groupId> <artifactId>JavaEWAH</artifactId> <version>0.3.2</version> </dependency> </dependencies> The upgrade from 0.3.0 to 0.3.2 should be harmless.
        Hide
        Phabricator added a comment -

        edwardcapriolo requested code review of "HIVE-2761 [jira] Remove lib/javaewah-0.3.jar".
        Reviewers: JIRA

        https://issues.apache.org/jira/browse/HIVE-2761

        Jar in SVN bad. Jar from maven good.

        After HIVE-2391 it is retrieved from maven repo via ivy, we can get rid of it from our lib/

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D1911

        AFFECTED FILES
        lib/javaewah-0.3.jar
        lib/javaewah.LICENSE
        ivy/libraries.properties
        ql/ivy.xml
        ql/build.xml

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/4059/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - edwardcapriolo requested code review of " HIVE-2761 [jira] Remove lib/javaewah-0.3.jar". Reviewers: JIRA https://issues.apache.org/jira/browse/HIVE-2761 Jar in SVN bad. Jar from maven good. After HIVE-2391 it is retrieved from maven repo via ivy, we can get rid of it from our lib/ TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D1911 AFFECTED FILES lib/javaewah-0.3.jar lib/javaewah.LICENSE ivy/libraries.properties ql/ivy.xml ql/build.xml MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/4059/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        ashutoshc has accepted the revision "HIVE-2761 [jira] Remove lib/javaewah-0.3.jar".

        +1 Running tests.

        REVISION DETAIL
        https://reviews.facebook.net/D1911

        BRANCH
        svn

        Show
        Phabricator added a comment - ashutoshc has accepted the revision " HIVE-2761 [jira] Remove lib/javaewah-0.3.jar". +1 Running tests. REVISION DETAIL https://reviews.facebook.net/D1911 BRANCH svn
        Hide
        Ashutosh Chauhan added a comment -

        @Ed,
        Can you upload the patch on jira granting perms?

        Show
        Ashutosh Chauhan added a comment - @Ed, Can you upload the patch on jira granting perms?
        Hide
        Phabricator added a comment -

        edwardcapriolo updated the revision "HIVE-2761 [jira] Remove lib/javaewah-0.3.jar".
        Reviewers: JIRA, ashutoshc

        Found one more instance of javaewah hardcoded.

        REVISION DETAIL
        https://reviews.facebook.net/D1911

        AFFECTED FILES
        lib/javaewah-0.3.jar
        lib/javaewah.LICENSE
        ivy/libraries.properties
        build-common.xml
        ql/ivy.xml
        ql/build.xml

        Show
        Phabricator added a comment - edwardcapriolo updated the revision " HIVE-2761 [jira] Remove lib/javaewah-0.3.jar". Reviewers: JIRA, ashutoshc Found one more instance of javaewah hardcoded. REVISION DETAIL https://reviews.facebook.net/D1911 AFFECTED FILES lib/javaewah-0.3.jar lib/javaewah.LICENSE ivy/libraries.properties build-common.xml ql/ivy.xml ql/build.xml
        Hide
        Edward Capriolo added a comment -

        Found one more instance of javaEwah

        Show
        Edward Capriolo added a comment - Found one more instance of javaEwah
        Hide
        Ashutosh Chauhan added a comment -

        There is one more in .classpath

        Show
        Ashutosh Chauhan added a comment - There is one more in .classpath
        Hide
        Edward Capriolo added a comment -

        This covers the .classpath template as well.

        Show
        Edward Capriolo added a comment - This covers the .classpath template as well.
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Ed!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Ed!
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1276 (See https://builds.apache.org/job/Hive-trunk-h0.21/1276/)
        HIVE-2761: Remove lib/javaewah-0.3.jar (ecapriolo via hashutosh) (Revision 1293617)

        Result = FAILURE
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293617
        Files :

        • /hive/trunk/build-common.xml
        • /hive/trunk/eclipse-templates/.classpath
        • /hive/trunk/ivy/libraries.properties
        • /hive/trunk/lib/javaewah-0.3.jar
        • /hive/trunk/lib/javaewah.LICENSE
        • /hive/trunk/ql/build.xml
        • /hive/trunk/ql/ivy.xml
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1276 (See https://builds.apache.org/job/Hive-trunk-h0.21/1276/ ) HIVE-2761 : Remove lib/javaewah-0.3.jar (ecapriolo via hashutosh) (Revision 1293617) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293617 Files : /hive/trunk/build-common.xml /hive/trunk/eclipse-templates/.classpath /hive/trunk/ivy/libraries.properties /hive/trunk/lib/javaewah-0.3.jar /hive/trunk/lib/javaewah.LICENSE /hive/trunk/ql/build.xml /hive/trunk/ql/ivy.xml
        Hide
        Ashutosh Chauhan added a comment -

        This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

        Show
        Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-2761: Remove lib/javaewah-0.3.jar (ecapriolo via hashutosh) (Revision 1293617)

        Result = ABORTED
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293617
        Files :

        • /hive/trunk/build-common.xml
        • /hive/trunk/eclipse-templates/.classpath
        • /hive/trunk/ivy/libraries.properties
        • /hive/trunk/lib/javaewah-0.3.jar
        • /hive/trunk/lib/javaewah.LICENSE
        • /hive/trunk/ql/build.xml
        • /hive/trunk/ql/ivy.xml
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2761 : Remove lib/javaewah-0.3.jar (ecapriolo via hashutosh) (Revision 1293617) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293617 Files : /hive/trunk/build-common.xml /hive/trunk/eclipse-templates/.classpath /hive/trunk/ivy/libraries.properties /hive/trunk/lib/javaewah-0.3.jar /hive/trunk/lib/javaewah.LICENSE /hive/trunk/ql/build.xml /hive/trunk/ql/ivy.xml

          People

          • Assignee:
            Edward Capriolo
            Reporter:
            Ashutosh Chauhan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development