Hive
  1. Hive
  2. HIVE-2759

Change global_limit.q into linux format file

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Testing Infrastructure
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      global_limit.q is in dos format, and has "\ No newline at end of file".
      Needs to be changed into linux format, removing all "^M" at the end of each line.

        Activity

        Zhenxiao Luo created issue -
        Hide
        Phabricator added a comment -

        zhenxiao requested code review of "HIVE-2759 [jira] Change global_limit.q into linux format file".
        Reviewers: JIRA

        HIVE-2759: Change global_limit.q into linux format file

        global_limit.q is in dos format, and has "\ No newline at end of file".
        Needs to be changed into linux format, removing all "^M" at the end of each line.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D1497

        AFFECTED FILES
        ql/src/test/queries/clientpositive/global_limit.q

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/3111/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - zhenxiao requested code review of " HIVE-2759 [jira] Change global_limit.q into linux format file". Reviewers: JIRA HIVE-2759 : Change global_limit.q into linux format file global_limit.q is in dos format, and has "\ No newline at end of file". Needs to be changed into linux format, removing all "^M" at the end of each line. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D1497 AFFECTED FILES ql/src/test/queries/clientpositive/global_limit.q MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/3111/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Phabricator made changes -
        Field Original Value New Value
        Attachment HIVE-2759.D1497.1.patch [ 12512224 ]
        Zhenxiao Luo made changes -
        Attachment HIVE-2759.D1497.1.patch [ 12512225 ]
        Zhenxiao Luo made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Phabricator added a comment -

        njain has accepted the revision "HIVE-2759 [jira] Change global_limit.q into linux format file".

        REVISION DETAIL
        https://reviews.facebook.net/D1497

        Show
        Phabricator added a comment - njain has accepted the revision " HIVE-2759 [jira] Change global_limit.q into linux format file". REVISION DETAIL https://reviews.facebook.net/D1497
        Hide
        Namit Jain added a comment -

        Committed. Thanks Zhenxiao

        Show
        Namit Jain added a comment - Committed. Thanks Zhenxiao
        Namit Jain made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1249 (See https://builds.apache.org/job/Hive-trunk-h0.21/1249/)
        HIVE-2759 Change global_limit.q into linux format file
        (Zhenxiao Luo via namit)

        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242071
        Files :

        • /hive/trunk/ql/src/test/queries/clientpositive/global_limit.q
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1249 (See https://builds.apache.org/job/Hive-trunk-h0.21/1249/ ) HIVE-2759 Change global_limit.q into linux format file (Zhenxiao Luo via namit) namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242071 Files : /hive/trunk/ql/src/test/queries/clientpositive/global_limit.q
        Carl Steinbach made changes -
        Fix Version/s 0.9.0 [ 12317742 ]
        Hide
        Ashutosh Chauhan added a comment -

        This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

        Show
        Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.
        Ashutosh Chauhan made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-2759 Change global_limit.q into linux format file
        (Zhenxiao Luo via namit) (Revision 1242071)

        Result = ABORTED
        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242071
        Files :

        • /hive/trunk/ql/src/test/queries/clientpositive/global_limit.q
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2759 Change global_limit.q into linux format file (Zhenxiao Luo via namit) (Revision 1242071) Result = ABORTED namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242071 Files : /hive/trunk/ql/src/test/queries/clientpositive/global_limit.q

          People

          • Assignee:
            Zhenxiao Luo
            Reporter:
            Zhenxiao Luo
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development