Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When looking at the 0.8.1 rc1, I discovered there were a set of empty Java files that were likely left over from using 'patch' without the -E.

      jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcSessionState.java
      ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeIndexEvaluator.java
      ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinObject.java
      ql/src/java/org/apache/hadoop/hive/ql/exec/PathUtil.java
      ql/src/java/org/apache/hadoop/hive/ql/exec/TypedBytesRecordReader.java
      ql/src/java/org/apache/hadoop/hive/ql/plan/AlterPartitionProtectModeDesc.java
      ql/src/java/org/apache/hadoop/hive/ql/plan/TouchDesc.java
      ql/src/test/org/apache/hadoop/hive/ql/plan/TestAddPartition.java
      serde/src/gen-java/org/apache/hadoop/hive/serde/test/Constants.java
      shims/src/0.20/java/org/apache/hadoop/fs/ProxyFileSystem.java
      shims/src/0.20/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java

      1. h-2753.patch
        2 kB
        Owen O'Malley
      2. ASF.LICENSE.NOT.GRANTED--HIVE-2753.D1611.1.patch
        2 kB
        Phabricator

        Activity

        Hide
        Owen O'Malley added a comment -

        Here's the obvious patch. I'm running tests, but I can't imagine this breaks anything.

        Show
        Owen O'Malley added a comment - Here's the obvious patch. I'm running tests, but I can't imagine this breaks anything.
        Hide
        Carl Steinbach added a comment -

        @Owen: Can you try submitting this patch with arc? It would be good to see if arc handles deleted files properly. Thanks.

        Show
        Carl Steinbach added a comment - @Owen: Can you try submitting this patch with arc? It would be good to see if arc handles deleted files properly. Thanks.
        Hide
        Owen O'Malley added a comment -

        The unit tests run fine as expected.

        Show
        Owen O'Malley added a comment - The unit tests run fine as expected.
        Hide
        Owen O'Malley added a comment -

        @Carl what is arc?

        Show
        Owen O'Malley added a comment - @Carl what is arc?
        Hide
        Phabricator added a comment -

        omalley requested code review of "HIVE-2753 [jira] Remove empty java files".
        Reviewers: JIRA

        remove dead java files

        When looking at the 0.8.1 rc1, I discovered there were a set of empty Java files that were likely left over from using 'patch' without the -E.

        jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcSessionState.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeIndexEvaluator.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinObject.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/PathUtil.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/TypedBytesRecordReader.java
        ql/src/java/org/apache/hadoop/hive/ql/plan/AlterPartitionProtectModeDesc.java
        ql/src/java/org/apache/hadoop/hive/ql/plan/TouchDesc.java
        ql/src/test/org/apache/hadoop/hive/ql/plan/TestAddPartition.java
        serde/src/gen-java/org/apache/hadoop/hive/serde/test/Constants.java
        shims/src/0.20/java/org/apache/hadoop/fs/ProxyFileSystem.java
        shims/src/0.20/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D1611

        AFFECTED FILES
        jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcSessionState.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeIndexEvaluator.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinObject.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/PathUtil.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/TypedBytesRecordReader.java
        ql/src/java/org/apache/hadoop/hive/ql/plan/AlterPartitionProtectModeDesc.java
        ql/src/java/org/apache/hadoop/hive/ql/plan/TouchDesc.java
        ql/src/test/org/apache/hadoop/hive/ql/plan/TestAddPartition.java
        serde/src/gen-java/org/apache/hadoop/hive/serde/test/Constants.java
        shims/src/0.20/java/org/apache/hadoop/fs/ProxyFileSystem.java
        shims/src/0.20/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/3435/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - omalley requested code review of " HIVE-2753 [jira] Remove empty java files". Reviewers: JIRA remove dead java files When looking at the 0.8.1 rc1, I discovered there were a set of empty Java files that were likely left over from using 'patch' without the -E. jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcSessionState.java ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeIndexEvaluator.java ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinObject.java ql/src/java/org/apache/hadoop/hive/ql/exec/PathUtil.java ql/src/java/org/apache/hadoop/hive/ql/exec/TypedBytesRecordReader.java ql/src/java/org/apache/hadoop/hive/ql/plan/AlterPartitionProtectModeDesc.java ql/src/java/org/apache/hadoop/hive/ql/plan/TouchDesc.java ql/src/test/org/apache/hadoop/hive/ql/plan/TestAddPartition.java serde/src/gen-java/org/apache/hadoop/hive/serde/test/Constants.java shims/src/0.20/java/org/apache/hadoop/fs/ProxyFileSystem.java shims/src/0.20/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D1611 AFFECTED FILES jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcSessionState.java ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeIndexEvaluator.java ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinObject.java ql/src/java/org/apache/hadoop/hive/ql/exec/PathUtil.java ql/src/java/org/apache/hadoop/hive/ql/exec/TypedBytesRecordReader.java ql/src/java/org/apache/hadoop/hive/ql/plan/AlterPartitionProtectModeDesc.java ql/src/java/org/apache/hadoop/hive/ql/plan/TouchDesc.java ql/src/test/org/apache/hadoop/hive/ql/plan/TestAddPartition.java serde/src/gen-java/org/apache/hadoop/hive/serde/test/Constants.java shims/src/0.20/java/org/apache/hadoop/fs/ProxyFileSystem.java shims/src/0.20/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/3435/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Ashutosh Chauhan added a comment -

        @Carl,

        Would you like to give this a try with arc?

        Show
        Ashutosh Chauhan added a comment - @Carl, Would you like to give this a try with arc?
        Hide
        Phabricator added a comment -

        cwsteinbach has accepted the revision "HIVE-2753 [jira] Remove empty java files".

        REVISION DETAIL
        https://reviews.facebook.net/D1611

        Show
        Phabricator added a comment - cwsteinbach has accepted the revision " HIVE-2753 [jira] Remove empty java files". REVISION DETAIL https://reviews.facebook.net/D1611
        Hide
        Carl Steinbach added a comment -

        Committed to trunk. Thanks Owen!

        Show
        Carl Steinbach added a comment - Committed to trunk. Thanks Owen!
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1257 (See https://builds.apache.org/job/Hive-trunk-h0.21/1257/)
        HIVE-2753 [jira] Remove empty java files
        (Owen O'Malley via Carl Steinbach)

        Summary:
        remove dead java files

        When looking at the 0.8.1 rc1, I discovered there were a set of empty Java files
        that were likely left over from using 'patch' without the -E.

        jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcSessionState.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeIndexEvaluator.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinObject.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/PathUtil.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/TypedBytesRecordReader.java
        ql/src/java/org/apache/hadoop/hive/ql/plan/AlterPartitionProtectModeDesc.java
        ql/src/java/org/apache/hadoop/hive/ql/plan/TouchDesc.java
        ql/src/test/org/apache/hadoop/hive/ql/plan/TestAddPartition.java
        serde/src/gen-java/org/apache/hadoop/hive/serde/test/Constants.java
        shims/src/0.20/java/org/apache/hadoop/fs/ProxyFileSystem.java
        shims/src/0.20/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java

        Test Plan: EMPTY

        Reviewers: JIRA, cwsteinbach

        Reviewed By: cwsteinbach

        CC: cwsteinbach

        Differential Revision: https://reviews.facebook.net/D1611 (Revision 1243762)

        Result = FAILURE
        cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243762
        Files :

        • /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcSessionState.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeIndexEvaluator.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinObject.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/PathUtil.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TypedBytesRecordReader.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterPartitionProtectModeDesc.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/TouchDesc.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/plan/TestAddPartition.java
        • /hive/trunk/serde/src/gen-java/org/apache/hadoop/hive/serde/test/Constants.java
        • /hive/trunk/shims/src/0.20/java/org/apache/hadoop/fs/ProxyFileSystem.java
        • /hive/trunk/shims/src/0.20/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1257 (See https://builds.apache.org/job/Hive-trunk-h0.21/1257/ ) HIVE-2753 [jira] Remove empty java files (Owen O'Malley via Carl Steinbach) Summary: remove dead java files When looking at the 0.8.1 rc1, I discovered there were a set of empty Java files that were likely left over from using 'patch' without the -E. jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcSessionState.java ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeIndexEvaluator.java ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinObject.java ql/src/java/org/apache/hadoop/hive/ql/exec/PathUtil.java ql/src/java/org/apache/hadoop/hive/ql/exec/TypedBytesRecordReader.java ql/src/java/org/apache/hadoop/hive/ql/plan/AlterPartitionProtectModeDesc.java ql/src/java/org/apache/hadoop/hive/ql/plan/TouchDesc.java ql/src/test/org/apache/hadoop/hive/ql/plan/TestAddPartition.java serde/src/gen-java/org/apache/hadoop/hive/serde/test/Constants.java shims/src/0.20/java/org/apache/hadoop/fs/ProxyFileSystem.java shims/src/0.20/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java Test Plan: EMPTY Reviewers: JIRA, cwsteinbach Reviewed By: cwsteinbach CC: cwsteinbach Differential Revision: https://reviews.facebook.net/D1611 (Revision 1243762) Result = FAILURE cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243762 Files : /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcSessionState.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeIndexEvaluator.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinObject.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/PathUtil.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TypedBytesRecordReader.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterPartitionProtectModeDesc.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/TouchDesc.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/plan/TestAddPartition.java /hive/trunk/serde/src/gen-java/org/apache/hadoop/hive/serde/test/Constants.java /hive/trunk/shims/src/0.20/java/org/apache/hadoop/fs/ProxyFileSystem.java /hive/trunk/shims/src/0.20/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java
        Hide
        Phabricator added a comment -

        omalley has committed the revision "HIVE-2753 [jira] Remove empty java files".

        Change committed by cws.

        REVISION DETAIL
        https://reviews.facebook.net/D1611

        COMMIT
        https://reviews.facebook.net/rHIVE1243762

        Show
        Phabricator added a comment - omalley has committed the revision " HIVE-2753 [jira] Remove empty java files". Change committed by cws. REVISION DETAIL https://reviews.facebook.net/D1611 COMMIT https://reviews.facebook.net/rHIVE1243762
        Hide
        Ashutosh Chauhan added a comment -

        This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

        Show
        Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-2753 [jira] Remove empty java files
        (Owen O'Malley via Carl Steinbach)

        Summary:
        remove dead java files

        When looking at the 0.8.1 rc1, I discovered there were a set of empty Java files
        that were likely left over from using 'patch' without the -E.

        jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcSessionState.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeIndexEvaluator.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinObject.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/PathUtil.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/TypedBytesRecordReader.java
        ql/src/java/org/apache/hadoop/hive/ql/plan/AlterPartitionProtectModeDesc.java
        ql/src/java/org/apache/hadoop/hive/ql/plan/TouchDesc.java
        ql/src/test/org/apache/hadoop/hive/ql/plan/TestAddPartition.java
        serde/src/gen-java/org/apache/hadoop/hive/serde/test/Constants.java
        shims/src/0.20/java/org/apache/hadoop/fs/ProxyFileSystem.java
        shims/src/0.20/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java

        Test Plan: EMPTY

        Reviewers: JIRA, cwsteinbach

        Reviewed By: cwsteinbach

        CC: cwsteinbach

        Differential Revision: https://reviews.facebook.net/D1611 (Revision 1243762)

        Result = ABORTED
        cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243762
        Files :

        • /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcSessionState.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeIndexEvaluator.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinObject.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/PathUtil.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TypedBytesRecordReader.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterPartitionProtectModeDesc.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/TouchDesc.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/plan/TestAddPartition.java
        • /hive/trunk/serde/src/gen-java/org/apache/hadoop/hive/serde/test/Constants.java
        • /hive/trunk/shims/src/0.20/java/org/apache/hadoop/fs/ProxyFileSystem.java
        • /hive/trunk/shims/src/0.20/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2753 [jira] Remove empty java files (Owen O'Malley via Carl Steinbach) Summary: remove dead java files When looking at the 0.8.1 rc1, I discovered there were a set of empty Java files that were likely left over from using 'patch' without the -E. jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcSessionState.java ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeIndexEvaluator.java ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinObject.java ql/src/java/org/apache/hadoop/hive/ql/exec/PathUtil.java ql/src/java/org/apache/hadoop/hive/ql/exec/TypedBytesRecordReader.java ql/src/java/org/apache/hadoop/hive/ql/plan/AlterPartitionProtectModeDesc.java ql/src/java/org/apache/hadoop/hive/ql/plan/TouchDesc.java ql/src/test/org/apache/hadoop/hive/ql/plan/TestAddPartition.java serde/src/gen-java/org/apache/hadoop/hive/serde/test/Constants.java shims/src/0.20/java/org/apache/hadoop/fs/ProxyFileSystem.java shims/src/0.20/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java Test Plan: EMPTY Reviewers: JIRA, cwsteinbach Reviewed By: cwsteinbach CC: cwsteinbach Differential Revision: https://reviews.facebook.net/D1611 (Revision 1243762) Result = ABORTED cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243762 Files : /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcSessionState.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeIndexEvaluator.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinObject.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/PathUtil.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TypedBytesRecordReader.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterPartitionProtectModeDesc.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/TouchDesc.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/plan/TestAddPartition.java /hive/trunk/serde/src/gen-java/org/apache/hadoop/hive/serde/test/Constants.java /hive/trunk/shims/src/0.20/java/org/apache/hadoop/fs/ProxyFileSystem.java /hive/trunk/shims/src/0.20/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java

          People

          • Assignee:
            Owen O'Malley
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development