Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: UDF
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Activity

      Hide
      Carl Steinbach added a comment -

      Add a PRINTF(String format, Obj... args) Udf that can format strings according to printf-style format strings.

      Ref: http://docs.oracle.com/javase/1.5.0/docs/api/java/util/Formatter.html

      Show
      Carl Steinbach added a comment - Add a PRINTF(String format, Obj... args) Udf that can format strings according to printf-style format strings. Ref: http://docs.oracle.com/javase/1.5.0/docs/api/java/util/Formatter.html
      Hide
      Phabricator added a comment -

      zhenxiao requested code review of "HIVE-2695 [jira] Add PRINTF() Udf".
      Reviewers: JIRA

      HIVE-2695: Add PRINTF() UDF

      TEST PLAN
      EMPTY

      REVISION DETAIL
      https://reviews.facebook.net/D1155

      AFFECTED FILES
      ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
      ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java
      ql/src/test/queries/clientnegative/udf_printf_wrong1.q
      ql/src/test/queries/clientnegative/udf_printf_wrong2.q
      ql/src/test/queries/clientnegative/udf_printf_wrong3.q
      ql/src/test/queries/clientpositive/udf_printf.q
      ql/src/test/results/clientnegative/udf_printf_wrong1.q.out
      ql/src/test/results/clientnegative/udf_printf_wrong2.q.out
      ql/src/test/results/clientnegative/udf_printf_wrong3.q.out
      ql/src/test/results/clientpositive/show_functions.q.out
      ql/src/test/results/clientpositive/udf_printf.q.out

      MANAGE HERALD DIFFERENTIAL RULES
      https://reviews.facebook.net/herald/view/differential/

      WHY DID I GET THIS EMAIL?
      https://reviews.facebook.net/herald/transcript/2427/

      Tip: use the X-Herald-Rules header to filter Herald messages in your client.

      Show
      Phabricator added a comment - zhenxiao requested code review of " HIVE-2695 [jira] Add PRINTF() Udf". Reviewers: JIRA HIVE-2695 : Add PRINTF() UDF TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D1155 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java ql/src/test/queries/clientnegative/udf_printf_wrong1.q ql/src/test/queries/clientnegative/udf_printf_wrong2.q ql/src/test/queries/clientnegative/udf_printf_wrong3.q ql/src/test/queries/clientpositive/udf_printf.q ql/src/test/results/clientnegative/udf_printf_wrong1.q.out ql/src/test/results/clientnegative/udf_printf_wrong2.q.out ql/src/test/results/clientnegative/udf_printf_wrong3.q.out ql/src/test/results/clientpositive/show_functions.q.out ql/src/test/results/clientpositive/udf_printf.q.out MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/2427/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
      Hide
      Zhenxiao Luo added a comment -

      Needs more testcases

      Show
      Zhenxiao Luo added a comment - Needs more testcases
      Hide
      Phabricator added a comment -

      zhenxiao requested code review of "HIVE-2695 [jira] Add PRINTF() Udf".
      Reviewers: JIRA

      HIVE-2695: Add Printf() UDF

      TEST PLAN
      EMPTY

      REVISION DETAIL
      https://reviews.facebook.net/D1161

      AFFECTED FILES
      ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
      ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java
      ql/src/test/queries/clientnegative/udf_printf_wrong1.q
      ql/src/test/queries/clientnegative/udf_printf_wrong2.q
      ql/src/test/queries/clientnegative/udf_printf_wrong3.q
      ql/src/test/queries/clientnegative/udf_printf_wrong4.q
      ql/src/test/queries/clientpositive/udf_printf.q
      ql/src/test/results/clientnegative/udf_printf_wrong1.q.out
      ql/src/test/results/clientnegative/udf_printf_wrong2.q.out
      ql/src/test/results/clientnegative/udf_printf_wrong3.q.out
      ql/src/test/results/clientpositive/show_functions.q.out
      ql/src/test/results/clientpositive/udf_printf.q.out

      MANAGE HERALD DIFFERENTIAL RULES
      https://reviews.facebook.net/herald/view/differential/

      WHY DID I GET THIS EMAIL?
      https://reviews.facebook.net/herald/transcript/2433/

      Tip: use the X-Herald-Rules header to filter Herald messages in your client.

      Show
      Phabricator added a comment - zhenxiao requested code review of " HIVE-2695 [jira] Add PRINTF() Udf". Reviewers: JIRA HIVE-2695 : Add Printf() UDF TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D1161 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java ql/src/test/queries/clientnegative/udf_printf_wrong1.q ql/src/test/queries/clientnegative/udf_printf_wrong2.q ql/src/test/queries/clientnegative/udf_printf_wrong3.q ql/src/test/queries/clientnegative/udf_printf_wrong4.q ql/src/test/queries/clientpositive/udf_printf.q ql/src/test/results/clientnegative/udf_printf_wrong1.q.out ql/src/test/results/clientnegative/udf_printf_wrong2.q.out ql/src/test/results/clientnegative/udf_printf_wrong3.q.out ql/src/test/results/clientpositive/show_functions.q.out ql/src/test/results/clientpositive/udf_printf.q.out MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/2433/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
      Hide
      Phabricator added a comment -

      zhenxiao has commented on the revision "HIVE-2695 [jira] Add PRINTF() Udf".

      Invalid patch. More testcases needed.

      REVISION DETAIL
      https://reviews.facebook.net/D1155

      Show
      Phabricator added a comment - zhenxiao has commented on the revision " HIVE-2695 [jira] Add PRINTF() Udf". Invalid patch. More testcases needed. REVISION DETAIL https://reviews.facebook.net/D1155
      Hide
      Phabricator added a comment -

      zhenxiao has commented on the revision "HIVE-2695 [jira] Add PRINTF() Udf".

      udf_printf_wrong4.q.out is missing, will checkin a new patch soon

      REVISION DETAIL
      https://reviews.facebook.net/D1161

      Show
      Phabricator added a comment - zhenxiao has commented on the revision " HIVE-2695 [jira] Add PRINTF() Udf". udf_printf_wrong4.q.out is missing, will checkin a new patch soon REVISION DETAIL https://reviews.facebook.net/D1161
      Hide
      Phabricator added a comment -

      zhenxiao requested code review of "HIVE-2695 [jira] Add PRINTF() Udf".
      Reviewers: JIRA

      HIVE-2695: Add Printf() UDF

      TEST PLAN
      EMPTY

      REVISION DETAIL
      https://reviews.facebook.net/D1173

      AFFECTED FILES
      ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
      ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java
      ql/src/test/queries/clientnegative/udf_printf_wrong1.q
      ql/src/test/queries/clientnegative/udf_printf_wrong2.q
      ql/src/test/queries/clientnegative/udf_printf_wrong3.q
      ql/src/test/queries/clientnegative/udf_printf_wrong4.q
      ql/src/test/queries/clientpositive/udf_printf.q
      ql/src/test/results/clientnegative/udf_printf_wrong1.q.out
      ql/src/test/results/clientnegative/udf_printf_wrong2.q.out
      ql/src/test/results/clientnegative/udf_printf_wrong3.q.out
      ql/src/test/results/clientnegative/udf_printf_wrong4.q.out
      ql/src/test/results/clientpositive/show_functions.q.out
      ql/src/test/results/clientpositive/udf_printf.q.out

      MANAGE HERALD DIFFERENTIAL RULES
      https://reviews.facebook.net/herald/view/differential/

      WHY DID I GET THIS EMAIL?
      https://reviews.facebook.net/herald/transcript/2451/

      Tip: use the X-Herald-Rules header to filter Herald messages in your client.

      Show
      Phabricator added a comment - zhenxiao requested code review of " HIVE-2695 [jira] Add PRINTF() Udf". Reviewers: JIRA HIVE-2695 : Add Printf() UDF TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D1173 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java ql/src/test/queries/clientnegative/udf_printf_wrong1.q ql/src/test/queries/clientnegative/udf_printf_wrong2.q ql/src/test/queries/clientnegative/udf_printf_wrong3.q ql/src/test/queries/clientnegative/udf_printf_wrong4.q ql/src/test/queries/clientpositive/udf_printf.q ql/src/test/results/clientnegative/udf_printf_wrong1.q.out ql/src/test/results/clientnegative/udf_printf_wrong2.q.out ql/src/test/results/clientnegative/udf_printf_wrong3.q.out ql/src/test/results/clientnegative/udf_printf_wrong4.q.out ql/src/test/results/clientpositive/show_functions.q.out ql/src/test/results/clientpositive/udf_printf.q.out MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/2451/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
      Hide
      Namit Jain added a comment -

      +1

      Show
      Namit Jain added a comment - +1
      Hide
      Namit Jain added a comment -

      Committed. Thanks Zhenxiao

      Show
      Namit Jain added a comment - Committed. Thanks Zhenxiao
      Hide
      Hudson added a comment -

      Integrated in Hive-trunk-h0.21 #1198 (See https://builds.apache.org/job/Hive-trunk-h0.21/1198/)
      HIVE-2695 Add PRINTF() Udf (Zhenxiao Luo via namit)

      namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1230758
      Files :

      • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
      • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java
      • /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong1.q
      • /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong2.q
      • /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong3.q
      • /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong4.q
      • /hive/trunk/ql/src/test/queries/clientpositive/udf_printf.q
      • /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong1.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong2.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong3.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong4.q.out
      • /hive/trunk/ql/src/test/results/clientpositive/show_functions.q.out
      • /hive/trunk/ql/src/test/results/clientpositive/udf_printf.q.out
      Show
      Hudson added a comment - Integrated in Hive-trunk-h0.21 #1198 (See https://builds.apache.org/job/Hive-trunk-h0.21/1198/ ) HIVE-2695 Add PRINTF() Udf (Zhenxiao Luo via namit) namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1230758 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong1.q /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong2.q /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong3.q /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong4.q /hive/trunk/ql/src/test/queries/clientpositive/udf_printf.q /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong1.q.out /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong2.q.out /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong3.q.out /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong4.q.out /hive/trunk/ql/src/test/results/clientpositive/show_functions.q.out /hive/trunk/ql/src/test/results/clientpositive/udf_printf.q.out
      Hide
      Hudson added a comment -

      Integrated in Hive-trunk-h0.21-dbg #3 (See https://builds.apache.org/job/Hive-trunk-h0.21-dbg/3/)
      HIVE-2695 Add PRINTF() Udf (Zhenxiao Luo via namit)

      namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1230758
      Files :

      • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
      • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java
      • /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong1.q
      • /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong2.q
      • /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong3.q
      • /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong4.q
      • /hive/trunk/ql/src/test/queries/clientpositive/udf_printf.q
      • /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong1.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong2.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong3.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong4.q.out
      • /hive/trunk/ql/src/test/results/clientpositive/show_functions.q.out
      • /hive/trunk/ql/src/test/results/clientpositive/udf_printf.q.out
      Show
      Hudson added a comment - Integrated in Hive-trunk-h0.21-dbg #3 (See https://builds.apache.org/job/Hive-trunk-h0.21-dbg/3/ ) HIVE-2695 Add PRINTF() Udf (Zhenxiao Luo via namit) namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1230758 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong1.q /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong2.q /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong3.q /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong4.q /hive/trunk/ql/src/test/queries/clientpositive/udf_printf.q /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong1.q.out /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong2.q.out /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong3.q.out /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong4.q.out /hive/trunk/ql/src/test/results/clientpositive/show_functions.q.out /hive/trunk/ql/src/test/results/clientpositive/udf_printf.q.out
      Hide
      Ashutosh Chauhan added a comment -

      This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

      Show
      Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.
      Hide
      Phabricator added a comment -

      zhenxiao has abandoned the revision "HIVE-2695 [jira] Add PRINTF() Udf".

      REVISION DETAIL
      https://reviews.facebook.net/D1155

      To: JIRA, zhenxiao
      Cc: zhenxiao

      Show
      Phabricator added a comment - zhenxiao has abandoned the revision " HIVE-2695 [jira] Add PRINTF() Udf". REVISION DETAIL https://reviews.facebook.net/D1155 To: JIRA, zhenxiao Cc: zhenxiao
      Hide
      Phabricator added a comment -

      zhenxiao has abandoned the revision "HIVE-2695 [jira] Add PRINTF() Udf".

      REVISION DETAIL
      https://reviews.facebook.net/D1161

      To: JIRA, zhenxiao
      Cc: zhenxiao

      Show
      Phabricator added a comment - zhenxiao has abandoned the revision " HIVE-2695 [jira] Add PRINTF() Udf". REVISION DETAIL https://reviews.facebook.net/D1161 To: JIRA, zhenxiao Cc: zhenxiao
      Hide
      Phabricator added a comment -

      zhenxiao has abandoned the revision "HIVE-2695 [jira] Add PRINTF() Udf".

      REVISION DETAIL
      https://reviews.facebook.net/D1173

      To: JIRA, zhenxiao

      Show
      Phabricator added a comment - zhenxiao has abandoned the revision " HIVE-2695 [jira] Add PRINTF() Udf". REVISION DETAIL https://reviews.facebook.net/D1173 To: JIRA, zhenxiao
      Hide
      Hudson added a comment -

      Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
      HIVE-2695 Add PRINTF() Udf (Zhenxiao Luo via namit) (Revision 1230758)

      Result = ABORTED
      namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1230758
      Files :

      • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
      • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java
      • /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong1.q
      • /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong2.q
      • /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong3.q
      • /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong4.q
      • /hive/trunk/ql/src/test/queries/clientpositive/udf_printf.q
      • /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong1.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong2.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong3.q.out
      • /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong4.q.out
      • /hive/trunk/ql/src/test/results/clientpositive/show_functions.q.out
      • /hive/trunk/ql/src/test/results/clientpositive/udf_printf.q.out
      Show
      Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2695 Add PRINTF() Udf (Zhenxiao Luo via namit) (Revision 1230758) Result = ABORTED namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1230758 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong1.q /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong2.q /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong3.q /hive/trunk/ql/src/test/queries/clientnegative/udf_printf_wrong4.q /hive/trunk/ql/src/test/queries/clientpositive/udf_printf.q /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong1.q.out /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong2.q.out /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong3.q.out /hive/trunk/ql/src/test/results/clientnegative/udf_printf_wrong4.q.out /hive/trunk/ql/src/test/results/clientpositive/show_functions.q.out /hive/trunk/ql/src/test/results/clientpositive/udf_printf.q.out

        People

        • Assignee:
          Zhenxiao Luo
          Reporter:
          Carl Steinbach
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development