Hive
  1. Hive
  2. HIVE-2660

Need better exception handling in RCFile tolerate corruptions mode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Query Processor
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The exception handling in nextKeyValueTolerateCorruptions treats IOException as follows:

      • if EOFException, corrupt, can be tolerated
      • If CheckSumException, corrupt, can be tolerated
      • else not a corruption, re-throw

      But the compression code can also throw IOException in case of corruption, which will get re-thrown in this case.

      The correct way of handling IOException is:

      • if BlockMissingException, re-throw.
      • if not BlockMissingException -> corruption, can be tolerated
      1. HIVE-2660.1.patch
        2 kB
        Ramkumar Vadali
      2. HIVE-2660.patch
        2 kB
        Ramkumar Vadali

        Activity

        Hide
        Ashutosh Chauhan added a comment -

        This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

        Show
        Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1153 (See https://builds.apache.org/job/Hive-trunk-h0.21/1153/)
        HIVE-2660 Need better exception handling in RCFile tolerate corruptions
        mode (Ramkumar Vadali via namit)

        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1215226
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1153 (See https://builds.apache.org/job/Hive-trunk-h0.21/1153/ ) HIVE-2660 Need better exception handling in RCFile tolerate corruptions mode (Ramkumar Vadali via namit) namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1215226 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java
        Hide
        Namit Jain added a comment -

        Committed. Thanks Ram

        Show
        Namit Jain added a comment - Committed. Thanks Ram
        Hide
        Namit Jain added a comment -

        +1

        Show
        Namit Jain added a comment - +1

          People

          • Assignee:
            Ramkumar Vadali
            Reporter:
            Ramkumar Vadali
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development