Hive
  1. Hive
  2. HIVE-2647

Force Bash shell on parallel test slave nodes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Testing Infrastructure
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Force use of Bash shell, so user default shell choice doesn't impact the test script.

        Activity

        Hide
        Phabricator added a comment -

        mareksapotafb has added reviewers to the revision "HIVE-2647 [jira] Force Bash shell on parallel test slave nodes".
        Added Reviewers: njain

        REVISION DETAIL
        https://reviews.facebook.net/D771

        Show
        Phabricator added a comment - mareksapotafb has added reviewers to the revision " HIVE-2647 [jira] Force Bash shell on parallel test slave nodes". Added Reviewers: njain REVISION DETAIL https://reviews.facebook.net/D771
        Hide
        Phabricator added a comment -

        mareksapotafb requested code review of "HIVE-2647 [jira] Force Bash shell on parallel test slave nodes".
        Reviewers: JIRA

        Forcing Bash on each remote command call.

        Force use of Bash shell, so user default shell choice doesn't impact the test script.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D771

        AFFECTED FILES
        testutils/ptest/Report.py
        testutils/ptest/Ssh.py
        testutils/ptest/hivetest.py

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/1647/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - mareksapotafb requested code review of " HIVE-2647 [jira] Force Bash shell on parallel test slave nodes". Reviewers: JIRA Forcing Bash on each remote command call. Force use of Bash shell, so user default shell choice doesn't impact the test script. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D771 AFFECTED FILES testutils/ptest/Report.py testutils/ptest/Ssh.py testutils/ptest/hivetest.py MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/1647/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        mareksapotafb has added reviewers to the revision "HIVE-2647 [jira] Force Bash shell on parallel test slave nodes".
        Added Reviewers: jsichi

        REVISION DETAIL
        https://reviews.facebook.net/D771

        Show
        Phabricator added a comment - mareksapotafb has added reviewers to the revision " HIVE-2647 [jira] Force Bash shell on parallel test slave nodes". Added Reviewers: jsichi REVISION DETAIL https://reviews.facebook.net/D771
        Hide
        Phabricator added a comment -

        jsichi has accepted the revision "HIVE-2647 [jira] Force Bash shell on parallel test slave nodes".

        +1, committing to trunk.

        REVISION DETAIL
        https://reviews.facebook.net/D771

        Show
        Phabricator added a comment - jsichi has accepted the revision " HIVE-2647 [jira] Force Bash shell on parallel test slave nodes". +1, committing to trunk. REVISION DETAIL https://reviews.facebook.net/D771
        Hide
        John Sichi added a comment -

        Committed to trunk, thanks Marek!

        Show
        John Sichi added a comment - Committed to trunk, thanks Marek!
        Hide
        Phabricator added a comment -

        mareksapotafb has committed the revision "HIVE-2647 [jira] Force Bash shell on parallel test slave nodes".

        REVISION DETAIL
        https://reviews.facebook.net/D771

        COMMIT
        https://reviews.facebook.net/rHIVE1213460

        Show
        Phabricator added a comment - mareksapotafb has committed the revision " HIVE-2647 [jira] Force Bash shell on parallel test slave nodes". REVISION DETAIL https://reviews.facebook.net/D771 COMMIT https://reviews.facebook.net/rHIVE1213460
        Hide
        Phabricator added a comment -

        mareksapotafb has added reviewers to the revision "HIVE-2647 [jira] Parallel tests fail if master directory is not present".
        Added Reviewers: jsichi

        REVISION DETAIL
        https://reviews.facebook.net/D801

        Show
        Phabricator added a comment - mareksapotafb has added reviewers to the revision " HIVE-2647 [jira] Parallel tests fail if master directory is not present". Added Reviewers: jsichi REVISION DETAIL https://reviews.facebook.net/D801
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.23.0 #18 (See https://builds.apache.org/job/Hive-trunk-h0.23.0/18/)
        HIVE-2647 [jira] Force Bash shell on parallel test slave nodes
        (Marek Sapota via John Sichi)

        Summary:
        Forcing Bash on each remote command call.

        Force use of Bash shell, so user default shell choice doesn't impact the test
        script.

        Test Plan: EMPTY

        Reviewers: JIRA, jsichi, njain

        Reviewed By: jsichi

        CC: mareksapotafb, jsichi

        Differential Revision: 771

        jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213460
        Files :

        • /hive/trunk/testutils/ptest/Ssh.py
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.23.0 #18 (See https://builds.apache.org/job/Hive-trunk-h0.23.0/18/ ) HIVE-2647 [jira] Force Bash shell on parallel test slave nodes (Marek Sapota via John Sichi) Summary: Forcing Bash on each remote command call. Force use of Bash shell, so user default shell choice doesn't impact the test script. Test Plan: EMPTY Reviewers: JIRA, jsichi, njain Reviewed By: jsichi CC: mareksapotafb, jsichi Differential Revision: 771 jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213460 Files : /hive/trunk/testutils/ptest/Ssh.py
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1142 (See https://builds.apache.org/job/Hive-trunk-h0.21/1142/)
        HIVE-2647 [jira] Force Bash shell on parallel test slave nodes
        (Marek Sapota via John Sichi)

        Summary:
        Forcing Bash on each remote command call.

        Force use of Bash shell, so user default shell choice doesn't impact the test
        script.

        Test Plan: EMPTY

        Reviewers: JIRA, jsichi, njain

        Reviewed By: jsichi

        CC: mareksapotafb, jsichi

        Differential Revision: 771

        jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213460
        Files :

        • /hive/trunk/testutils/ptest/Ssh.py
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1142 (See https://builds.apache.org/job/Hive-trunk-h0.21/1142/ ) HIVE-2647 [jira] Force Bash shell on parallel test slave nodes (Marek Sapota via John Sichi) Summary: Forcing Bash on each remote command call. Force use of Bash shell, so user default shell choice doesn't impact the test script. Test Plan: EMPTY Reviewers: JIRA, jsichi, njain Reviewed By: jsichi CC: mareksapotafb, jsichi Differential Revision: 771 jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213460 Files : /hive/trunk/testutils/ptest/Ssh.py
        Hide
        Ashutosh Chauhan added a comment -

        This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

        Show
        Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

          People

          • Assignee:
            Marek Sapota
            Reporter:
            Marek Sapota
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development