cwsteinbach has requested changes to the revision "
HIVE-2646 [jira] Hive Ivy dependencies on Hadoop should depend on jars directly, not tarballs".
testutils/hadoop:50 If $HIVE_TEST_CLASSPATH is not set we should throw an error and exit instead of using a hardcoded default classpath.
testutils/hadoop:47 I think we should change the name of this env var to something like HIVE_HADOOP_TEST_CLASSPATH in order to make it clear that we're using it with bin/hadoop.
build-common.xml:409 Let's make it possible to override this value by adding test.hadoop.bin.path=$
/testutils/hadoop to build.properties, and then reference $
build-common.xml:384 This is probably causing some test failures since some tests expect hive-contrib-.jar to *not be on the classpath. I think we should create a classpath specifically for passing to the bin/hadoop consisting of the hive jars, the hadoop jars, and relevant dependencies, and not include hive-contrib-*.jar.
build-common.xml:79 alphabetical order?
ivy/common-configurations.xml:24 Are 'hadoop20' and 'hadoop23' compile configurations? If so can we change the name to 'hadoop20.compile' and 'hadoop23.compile', and change the names of the test configurations to "hadoop20.test" and "hadoop23.test", or something that's consistent?
pdk/scripts/build-plugin.xml:36 Please define ivy.lib.default.dir and reference that instead.