Hive
  1. Hive
  2. HIVE-2640

Add alterPartition to AlterHandler interface

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Adding alterPartition to the AlterHandler interface would allow for customized functionality to be executed as part of altering a partition, much like it is already allowed for alterTable.

      Based on the name of the interface, and a comment in the AlterHandler code, it looks like alterPartition was meant to be included along with alterTable.

        Activity

        Hide
        Phabricator added a comment -

        kevinwilfong requested code review of "HIVE-2640 [jira] Add alterPartition to AlterHandler interface".
        Reviewers: JIRA

        Added alterPartition to the AlterHandler interface. Moved the implementation of the alter_partition_core method in HMSHandler into HiveAlterHandler's implementation of the method.

        Adding alterPartition to the AlterHandler interface would allow for customized functionality to be executed as part of altering a partition, much like it is already allowed for alterTable.

        Based on the name of the interface, and a comment in the AlterHandler code, it looks like alterPartition was meant to be included along with alterTable.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D699

        AFFECTED FILES
        metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java
        metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/1539/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - kevinwilfong requested code review of " HIVE-2640 [jira] Add alterPartition to AlterHandler interface". Reviewers: JIRA Added alterPartition to the AlterHandler interface. Moved the implementation of the alter_partition_core method in HMSHandler into HiveAlterHandler's implementation of the method. Adding alterPartition to the AlterHandler interface would allow for customized functionality to be executed as part of altering a partition, much like it is already allowed for alterTable. Based on the name of the interface, and a comment in the AlterHandler code, it looks like alterPartition was meant to be included along with alterTable. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D699 AFFECTED FILES metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/1539/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        njain has accepted the revision "HIVE-2640 [jira] Add alterPartition to AlterHandler interface".

        REVISION DETAIL
        https://reviews.facebook.net/D699

        Show
        Phabricator added a comment - njain has accepted the revision " HIVE-2640 [jira] Add alterPartition to AlterHandler interface". REVISION DETAIL https://reviews.facebook.net/D699
        Hide
        Namit Jain added a comment -

        Can you refresh ? Applying the patch fails

        Show
        Namit Jain added a comment - Can you refresh ? Applying the patch fails
        Hide
        Phabricator added a comment -

        kevinwilfong updated the revision "HIVE-2640 [jira] Add alterPartition to AlterHandler interface".
        Reviewers: JIRA, njain

        Updated to address report of merge conflicts.

        REVISION DETAIL
        https://reviews.facebook.net/D699

        AFFECTED FILES
        metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java
        metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java

        Show
        Phabricator added a comment - kevinwilfong updated the revision " HIVE-2640 [jira] Add alterPartition to AlterHandler interface". Reviewers: JIRA, njain Updated to address report of merge conflicts. REVISION DETAIL https://reviews.facebook.net/D699 AFFECTED FILES metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
        Hide
        Namit Jain added a comment -

        +1

        Show
        Namit Jain added a comment - +1
        Hide
        Namit Jain added a comment -

        Committed. Thanks Kevin

        Show
        Namit Jain added a comment - Committed. Thanks Kevin
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.23.0 #23 (See https://builds.apache.org/job/Hive-trunk-h0.23.0/23/)
        HIVE-2640 Add alterPartition to AlterHandler interface
        (Kevin Wilfong via namit)

        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214380
        Files :

        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java
        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.23.0 #23 (See https://builds.apache.org/job/Hive-trunk-h0.23.0/23/ ) HIVE-2640 Add alterPartition to AlterHandler interface (Kevin Wilfong via namit) namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214380 Files : /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1146 (See https://builds.apache.org/job/Hive-trunk-h0.21/1146/)
        HIVE-2640 Add alterPartition to AlterHandler interface
        (Kevin Wilfong via namit)

        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214380
        Files :

        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java
        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1146 (See https://builds.apache.org/job/Hive-trunk-h0.21/1146/ ) HIVE-2640 Add alterPartition to AlterHandler interface (Kevin Wilfong via namit) namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214380 Files : /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        Hide
        Ashutosh Chauhan added a comment -

        This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

        Show
        Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.
        Hide
        Phabricator added a comment -

        kevinwilfong has closed the revision "HIVE-2640 [jira] Add alterPartition to AlterHandler interface".

        REVISION DETAIL
        https://reviews.facebook.net/D699

        To: JIRA, njain, kevinwilfong
        Cc: heyongqiang, njain

        Show
        Phabricator added a comment - kevinwilfong has closed the revision " HIVE-2640 [jira] Add alterPartition to AlterHandler interface". REVISION DETAIL https://reviews.facebook.net/D699 To: JIRA, njain, kevinwilfong Cc: heyongqiang, njain

          People

          • Assignee:
            Kevin Wilfong
            Reporter:
            Kevin Wilfong
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development