Hive
  1. Hive
  2. HIVE-2631

Make Hive work with Hadoop 1.0.0

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.1, 0.9.0
    • Component/s: Shims
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      With Hadoop 1.0.0 around the corner ( http://mail-archives.apache.org/mod_mbox/hadoop-general/201111.mbox/%3C9D6B6144-F4E0-4A31-883F-2AC504727A1F%40hortonworks.com%3E ), it will be useful to make Hive work with it.

      1. hive-2631.patch
        1 kB
        Ashutosh Chauhan

        Activity

        Ashutosh Chauhan created issue -
        Hide
        Ashutosh Chauhan added a comment -

        Since its merely a name change for hadoop and not a code change, This is a superficial change required only because Hive explicitly checks for Hadoop version number.

        Show
        Ashutosh Chauhan added a comment - Since its merely a name change for hadoop and not a code change, This is a superficial change required only because Hive explicitly checks for Hadoop version number.
        Ashutosh Chauhan made changes -
        Field Original Value New Value
        Attachment hive-2631.patch [ 12506366 ]
        Hide
        Ashutosh Chauhan added a comment -

        Marking ready for review.

        Show
        Ashutosh Chauhan added a comment - Marking ready for review.
        Ashutosh Chauhan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.8.0 [ 12316178 ]
        Affects Version/s 0.9.0 [ 12317742 ]
        Hide
        Ashutosh Chauhan added a comment -

        All the unit tests passed. Since, its a straight forward patch will commit unless some one has an objection.

        Show
        Ashutosh Chauhan added a comment - All the unit tests passed. Since, its a straight forward patch will commit unless some one has an objection.
        Hide
        Carl Steinbach added a comment -

        +1. Will commit if tests pass.

        Since, its a straight forward patch will commit unless some one has an objection.

        Hive committers are not allowed to commit their own patches, right?

        Show
        Carl Steinbach added a comment - +1. Will commit if tests pass. Since, its a straight forward patch will commit unless some one has an objection. Hive committers are not allowed to commit their own patches, right?
        Hide
        John Sichi added a comment -

        Correct, bylaws say "one +1 from a committer who has not authored the patch followed by a Lazy approval (not counting the vote of the contributor), moving to lazy majority if a -1 is received".

        Show
        John Sichi added a comment - Correct, bylaws say "one +1 from a committer who has not authored the patch followed by a Lazy approval (not counting the vote of the contributor), moving to lazy majority if a -1 is received".
        Hide
        Alan Gates added a comment -

        FWIW, other communities with these same rules (Pig and Hadoop) interpret this to mean another committer must review a patch, but not that another committer must commit it. Once a second committer has reviewed it the original contributor is free to commit it.

        Show
        Alan Gates added a comment - FWIW, other communities with these same rules (Pig and Hadoop) interpret this to mean another committer must review a patch, but not that another committer must commit it. Once a second committer has reviewed it the original contributor is free to commit it.
        Hide
        John Sichi added a comment -

        Right, I meant the +1 vote (not the mechanics of committing).

        Show
        John Sichi added a comment - Right, I meant the +1 vote (not the mechanics of committing).
        Hide
        Ashutosh Chauhan added a comment -

        +1. Will commit if tests pass.

        Carl, did tests pass ?

        Show
        Ashutosh Chauhan added a comment - +1. Will commit if tests pass. Carl, did tests pass ?
        Hide
        Carl Steinbach added a comment -

        Committed to trunk. Thanks Ashutosh!

        Show
        Carl Steinbach added a comment - Committed to trunk. Thanks Ashutosh!
        Carl Steinbach made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.9.0 [ 12317742 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.23.0 #32 (See https://builds.apache.org/job/Hive-trunk-h0.23.0/32/)
        HIVE-2631. Make Hive work with Hadoop 1.0.0 (Ashutosh Chauhan via cws)

        cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1215279
        Files :

        • /hive/trunk/bin/hive
        • /hive/trunk/shims/src/common/java/org/apache/hadoop/hive/shims/ShimLoader.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.23.0 #32 (See https://builds.apache.org/job/Hive-trunk-h0.23.0/32/ ) HIVE-2631 . Make Hive work with Hadoop 1.0.0 (Ashutosh Chauhan via cws) cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1215279 Files : /hive/trunk/bin/hive /hive/trunk/shims/src/common/java/org/apache/hadoop/hive/shims/ShimLoader.java
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1154 (See https://builds.apache.org/job/Hive-trunk-h0.21/1154/)
        HIVE-2631. Make Hive work with Hadoop 1.0.0 (Ashutosh Chauhan via cws)

        cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1215279
        Files :

        • /hive/trunk/bin/hive
        • /hive/trunk/shims/src/common/java/org/apache/hadoop/hive/shims/ShimLoader.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1154 (See https://builds.apache.org/job/Hive-trunk-h0.21/1154/ ) HIVE-2631 . Make Hive work with Hadoop 1.0.0 (Ashutosh Chauhan via cws) cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1215279 Files : /hive/trunk/bin/hive /hive/trunk/shims/src/common/java/org/apache/hadoop/hive/shims/ShimLoader.java
        Hide
        Carl Steinbach added a comment -

        Backported to 0.8.1

        Show
        Carl Steinbach added a comment - Backported to 0.8.1
        Carl Steinbach made changes -
        Fix Version/s 0.8.1 [ 12319268 ]
        Hide
        Ashutosh Chauhan added a comment -

        This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

        Show
        Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.
        Ashutosh Chauhan made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Ashutosh Chauhan
            Reporter:
            Ashutosh Chauhan
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development