Hive
  1. Hive
  2. HIVE-2611

Make index table output of create index command if index is table based

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Indexing
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If an index is table based, when that index is created a table is created to contain that index. This should be listed in the output of the command.

      1. ASF.LICENSE.NOT.GRANTED--HIVE-2611.D705.1.patch
        2.89 MB
        Phabricator
      2. ASF.LICENSE.NOT.GRANTED--HIVE-2611.D705.2.patch
        2.89 MB
        Phabricator
      3. ASF.LICENSE.NOT.GRANTED--HIVE-2611.D705.3.patch
        2.89 MB
        Phabricator
      4. HIVE-2611.1.patch.txt
        2.89 MB
        Kevin Wilfong

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2953/
        -----------------------------------------------------------

        Review request for hive, Yongqiang He and namit jain.

        Summary
        -------

        If an index is table based, when an index is created it creates a table for that index. We should log that table as the output of an index creation command.

        This addresses bug HIVE-2611.
        https://issues.apache.org/jira/browse/HIVE-2611

        Diffs


        trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1207723
        trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1207723
        trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1207723
        trunk/ql/src/test/results/clientnegative/alter_concatenate_indexed_table.q.out 1207723
        trunk/ql/src/test/results/clientnegative/index_bitmap_no_map_aggr.q.out 1207723
        trunk/ql/src/test/results/clientnegative/index_compact_entry_limit.q.out 1207723
        trunk/ql/src/test/results/clientnegative/index_compact_size_limit.q.out 1207723
        trunk/ql/src/test/results/clientnegative/merge_negative_1.q.out 1207723
        trunk/ql/src/test/results/clientpositive/alter_concatenate_indexed_table.q.out 1207723
        trunk/ql/src/test/results/clientpositive/alter_index.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_auth.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_auto.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_auto_empty.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_auto_file_format.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_auto_mult_tables.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_auto_multiple.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_auto_partitioned.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_auto_self_join.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_auto_unused.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_auto_update.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_bitmap.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_bitmap1.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_bitmap2.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_bitmap3.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_bitmap_auto.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_bitmap_compression.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_bitmap_rc.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_compact.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_compact_1.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_compact_2.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_compact_3.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_compact_binary_search.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_compression.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_creation.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_stale.q.out 1207723
        trunk/ql/src/test/results/clientpositive/index_stale_partitioned.q.out 1207723
        trunk/ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 1207723
        trunk/ql/src/test/results/clientpositive/show_indexes_edge_cases.q.out 1207723
        trunk/ql/src/test/results/clientpositive/show_indexes_syntax.q.out 1207723

        Diff: https://reviews.apache.org/r/2953/diff

        Testing
        -------

        Verified that the output of a create index command is now the index table.

        Ran the unit tests.

        Thanks,

        Kevin

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2953/ ----------------------------------------------------------- Review request for hive, Yongqiang He and namit jain. Summary ------- If an index is table based, when an index is created it creates a table for that index. We should log that table as the output of an index creation command. This addresses bug HIVE-2611 . https://issues.apache.org/jira/browse/HIVE-2611 Diffs trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1207723 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1207723 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1207723 trunk/ql/src/test/results/clientnegative/alter_concatenate_indexed_table.q.out 1207723 trunk/ql/src/test/results/clientnegative/index_bitmap_no_map_aggr.q.out 1207723 trunk/ql/src/test/results/clientnegative/index_compact_entry_limit.q.out 1207723 trunk/ql/src/test/results/clientnegative/index_compact_size_limit.q.out 1207723 trunk/ql/src/test/results/clientnegative/merge_negative_1.q.out 1207723 trunk/ql/src/test/results/clientpositive/alter_concatenate_indexed_table.q.out 1207723 trunk/ql/src/test/results/clientpositive/alter_index.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_auth.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_auto.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_auto_empty.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_auto_file_format.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_auto_mult_tables.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_auto_multiple.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_auto_partitioned.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_auto_self_join.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_auto_unused.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_auto_update.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_bitmap.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_bitmap1.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_bitmap2.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_bitmap3.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_bitmap_auto.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_bitmap_compression.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_bitmap_rc.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_compact.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_compact_1.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_compact_2.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_compact_3.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_compact_binary_search.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_compression.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_creation.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_stale.q.out 1207723 trunk/ql/src/test/results/clientpositive/index_stale_partitioned.q.out 1207723 trunk/ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 1207723 trunk/ql/src/test/results/clientpositive/show_indexes_edge_cases.q.out 1207723 trunk/ql/src/test/results/clientpositive/show_indexes_syntax.q.out 1207723 Diff: https://reviews.apache.org/r/2953/diff Testing ------- Verified that the output of a create index command is now the index table. Ran the unit tests. Thanks, Kevin
        Hide
        Namit Jain added a comment -

        Kevin, can you use phabricator to submit a diff ?

        Show
        Namit Jain added a comment - Kevin, can you use phabricator to submit a diff ?
        Show
        Namit Jain added a comment - https://cwiki.apache.org/Hive/phabricatorcodereview.html
        Hide
        Namit Jain added a comment -

        +1

        Show
        Namit Jain added a comment - +1
        Hide
        Phabricator added a comment -

        kevinwilfong requested code review of "HIVE-2611 [jira] Make index table output of create index command if index is table based".
        Reviewers: JIRA

        If an index is table based, when an index is created it creates a table for that index. We should log that table as the output of an index creation command.

        This differs from the review board diff only in that the Lint errors have been resolved.

        If an index is table based, when that index is created a table is created to contain that index. This should be listed in the output of the command.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D705

        AFFECTED FILES
        ql/src/test/results/clientnegative/alter_concatenate_indexed_table.q.out
        ql/src/test/results/clientnegative/index_compact_size_limit.q.out
        ql/src/test/results/clientnegative/merge_negative_1.q.out
        ql/src/test/results/clientnegative/index_bitmap_no_map_aggr.q.out
        ql/src/test/results/clientnegative/index_compact_entry_limit.q.out
        ql/src/test/results/clientpositive/index_bitmap3.q.out
        ql/src/test/results/clientpositive/index_auto_update.q.out
        ql/src/test/results/clientpositive/index_auto_partitioned.q.out
        ql/src/test/results/clientpositive/index_auto_file_format.q.out
        ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out
        ql/src/test/results/clientpositive/show_indexes_syntax.q.out
        ql/src/test/results/clientpositive/index_bitmap_rc.q.out
        ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out
        ql/src/test/results/clientpositive/index_auto_unused.q.out
        ql/src/test/results/clientpositive/index_auto.q.out
        ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out
        ql/src/test/results/clientpositive/show_indexes_edge_cases.q.out
        ql/src/test/results/clientpositive/alter_concatenate_indexed_table.q.out
        ql/src/test/results/clientpositive/index_compact_1.q.out
        ql/src/test/results/clientpositive/index_compact.q.out
        ql/src/test/results/clientpositive/alter_index.q.out
        ql/src/test/results/clientpositive/index_compact_binary_search.q.out
        ql/src/test/results/clientpositive/index_stale_partitioned.q.out
        ql/src/test/results/clientpositive/index_auto_self_join.q.out
        ql/src/test/results/clientpositive/index_creation.q.out
        ql/src/test/results/clientpositive/index_bitmap1.q.out
        ql/src/test/results/clientpositive/index_bitmap_compression.q.out
        ql/src/test/results/clientpositive/index_compact_2.q.out
        ql/src/test/results/clientpositive/index_auto_mult_tables.q.out
        ql/src/test/results/clientpositive/index_stale.q.out
        ql/src/test/results/clientpositive/index_bitmap.q.out
        ql/src/test/results/clientpositive/index_bitmap2.q.out
        ql/src/test/results/clientpositive/index_bitmap_auto.q.out
        ql/src/test/results/clientpositive/index_auto_empty.q.out
        ql/src/test/results/clientpositive/index_compact_3.q.out
        ql/src/test/results/clientpositive/index_auto_multiple.q.out
        ql/src/test/results/clientpositive/index_auth.q.out
        ql/src/test/results/clientpositive/index_compression.q.out
        ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
        ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java
        ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/1545/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - kevinwilfong requested code review of " HIVE-2611 [jira] Make index table output of create index command if index is table based". Reviewers: JIRA If an index is table based, when an index is created it creates a table for that index. We should log that table as the output of an index creation command. This differs from the review board diff only in that the Lint errors have been resolved. If an index is table based, when that index is created a table is created to contain that index. This should be listed in the output of the command. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D705 AFFECTED FILES ql/src/test/results/clientnegative/alter_concatenate_indexed_table.q.out ql/src/test/results/clientnegative/index_compact_size_limit.q.out ql/src/test/results/clientnegative/merge_negative_1.q.out ql/src/test/results/clientnegative/index_bitmap_no_map_aggr.q.out ql/src/test/results/clientnegative/index_compact_entry_limit.q.out ql/src/test/results/clientpositive/index_bitmap3.q.out ql/src/test/results/clientpositive/index_auto_update.q.out ql/src/test/results/clientpositive/index_auto_partitioned.q.out ql/src/test/results/clientpositive/index_auto_file_format.q.out ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out ql/src/test/results/clientpositive/show_indexes_syntax.q.out ql/src/test/results/clientpositive/index_bitmap_rc.q.out ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out ql/src/test/results/clientpositive/index_auto_unused.q.out ql/src/test/results/clientpositive/index_auto.q.out ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out ql/src/test/results/clientpositive/show_indexes_edge_cases.q.out ql/src/test/results/clientpositive/alter_concatenate_indexed_table.q.out ql/src/test/results/clientpositive/index_compact_1.q.out ql/src/test/results/clientpositive/index_compact.q.out ql/src/test/results/clientpositive/alter_index.q.out ql/src/test/results/clientpositive/index_compact_binary_search.q.out ql/src/test/results/clientpositive/index_stale_partitioned.q.out ql/src/test/results/clientpositive/index_auto_self_join.q.out ql/src/test/results/clientpositive/index_creation.q.out ql/src/test/results/clientpositive/index_bitmap1.q.out ql/src/test/results/clientpositive/index_bitmap_compression.q.out ql/src/test/results/clientpositive/index_compact_2.q.out ql/src/test/results/clientpositive/index_auto_mult_tables.q.out ql/src/test/results/clientpositive/index_stale.q.out ql/src/test/results/clientpositive/index_bitmap.q.out ql/src/test/results/clientpositive/index_bitmap2.q.out ql/src/test/results/clientpositive/index_bitmap_auto.q.out ql/src/test/results/clientpositive/index_auto_empty.q.out ql/src/test/results/clientpositive/index_compact_3.q.out ql/src/test/results/clientpositive/index_auto_multiple.q.out ql/src/test/results/clientpositive/index_auth.q.out ql/src/test/results/clientpositive/index_compression.q.out ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/1545/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        kevinwilfong updated the revision "HIVE-2611 [jira] Make index table output of create index command if index is table based".
        Reviewers: JIRA

        REVISION DETAIL
        https://reviews.facebook.net/D705

        AFFECTED FILES
        ql/src/test/results/clientnegative/alter_concatenate_indexed_table.q.out
        ql/src/test/results/clientnegative/index_compact_size_limit.q.out
        ql/src/test/results/clientnegative/merge_negative_1.q.out
        ql/src/test/results/clientnegative/index_bitmap_no_map_aggr.q.out
        ql/src/test/results/clientnegative/index_compact_entry_limit.q.out
        ql/src/test/results/clientpositive/index_bitmap3.q.out
        ql/src/test/results/clientpositive/index_auto_update.q.out
        ql/src/test/results/clientpositive/index_auto_partitioned.q.out
        ql/src/test/results/clientpositive/index_auto_file_format.q.out
        ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out
        ql/src/test/results/clientpositive/show_indexes_syntax.q.out
        ql/src/test/results/clientpositive/index_bitmap_rc.q.out
        ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out
        ql/src/test/results/clientpositive/index_auto_unused.q.out
        ql/src/test/results/clientpositive/index_auto.q.out
        ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out
        ql/src/test/results/clientpositive/show_indexes_edge_cases.q.out
        ql/src/test/results/clientpositive/alter_concatenate_indexed_table.q.out
        ql/src/test/results/clientpositive/index_compact_1.q.out
        ql/src/test/results/clientpositive/index_compact.q.out
        ql/src/test/results/clientpositive/alter_index.q.out
        ql/src/test/results/clientpositive/index_compact_binary_search.q.out
        ql/src/test/results/clientpositive/index_stale_partitioned.q.out
        ql/src/test/results/clientpositive/index_auto_self_join.q.out
        ql/src/test/results/clientpositive/index_creation.q.out
        ql/src/test/results/clientpositive/index_bitmap1.q.out
        ql/src/test/results/clientpositive/index_bitmap_compression.q.out
        ql/src/test/results/clientpositive/index_compact_2.q.out
        ql/src/test/results/clientpositive/index_auto_mult_tables.q.out
        ql/src/test/results/clientpositive/index_stale.q.out
        ql/src/test/results/clientpositive/index_bitmap.q.out
        ql/src/test/results/clientpositive/index_bitmap2.q.out
        ql/src/test/results/clientpositive/index_bitmap_auto.q.out
        ql/src/test/results/clientpositive/index_auto_empty.q.out
        ql/src/test/results/clientpositive/index_compact_3.q.out
        ql/src/test/results/clientpositive/index_auto_multiple.q.out
        ql/src/test/results/clientpositive/index_auth.q.out
        ql/src/test/results/clientpositive/index_compression.q.out
        ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
        ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java
        ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java

        Show
        Phabricator added a comment - kevinwilfong updated the revision " HIVE-2611 [jira] Make index table output of create index command if index is table based". Reviewers: JIRA REVISION DETAIL https://reviews.facebook.net/D705 AFFECTED FILES ql/src/test/results/clientnegative/alter_concatenate_indexed_table.q.out ql/src/test/results/clientnegative/index_compact_size_limit.q.out ql/src/test/results/clientnegative/merge_negative_1.q.out ql/src/test/results/clientnegative/index_bitmap_no_map_aggr.q.out ql/src/test/results/clientnegative/index_compact_entry_limit.q.out ql/src/test/results/clientpositive/index_bitmap3.q.out ql/src/test/results/clientpositive/index_auto_update.q.out ql/src/test/results/clientpositive/index_auto_partitioned.q.out ql/src/test/results/clientpositive/index_auto_file_format.q.out ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out ql/src/test/results/clientpositive/show_indexes_syntax.q.out ql/src/test/results/clientpositive/index_bitmap_rc.q.out ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out ql/src/test/results/clientpositive/index_auto_unused.q.out ql/src/test/results/clientpositive/index_auto.q.out ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out ql/src/test/results/clientpositive/show_indexes_edge_cases.q.out ql/src/test/results/clientpositive/alter_concatenate_indexed_table.q.out ql/src/test/results/clientpositive/index_compact_1.q.out ql/src/test/results/clientpositive/index_compact.q.out ql/src/test/results/clientpositive/alter_index.q.out ql/src/test/results/clientpositive/index_compact_binary_search.q.out ql/src/test/results/clientpositive/index_stale_partitioned.q.out ql/src/test/results/clientpositive/index_auto_self_join.q.out ql/src/test/results/clientpositive/index_creation.q.out ql/src/test/results/clientpositive/index_bitmap1.q.out ql/src/test/results/clientpositive/index_bitmap_compression.q.out ql/src/test/results/clientpositive/index_compact_2.q.out ql/src/test/results/clientpositive/index_auto_mult_tables.q.out ql/src/test/results/clientpositive/index_stale.q.out ql/src/test/results/clientpositive/index_bitmap.q.out ql/src/test/results/clientpositive/index_bitmap2.q.out ql/src/test/results/clientpositive/index_bitmap_auto.q.out ql/src/test/results/clientpositive/index_auto_empty.q.out ql/src/test/results/clientpositive/index_compact_3.q.out ql/src/test/results/clientpositive/index_auto_multiple.q.out ql/src/test/results/clientpositive/index_auth.q.out ql/src/test/results/clientpositive/index_compression.q.out ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
        Hide
        Namit Jain added a comment -

        Can you refresh ?
        I am getting some merge conflicts

        Show
        Namit Jain added a comment - Can you refresh ? I am getting some merge conflicts
        Hide
        Phabricator added a comment -

        kevinwilfong has commented on the revision "HIVE-2611 [jira] Make index table output of create index command if index is table based".

        The last update was to address the report of a merge conflict.

        REVISION DETAIL
        https://reviews.facebook.net/D705

        Show
        Phabricator added a comment - kevinwilfong has commented on the revision " HIVE-2611 [jira] Make index table output of create index command if index is table based". The last update was to address the report of a merge conflict. REVISION DETAIL https://reviews.facebook.net/D705
        Hide
        Phabricator added a comment -

        kevinwilfong updated the revision "HIVE-2611 [jira] Make index table output of create index command if index is table based".
        Reviewers: JIRA

        REVISION DETAIL
        https://reviews.facebook.net/D705

        AFFECTED FILES
        ql/src/test/results/clientnegative/alter_concatenate_indexed_table.q.out
        ql/src/test/results/clientnegative/index_compact_size_limit.q.out
        ql/src/test/results/clientnegative/merge_negative_1.q.out
        ql/src/test/results/clientnegative/index_bitmap_no_map_aggr.q.out
        ql/src/test/results/clientnegative/index_compact_entry_limit.q.out
        ql/src/test/results/clientpositive/index_bitmap3.q.out
        ql/src/test/results/clientpositive/index_auto_update.q.out
        ql/src/test/results/clientpositive/index_auto_partitioned.q.out
        ql/src/test/results/clientpositive/index_auto_file_format.q.out
        ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out
        ql/src/test/results/clientpositive/show_indexes_syntax.q.out
        ql/src/test/results/clientpositive/index_bitmap_rc.q.out
        ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out
        ql/src/test/results/clientpositive/index_auto_unused.q.out
        ql/src/test/results/clientpositive/index_auto.q.out
        ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out
        ql/src/test/results/clientpositive/show_indexes_edge_cases.q.out
        ql/src/test/results/clientpositive/alter_concatenate_indexed_table.q.out
        ql/src/test/results/clientpositive/index_compact_1.q.out
        ql/src/test/results/clientpositive/index_compact.q.out
        ql/src/test/results/clientpositive/alter_index.q.out
        ql/src/test/results/clientpositive/index_compact_binary_search.q.out
        ql/src/test/results/clientpositive/index_stale_partitioned.q.out
        ql/src/test/results/clientpositive/index_auto_self_join.q.out
        ql/src/test/results/clientpositive/index_creation.q.out
        ql/src/test/results/clientpositive/index_bitmap1.q.out
        ql/src/test/results/clientpositive/index_bitmap_compression.q.out
        ql/src/test/results/clientpositive/index_compact_2.q.out
        ql/src/test/results/clientpositive/index_auto_mult_tables.q.out
        ql/src/test/results/clientpositive/index_stale.q.out
        ql/src/test/results/clientpositive/index_bitmap.q.out
        ql/src/test/results/clientpositive/index_bitmap2.q.out
        ql/src/test/results/clientpositive/index_bitmap_auto.q.out
        ql/src/test/results/clientpositive/index_auto_empty.q.out
        ql/src/test/results/clientpositive/index_compact_3.q.out
        ql/src/test/results/clientpositive/index_auto_multiple.q.out
        ql/src/test/results/clientpositive/index_auth.q.out
        ql/src/test/results/clientpositive/index_compression.q.out
        ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
        ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java
        ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java

        Show
        Phabricator added a comment - kevinwilfong updated the revision " HIVE-2611 [jira] Make index table output of create index command if index is table based". Reviewers: JIRA REVISION DETAIL https://reviews.facebook.net/D705 AFFECTED FILES ql/src/test/results/clientnegative/alter_concatenate_indexed_table.q.out ql/src/test/results/clientnegative/index_compact_size_limit.q.out ql/src/test/results/clientnegative/merge_negative_1.q.out ql/src/test/results/clientnegative/index_bitmap_no_map_aggr.q.out ql/src/test/results/clientnegative/index_compact_entry_limit.q.out ql/src/test/results/clientpositive/index_bitmap3.q.out ql/src/test/results/clientpositive/index_auto_update.q.out ql/src/test/results/clientpositive/index_auto_partitioned.q.out ql/src/test/results/clientpositive/index_auto_file_format.q.out ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out ql/src/test/results/clientpositive/show_indexes_syntax.q.out ql/src/test/results/clientpositive/index_bitmap_rc.q.out ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out ql/src/test/results/clientpositive/index_auto_unused.q.out ql/src/test/results/clientpositive/index_auto.q.out ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out ql/src/test/results/clientpositive/show_indexes_edge_cases.q.out ql/src/test/results/clientpositive/alter_concatenate_indexed_table.q.out ql/src/test/results/clientpositive/index_compact_1.q.out ql/src/test/results/clientpositive/index_compact.q.out ql/src/test/results/clientpositive/alter_index.q.out ql/src/test/results/clientpositive/index_compact_binary_search.q.out ql/src/test/results/clientpositive/index_stale_partitioned.q.out ql/src/test/results/clientpositive/index_auto_self_join.q.out ql/src/test/results/clientpositive/index_creation.q.out ql/src/test/results/clientpositive/index_bitmap1.q.out ql/src/test/results/clientpositive/index_bitmap_compression.q.out ql/src/test/results/clientpositive/index_compact_2.q.out ql/src/test/results/clientpositive/index_auto_mult_tables.q.out ql/src/test/results/clientpositive/index_stale.q.out ql/src/test/results/clientpositive/index_bitmap.q.out ql/src/test/results/clientpositive/index_bitmap2.q.out ql/src/test/results/clientpositive/index_bitmap_auto.q.out ql/src/test/results/clientpositive/index_auto_empty.q.out ql/src/test/results/clientpositive/index_compact_3.q.out ql/src/test/results/clientpositive/index_auto_multiple.q.out ql/src/test/results/clientpositive/index_auth.q.out ql/src/test/results/clientpositive/index_compression.q.out ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
        Hide
        Namit Jain added a comment -

        +1

        Show
        Namit Jain added a comment - +1
        Hide
        Namit Jain added a comment -

        Committed. Thanks Kevin

        Show
        Namit Jain added a comment - Committed. Thanks Kevin
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.23.0 #25 (See https://builds.apache.org/job/Hive-trunk-h0.23.0/25/)
        HIVE-2611 Make index table output of create index command if
        index is table based (Kevin Wilfong via namit)

        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214622
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java
        • /hive/trunk/ql/src/test/results/clientnegative/alter_concatenate_indexed_table.q.out
        • /hive/trunk/ql/src/test/results/clientnegative/index_bitmap_no_map_aggr.q.out
        • /hive/trunk/ql/src/test/results/clientnegative/index_compact_entry_limit.q.out
        • /hive/trunk/ql/src/test/results/clientnegative/index_compact_size_limit.q.out
        • /hive/trunk/ql/src/test/results/clientnegative/merge_negative_1.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/alter_concatenate_indexed_table.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/alter_index.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auth.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_empty.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_file_format.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_mult_tables.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_multiple.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_partitioned.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_self_join.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_unused.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_update.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_bitmap.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_bitmap1.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_bitmap2.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_bitmap3.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_auto.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_compression.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_rc.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_compact.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_compact_1.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_compact_2.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_compact_3.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_compact_binary_search.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_compression.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_creation.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_stale.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_stale_partitioned.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/show_indexes_edge_cases.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/show_indexes_syntax.q.out
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.23.0 #25 (See https://builds.apache.org/job/Hive-trunk-h0.23.0/25/ ) HIVE-2611 Make index table output of create index command if index is table based (Kevin Wilfong via namit) namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214622 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java /hive/trunk/ql/src/test/results/clientnegative/alter_concatenate_indexed_table.q.out /hive/trunk/ql/src/test/results/clientnegative/index_bitmap_no_map_aggr.q.out /hive/trunk/ql/src/test/results/clientnegative/index_compact_entry_limit.q.out /hive/trunk/ql/src/test/results/clientnegative/index_compact_size_limit.q.out /hive/trunk/ql/src/test/results/clientnegative/merge_negative_1.q.out /hive/trunk/ql/src/test/results/clientpositive/alter_concatenate_indexed_table.q.out /hive/trunk/ql/src/test/results/clientpositive/alter_index.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auth.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_empty.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_file_format.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_mult_tables.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_multiple.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_partitioned.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_self_join.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_unused.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_update.q.out /hive/trunk/ql/src/test/results/clientpositive/index_bitmap.q.out /hive/trunk/ql/src/test/results/clientpositive/index_bitmap1.q.out /hive/trunk/ql/src/test/results/clientpositive/index_bitmap2.q.out /hive/trunk/ql/src/test/results/clientpositive/index_bitmap3.q.out /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_auto.q.out /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_compression.q.out /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_rc.q.out /hive/trunk/ql/src/test/results/clientpositive/index_compact.q.out /hive/trunk/ql/src/test/results/clientpositive/index_compact_1.q.out /hive/trunk/ql/src/test/results/clientpositive/index_compact_2.q.out /hive/trunk/ql/src/test/results/clientpositive/index_compact_3.q.out /hive/trunk/ql/src/test/results/clientpositive/index_compact_binary_search.q.out /hive/trunk/ql/src/test/results/clientpositive/index_compression.q.out /hive/trunk/ql/src/test/results/clientpositive/index_creation.q.out /hive/trunk/ql/src/test/results/clientpositive/index_stale.q.out /hive/trunk/ql/src/test/results/clientpositive/index_stale_partitioned.q.out /hive/trunk/ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out /hive/trunk/ql/src/test/results/clientpositive/show_indexes_edge_cases.q.out /hive/trunk/ql/src/test/results/clientpositive/show_indexes_syntax.q.out
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1148 (See https://builds.apache.org/job/Hive-trunk-h0.21/1148/)
        HIVE-2611 Make index table output of create index command if
        index is table based (Kevin Wilfong via namit)

        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214622
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java
        • /hive/trunk/ql/src/test/results/clientnegative/alter_concatenate_indexed_table.q.out
        • /hive/trunk/ql/src/test/results/clientnegative/index_bitmap_no_map_aggr.q.out
        • /hive/trunk/ql/src/test/results/clientnegative/index_compact_entry_limit.q.out
        • /hive/trunk/ql/src/test/results/clientnegative/index_compact_size_limit.q.out
        • /hive/trunk/ql/src/test/results/clientnegative/merge_negative_1.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/alter_concatenate_indexed_table.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/alter_index.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auth.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_empty.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_file_format.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_mult_tables.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_multiple.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_partitioned.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_self_join.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_unused.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_auto_update.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_bitmap.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_bitmap1.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_bitmap2.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_bitmap3.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_auto.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_compression.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_rc.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_compact.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_compact_1.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_compact_2.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_compact_3.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_compact_binary_search.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_compression.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_creation.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_stale.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/index_stale_partitioned.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/show_indexes_edge_cases.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/show_indexes_syntax.q.out
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1148 (See https://builds.apache.org/job/Hive-trunk-h0.21/1148/ ) HIVE-2611 Make index table output of create index command if index is table based (Kevin Wilfong via namit) namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214622 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java /hive/trunk/ql/src/test/results/clientnegative/alter_concatenate_indexed_table.q.out /hive/trunk/ql/src/test/results/clientnegative/index_bitmap_no_map_aggr.q.out /hive/trunk/ql/src/test/results/clientnegative/index_compact_entry_limit.q.out /hive/trunk/ql/src/test/results/clientnegative/index_compact_size_limit.q.out /hive/trunk/ql/src/test/results/clientnegative/merge_negative_1.q.out /hive/trunk/ql/src/test/results/clientpositive/alter_concatenate_indexed_table.q.out /hive/trunk/ql/src/test/results/clientpositive/alter_index.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auth.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_empty.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_file_format.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_mult_tables.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_multiple.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_partitioned.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_self_join.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_unused.q.out /hive/trunk/ql/src/test/results/clientpositive/index_auto_update.q.out /hive/trunk/ql/src/test/results/clientpositive/index_bitmap.q.out /hive/trunk/ql/src/test/results/clientpositive/index_bitmap1.q.out /hive/trunk/ql/src/test/results/clientpositive/index_bitmap2.q.out /hive/trunk/ql/src/test/results/clientpositive/index_bitmap3.q.out /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_auto.q.out /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_compression.q.out /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_rc.q.out /hive/trunk/ql/src/test/results/clientpositive/index_compact.q.out /hive/trunk/ql/src/test/results/clientpositive/index_compact_1.q.out /hive/trunk/ql/src/test/results/clientpositive/index_compact_2.q.out /hive/trunk/ql/src/test/results/clientpositive/index_compact_3.q.out /hive/trunk/ql/src/test/results/clientpositive/index_compact_binary_search.q.out /hive/trunk/ql/src/test/results/clientpositive/index_compression.q.out /hive/trunk/ql/src/test/results/clientpositive/index_creation.q.out /hive/trunk/ql/src/test/results/clientpositive/index_stale.q.out /hive/trunk/ql/src/test/results/clientpositive/index_stale_partitioned.q.out /hive/trunk/ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out /hive/trunk/ql/src/test/results/clientpositive/show_indexes_edge_cases.q.out /hive/trunk/ql/src/test/results/clientpositive/show_indexes_syntax.q.out
        Hide
        Ashutosh Chauhan added a comment -

        This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

        Show
        Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

          People

          • Assignee:
            Kevin Wilfong
            Reporter:
            Kevin Wilfong
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development