[HIVE-26014] Remove redundant HushableRandomAccessFileAppender

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: HiveServer2
• Assignee: Stamatis Zampetakis
• Reporter: Stamatis Zampetakis
• Created: 08/Mar/22 12:39
• Updated: 08/Mar/22 12:40

Description

HushableRandomAccessFileAppender was introduced by HIVE-17826 to avoid exceptions originating from attempts to write to a closed appender.

After the changes in HIVE-24590, the life-cycle (opening/closing/deleting) of appenders is managed by the Log4j framework and not explicitly by Hive as it used to be before. With HIVE-24590 in place, it is no longer possible to have the exception in HIVE-17826 cause appenders are opened and closed when necessary.

Due to the above, the HushableRandomAccessFileAppender is completely redundant and can be removed in favor of the RandomAccessFileAppender already provided by the Log4j framework.

Issue Links

• depends upon: HIVE-24590 Operation Logging still leaks the log4j Appenders
• relates to: HIVE-17826 Error writing to RandomAccessFile after operation log is closed