Hive
  1. Hive
  2. HIVE-2588

Update arcconfig to include commit listener

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Use CommitListener from Arc-JIRA to modify commit message and include `(author via committer)` when running `arc commit`.

        Activity

        Hide
        Phabricator added a comment -

        mareksapotafb requested code review of "HIVE-2588 [jira] Update arcconfig to include commit listener".
        Reviewers: JIRA

        Add CommitListener as an event listener.

        Use CommitListener from Arc-JIRA to modify commit message and include `(author via committer)` when running `arc commit`.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D477

        AFFECTED FILES
        .arcconfig

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/1005/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - mareksapotafb requested code review of " HIVE-2588 [jira] Update arcconfig to include commit listener". Reviewers: JIRA Add CommitListener as an event listener. Use CommitListener from Arc-JIRA to modify commit message and include `(author via committer)` when running `arc commit`. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D477 AFFECTED FILES .arcconfig MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/1005/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        jsichi has accepted the revision "HIVE-2588 [jira] Update arcconfig to include commit listener".

        REVISION DETAIL
        https://reviews.facebook.net/D477

        Show
        Phabricator added a comment - jsichi has accepted the revision " HIVE-2588 [jira] Update arcconfig to include commit listener". REVISION DETAIL https://reviews.facebook.net/D477
        Hide
        John Sichi added a comment -

        +1, committed to trunk. Thanks Marek!

        Show
        John Sichi added a comment - +1, committed to trunk. Thanks Marek!
        Hide
        Phabricator added a comment -

        mareksapotafb has committed the revision "HIVE-2588 [jira] Update arcconfig to include commit listener".

        REVISION DETAIL
        https://reviews.facebook.net/D477

        COMMIT
        https://reviews.facebook.net/rHIVE1203046

        Show
        Phabricator added a comment - mareksapotafb has committed the revision " HIVE-2588 [jira] Update arcconfig to include commit listener". REVISION DETAIL https://reviews.facebook.net/D477 COMMIT https://reviews.facebook.net/rHIVE1203046
        Hide
        Phabricator added a comment -

        jsichi has commented on the revision "HIVE-2588 [jira] Update arcconfig to include commit listener".

        comment test

        REVISION DETAIL
        https://reviews.facebook.net/D477

        COMMIT
        https://reviews.facebook.net/rHIVE1203046

        Show
        Phabricator added a comment - jsichi has commented on the revision " HIVE-2588 [jira] Update arcconfig to include commit listener". comment test REVISION DETAIL https://reviews.facebook.net/D477 COMMIT https://reviews.facebook.net/rHIVE1203046
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1093 (See https://builds.apache.org/job/Hive-trunk-h0.21/1093/)
        HIVE-2588 [jira] Update arcconfig to include commit listener
        (Marek Sapota via John Sichi)

        Summary:
        Add CommitListener as an event listener.

        Use CommitListener from Arc-JIRA to modify commit message and include `(author
        via committer)` when running `arc commit`.

        Test Plan: EMPTY

        Reviewers: JIRA, jsichi

        Reviewed By: jsichi

        CC: jsichi

        Differential Revision: 477

        jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203046
        Files :

        • /hive/trunk/.arcconfig
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1093 (See https://builds.apache.org/job/Hive-trunk-h0.21/1093/ ) HIVE-2588 [jira] Update arcconfig to include commit listener (Marek Sapota via John Sichi) Summary: Add CommitListener as an event listener. Use CommitListener from Arc-JIRA to modify commit message and include `(author via committer)` when running `arc commit`. Test Plan: EMPTY Reviewers: JIRA, jsichi Reviewed By: jsichi CC: jsichi Differential Revision: 477 jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203046 Files : /hive/trunk/.arcconfig

          People

          • Assignee:
            Marek Sapota
            Reporter:
            Marek Sapota
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development