Hive
  1. Hive
  2. HIVE-2569

Too much debugging info on console if a job failed

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Diagnosability
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When a job failed and Hive client tries to get the error message from failed task, it printed the following info on console for each task:

      Examining task ID: task_201110112120_773499_m_000037 from job job_201110112120_773499

      This should be shorten significantly.

        Activity

        Hide
        Phabricator added a comment -

        nzhang requested code review of "HIVE-2569 [jira] Too much debugging info on console if a job failed".
        Reviewers: JIRA

        Too much debugging info on console if a job failed

        When a job failed and Hive client tries to get the error message from failed task, it printed the following info on console for each task:

        Examining task ID: task_201110112120_773499_m_000037 from job job_201110112120_773499

        This should be shorten significantly.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D375

        AFFECTED FILES
        ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java
        ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/741/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - nzhang requested code review of " HIVE-2569 [jira] Too much debugging info on console if a job failed". Reviewers: JIRA Too much debugging info on console if a job failed When a job failed and Hive client tries to get the error message from failed task, it printed the following info on console for each task: Examining task ID: task_201110112120_773499_m_000037 from job job_201110112120_773499 This should be shorten significantly. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D375 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/741/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        jsichi has accepted the revision "HIVE-2569 [jira] Too much debugging info on console if a job failed".

        REVISION DETAIL
        https://reviews.facebook.net/D375

        Show
        Phabricator added a comment - jsichi has accepted the revision " HIVE-2569 [jira] Too much debugging info on console if a job failed". REVISION DETAIL https://reviews.facebook.net/D375
        Hide
        John Sichi added a comment -

        +1, will commit when tests pass.

        Show
        John Sichi added a comment - +1, will commit when tests pass.
        Hide
        John Sichi added a comment -

        Committed to trunk, thanks Ning!

        Show
        John Sichi added a comment - Committed to trunk, thanks Ning!
        Hide
        Phabricator added a comment -

        nzhang has committed the revision "HIVE-2569 [jira] Too much debugging info on console if a job failed".

        REVISION DETAIL
        https://reviews.facebook.net/D375

        COMMIT
        https://reviews.facebook.net/rHIVE1203819

        Show
        Phabricator added a comment - nzhang has committed the revision " HIVE-2569 [jira] Too much debugging info on console if a job failed". REVISION DETAIL https://reviews.facebook.net/D375 COMMIT https://reviews.facebook.net/rHIVE1203819
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1097 (See https://builds.apache.org/job/Hive-trunk-h0.21/1097/)
        HIVE-2569 [jira] Too much debugging info on console if a job failed
        (Ning Zhang via John Sichi)

        Summary:
        Too much debugging info on console if a job failed

        When a job failed and Hive client tries to get the error message from failed
        task, it printed the following info on console for each task:

        Examining task ID: task_201110112120_773499_m_000037 from job
        job_201110112120_773499

        This should be shorten significantly.

        Test Plan: EMPTY

        Reviewers: JIRA, njain, jsichi

        Reviewed By: jsichi

        CC: jsichi

        Differential Revision: 375

        jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203819
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1097 (See https://builds.apache.org/job/Hive-trunk-h0.21/1097/ ) HIVE-2569 [jira] Too much debugging info on console if a job failed (Ning Zhang via John Sichi) Summary: Too much debugging info on console if a job failed When a job failed and Hive client tries to get the error message from failed task, it printed the following info on console for each task: Examining task ID: task_201110112120_773499_m_000037 from job job_201110112120_773499 This should be shorten significantly. Test Plan: EMPTY Reviewers: JIRA, njain, jsichi Reviewed By: jsichi CC: jsichi Differential Revision: 375 jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203819 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java

          People

          • Assignee:
            Ning Zhang
            Reporter:
            Ning Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development