Hive
  1. Hive
  2. HIVE-2545

Make metastore log4j configuration file configurable again.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The patch for https://issues.apache.org/jira/browse/HIVE-2139 hard coded the metastore to use hive-log4j.properties as the log4j configuration file. Previously this was configurable through the log4j.configuration variable passed into Java. It should be configurable again, though not necessarily through the same means.

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1067 (See https://builds.apache.org/job/Hive-trunk-h0.21/1067/)
        HIVE-2545. Make metastore log4j configuration file configurable again. (Kevin Wilfong via Ning Zhang)

        nzhang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1199114
        Files :

        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1067 (See https://builds.apache.org/job/Hive-trunk-h0.21/1067/ ) HIVE-2545 . Make metastore log4j configuration file configurable again. (Kevin Wilfong via Ning Zhang) nzhang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1199114 Files : /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        Hide
        Ning Zhang added a comment -

        Committed. Thanks Kevin!

        Show
        Ning Zhang added a comment - Committed. Thanks Kevin!
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2676/#review3078
        -----------------------------------------------------------

        Ship it!

        LGTM

        • Ning

        On 2011-11-02 20:18:42, Kevin Wilfong wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2676/

        -----------------------------------------------------------

        (Updated 2011-11-02 20:18:42)

        Review request for hive, Patrick Hunt, Carl Steinbach, Yongqiang He, Ning Zhang, Paul Yang, and namit jain.

        Summary

        -------

        The metastore uses the default hive-log4j.properties only if the log4j.configuration system property hasn't already been set.

        This addresses bug HIVE-2545.

        https://issues.apache.org/jira/browse/HIVE-2545

        Diffs

        -----

        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1196155

        Diff: https://reviews.apache.org/r/2676/diff

        Testing

        -------

        Verified that this allows the properties file specified in log4j.configuration is used if it is specified.

        Verified that the default hive-log4j.properties file is used if log4j.configuration is not specified.

        Verified if the metastore is started via

        ./hive --service metastore

        in the bin directory, the default properties file is used. (I assume this is the use case the default was added for from looking at the diff for HIVE-2139)

        Thanks,

        Kevin

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2676/#review3078 ----------------------------------------------------------- Ship it! LGTM Ning On 2011-11-02 20:18:42, Kevin Wilfong wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2676/ ----------------------------------------------------------- (Updated 2011-11-02 20:18:42) Review request for hive, Patrick Hunt, Carl Steinbach, Yongqiang He, Ning Zhang, Paul Yang, and namit jain. Summary ------- The metastore uses the default hive-log4j.properties only if the log4j.configuration system property hasn't already been set. This addresses bug HIVE-2545 . https://issues.apache.org/jira/browse/HIVE-2545 Diffs ----- trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1196155 Diff: https://reviews.apache.org/r/2676/diff Testing ------- Verified that this allows the properties file specified in log4j.configuration is used if it is specified. Verified that the default hive-log4j.properties file is used if log4j.configuration is not specified. Verified if the metastore is started via ./hive --service metastore in the bin directory, the default properties file is used. (I assume this is the use case the default was added for from looking at the diff for HIVE-2139 ) Thanks, Kevin
        Hide
        Ning Zhang added a comment -

        +1. Will commit if tests pass.

        Show
        Ning Zhang added a comment - +1. Will commit if tests pass.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2676/
        -----------------------------------------------------------

        Review request for hive, Patrick Hunt, Carl Steinbach, Yongqiang He, Ning Zhang, Paul Yang, and namit jain.

        Summary
        -------

        The metastore uses the default hive-log4j.properties only if the log4j.configuration system property hasn't already been set.

        This addresses bug HIVE-2545.
        https://issues.apache.org/jira/browse/HIVE-2545

        Diffs


        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1196155

        Diff: https://reviews.apache.org/r/2676/diff

        Testing
        -------

        Verified that this allows the properties file specified in log4j.configuration is used if it is specified.

        Verified that the default hive-log4j.properties file is used if log4j.configuration is not specified.

        Verified if the metastore is started via
        ./hive --service metastore
        in the bin directory, the default properties file is used. (I assume this is the use case the default was added for from looking at the diff for HIVE-2139)

        Thanks,

        Kevin

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2676/ ----------------------------------------------------------- Review request for hive, Patrick Hunt, Carl Steinbach, Yongqiang He, Ning Zhang, Paul Yang, and namit jain. Summary ------- The metastore uses the default hive-log4j.properties only if the log4j.configuration system property hasn't already been set. This addresses bug HIVE-2545 . https://issues.apache.org/jira/browse/HIVE-2545 Diffs trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1196155 Diff: https://reviews.apache.org/r/2676/diff Testing ------- Verified that this allows the properties file specified in log4j.configuration is used if it is specified. Verified that the default hive-log4j.properties file is used if log4j.configuration is not specified. Verified if the metastore is started via ./hive --service metastore in the bin directory, the default properties file is used. (I assume this is the use case the default was added for from looking at the diff for HIVE-2139 ) Thanks, Kevin

          People

          • Assignee:
            Kevin Wilfong
            Reporter:
            Kevin Wilfong
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development