Hive
  1. Hive
  2. HIVE-2518

pull junit jar from maven repos via ivy

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Activity

      Hide
      Ashutosh Chauhan added a comment -

      @Kevin,
      Eclipse integration also broke with upgrade of junit lib version. Can you also take care of that?

      Show
      Ashutosh Chauhan added a comment - @Kevin, Eclipse integration also broke with upgrade of junit lib version. Can you also take care of that?
      Hide
      Kevin Wilfong added a comment -

      @Ashutosh
      Sorry about that, I'll take care of it.

      Show
      Kevin Wilfong added a comment - @Ashutosh Sorry about that, I'll take care of it.
      Hide
      Ashutosh Chauhan added a comment -

      @Kevin,
      Just checking if there is any progress on this one?

      Show
      Ashutosh Chauhan added a comment - @Kevin, Just checking if there is any progress on this one?
      Hide
      Kevin Wilfong added a comment -

      @Ashutosh
      Sorry about that, I had forgotten. I made a change to pull the junit jar using maven and removed it from testlibs. I also updated Eclipse's class path template to get the jar from the new location. I'm running the tests now to make sure I haven't broken anything and will upload a diff if things go smoothly.

      Also, I checked and I can run the tests in Eclipse (once a remove an Hbase test jar from the build path, but that seems to be a separate issue).

      Show
      Kevin Wilfong added a comment - @Ashutosh Sorry about that, I had forgotten. I made a change to pull the junit jar using maven and removed it from testlibs. I also updated Eclipse's class path template to get the jar from the new location. I'm running the tests now to make sure I haven't broken anything and will upload a diff if things go smoothly. Also, I checked and I can run the tests in Eclipse (once a remove an Hbase test jar from the build path, but that seems to be a separate issue).
      Hide
      Ashutosh Chauhan added a comment -

      No worries : ) Thanks for the update.

      Show
      Ashutosh Chauhan added a comment - No worries : ) Thanks for the update.
      Hide
      Phabricator added a comment -

      kevinwilfong requested code review of "HIVE-2518 [jira] pull junit jar from maven repos via ivy".
      Reviewers: JIRA

      https://issues.apache.org/jira/browse/HIVE-2518

      This patch pulls the junit jar from Ivy. I updated the eclipse classpath and, the unit tests can be run from Eclipse, (once an Hbase test jar has been removed from the build path, a separate issue).

      I added it to the default library as this is where all jars pulled using Ivy, including mockito another test jar, seem to be going.

      see https://issues.apache.org/jira/browse/HIVE-2505

      TEST PLAN
      EMPTY

      REVISION DETAIL
      https://reviews.facebook.net/D2493

      AFFECTED FILES
      eclipse-templates/.classpath
      testlibs/junit-4.10.jar
      testlibs/junit-4.10.LICENSE.txt
      ql/ivy.xml

      MANAGE HERALD DIFFERENTIAL RULES
      https://reviews.facebook.net/herald/view/differential/

      WHY DID I GET THIS EMAIL?
      https://reviews.facebook.net/herald/transcript/5583/

      Tip: use the X-Herald-Rules header to filter Herald messages in your client.

      Show
      Phabricator added a comment - kevinwilfong requested code review of " HIVE-2518 [jira] pull junit jar from maven repos via ivy". Reviewers: JIRA https://issues.apache.org/jira/browse/HIVE-2518 This patch pulls the junit jar from Ivy. I updated the eclipse classpath and, the unit tests can be run from Eclipse, (once an Hbase test jar has been removed from the build path, a separate issue). I added it to the default library as this is where all jars pulled using Ivy, including mockito another test jar, seem to be going. see https://issues.apache.org/jira/browse/HIVE-2505 TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D2493 AFFECTED FILES eclipse-templates/.classpath testlibs/junit-4.10.jar testlibs/junit-4.10.LICENSE.txt ql/ivy.xml MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/5583/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
      Hide
      Phabricator added a comment -

      njain has accepted the revision "HIVE-2518 [jira] pull junit jar from maven repos via ivy".

      REVISION DETAIL
      https://reviews.facebook.net/D2493

      BRANCH
      svn

      Show
      Phabricator added a comment - njain has accepted the revision " HIVE-2518 [jira] pull junit jar from maven repos via ivy". REVISION DETAIL https://reviews.facebook.net/D2493 BRANCH svn
      Hide
      Namit Jain added a comment -

      Committed. Thanks Kevin

      Show
      Namit Jain added a comment - Committed. Thanks Kevin
      Hide
      Hudson added a comment -

      Integrated in Hive-trunk-h0.21 #1338 (See https://builds.apache.org/job/Hive-trunk-h0.21/1338/)
      HIVE-2518 pull junit jar from maven repos via ivy
      (Kevin Wilfong via namit) (Revision 1306470)

      Result = FAILURE
      namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306470
      Files :

      • /hive/trunk/eclipse-templates/.classpath
      • /hive/trunk/ql/ivy.xml
      • /hive/trunk/testlibs/junit-4.10.LICENSE.txt
      • /hive/trunk/testlibs/junit-4.10.jar
      Show
      Hudson added a comment - Integrated in Hive-trunk-h0.21 #1338 (See https://builds.apache.org/job/Hive-trunk-h0.21/1338/ ) HIVE-2518 pull junit jar from maven repos via ivy (Kevin Wilfong via namit) (Revision 1306470) Result = FAILURE namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306470 Files : /hive/trunk/eclipse-templates/.classpath /hive/trunk/ql/ivy.xml /hive/trunk/testlibs/junit-4.10.LICENSE.txt /hive/trunk/testlibs/junit-4.10.jar
      Hide
      Ashutosh Chauhan added a comment -

      This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

      Show
      Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.
      Hide
      Hudson added a comment -

      Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
      HIVE-2518 pull junit jar from maven repos via ivy
      (Kevin Wilfong via namit) (Revision 1306470)

      Result = ABORTED
      namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306470
      Files :

      • /hive/trunk/eclipse-templates/.classpath
      • /hive/trunk/ql/ivy.xml
      • /hive/trunk/testlibs/junit-4.10.LICENSE.txt
      • /hive/trunk/testlibs/junit-4.10.jar
      Show
      Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2518 pull junit jar from maven repos via ivy (Kevin Wilfong via namit) (Revision 1306470) Result = ABORTED namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306470 Files : /hive/trunk/eclipse-templates/.classpath /hive/trunk/ql/ivy.xml /hive/trunk/testlibs/junit-4.10.LICENSE.txt /hive/trunk/testlibs/junit-4.10.jar

        People

        • Assignee:
          Kevin Wilfong
          Reporter:
          He Yongqiang
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development