Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None
    1. HIVE-2505.1.patch.txt
      18 kB
      Kevin Wilfong
    2. junit-4.10.jar
      247 kB
      Kevin Wilfong

      Activity

      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/2391/
      -----------------------------------------------------------

      Review request for hive and Yongqiang He.

      Summary
      -------

      I updated the junit jar to the latest available in the maven repository.

      This addresses bug HIVE-2505.
      https://issues.apache.org/jira/browse/HIVE-2505

      Diffs


      trunk/ivy/libraries.properties 1183425
      trunk/testlibs/junit-3.8.1.LICENSE.txt 1183425
      trunk/testlibs/junit-3.8.1.jar UNKNOWN
      trunk/testlibs/junit-4.10.LICENSE.txt PRE-CREATION
      trunk/testlibs/junit-4.10.jar UNKNOWN

      Diff: https://reviews.apache.org/r/2391/diff

      Testing
      -------

      I ran ant test and the tests continued to pass.

      Thanks,

      Kevin

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2391/ ----------------------------------------------------------- Review request for hive and Yongqiang He. Summary ------- I updated the junit jar to the latest available in the maven repository. This addresses bug HIVE-2505 . https://issues.apache.org/jira/browse/HIVE-2505 Diffs trunk/ivy/libraries.properties 1183425 trunk/testlibs/junit-3.8.1.LICENSE.txt 1183425 trunk/testlibs/junit-3.8.1.jar UNKNOWN trunk/testlibs/junit-4.10.LICENSE.txt PRE-CREATION trunk/testlibs/junit-4.10.jar UNKNOWN Diff: https://reviews.apache.org/r/2391/diff Testing ------- I ran ant test and the tests continued to pass. Thanks, Kevin
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/2391/
      -----------------------------------------------------------

      (Updated 2011-10-15 00:20:46.329179)

      Review request for hive and Yongqiang He.

      Summary
      -------

      I updated the junit jar to the latest available in the maven repository.

      This addresses bug HIVE-2505.
      https://issues.apache.org/jira/browse/HIVE-2505

      Diffs


      trunk/ivy/libraries.properties 1183425
      trunk/pdk/build.xml 1183425
      trunk/testlibs/junit-3.8.1.LICENSE.txt 1183425
      trunk/testlibs/junit-3.8.1.jar UNKNOWN
      trunk/testlibs/junit-4.10.LICENSE.txt PRE-CREATION
      trunk/testlibs/junit-4.10.jar UNKNOWN

      Diff: https://reviews.apache.org/r/2391/diff

      Testing
      -------

      I ran ant test and the tests continued to pass.

      Thanks,

      Kevin

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2391/ ----------------------------------------------------------- (Updated 2011-10-15 00:20:46.329179) Review request for hive and Yongqiang He. Summary ------- I updated the junit jar to the latest available in the maven repository. This addresses bug HIVE-2505 . https://issues.apache.org/jira/browse/HIVE-2505 Diffs trunk/ivy/libraries.properties 1183425 trunk/pdk/build.xml 1183425 trunk/testlibs/junit-3.8.1.LICENSE.txt 1183425 trunk/testlibs/junit-3.8.1.jar UNKNOWN trunk/testlibs/junit-4.10.LICENSE.txt PRE-CREATION trunk/testlibs/junit-4.10.jar UNKNOWN Diff: https://reviews.apache.org/r/2391/diff Testing ------- I ran ant test and the tests continued to pass. Thanks, Kevin
      Hide
      He Yongqiang added a comment -

      looks good. running tests

      Show
      He Yongqiang added a comment - looks good. running tests
      Hide
      Kevin Wilfong added a comment -

      After applying the patch junit-4.10.jar needs to be added to the directory trunk/testlibs/ The jar junit-3.8.1.jar needs to be removed from that same directory as well.

      Show
      Kevin Wilfong added a comment - After applying the patch junit-4.10.jar needs to be added to the directory trunk/testlibs/ The jar junit-3.8.1.jar needs to be removed from that same directory as well.
      Hide
      Ashutosh Chauhan added a comment -

      Instead of checking in the jar we should pull it from maven repos via ivy. Its available on http://repo1.maven.org/maven/

      Show
      Ashutosh Chauhan added a comment - Instead of checking in the jar we should pull it from maven repos via ivy. Its available on http://repo1.maven.org/maven/
      Hide
      John Sichi added a comment -

      +1 on what Ashutosh said; when upgrading something which is currently checked into lib but available in a maven repo, we should svn rm the old jar and add an ivy download to the build.

      Show
      John Sichi added a comment - +1 on what Ashutosh said; when upgrading something which is currently checked into lib but available in a maven repo, we should svn rm the old jar and add an ivy download to the build.
      Hide
      He Yongqiang added a comment -

      committed, thanks Kevin!
      Will open a jira to fix the comments for John and Ashutosh's comments.

      Show
      He Yongqiang added a comment - committed, thanks Kevin! Will open a jira to fix the comments for John and Ashutosh's comments.

        People

        • Assignee:
          Kevin Wilfong
          Reporter:
          Kevin Wilfong
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development