Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-2456

JDBCStatsAggregator DELETE STATEMENT should escape _ and %

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      JDBCStatsAggregator first aggregates stats from all publishers, and then delete these intermediate results. The delete is using LIKE operator, so it needs to escape '_' and '%'.

        Activity

        Hide
        hudson Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #964 (See https://builds.apache.org/job/Hive-trunk-h0.21/964/)
        HIVE-2456: JDBCStatsAggregator DELETE STATEMENT should escape _ and % (Ning Zhang via He Yongqiang)

        heyongqiang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1172869
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java
        Show
        hudson Hudson added a comment - Integrated in Hive-trunk-h0.21 #964 (See https://builds.apache.org/job/Hive-trunk-h0.21/964/ ) HIVE-2456 : JDBCStatsAggregator DELETE STATEMENT should escape _ and % (Ning Zhang via He Yongqiang) heyongqiang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1172869 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java
        Hide
        he yongqiang He Yongqiang added a comment -

        committed, thanks Ning!

        Show
        he yongqiang He Yongqiang added a comment - committed, thanks Ning!
        Hide
        he yongqiang He Yongqiang added a comment -

        +1, will commit after tests pass

        Show
        he yongqiang He Yongqiang added a comment - +1, will commit after tests pass
        Hide
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1957/
        -----------------------------------------------------------

        Review request for hive.

        Summary
        -------

        JDBCStatsAggregator first aggregates stats from all publishers, and then delete these intermediate results. The delete is using LIKE operator, so it needs to escape '_' and '%'.

        This addresses bug HIVE-2456.
        https://issues.apache.org/jira/browse/HIVE-2456

        Diffs


        trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java 1172720
        trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java 1172720

        Diff: https://reviews.apache.org/r/1957/diff

        Testing
        -------

        Running unit tests.

        Thanks,

        Ning

        Show
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1957/ ----------------------------------------------------------- Review request for hive. Summary ------- JDBCStatsAggregator first aggregates stats from all publishers, and then delete these intermediate results. The delete is using LIKE operator, so it needs to escape '_' and '%'. This addresses bug HIVE-2456 . https://issues.apache.org/jira/browse/HIVE-2456 Diffs trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java 1172720 trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java 1172720 Diff: https://reviews.apache.org/r/1957/diff Testing ------- Running unit tests. Thanks, Ning
        Hide
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1954/
        -----------------------------------------------------------

        (Updated 2011-09-19 17:18:39.180498)

        Review request for hive.

        Changes
        -------

        escape '%' and '_' in DELETE statement

        Summary
        -------

        JDBCStatsAggregator first aggregates stats from all publishers, and then delete these intermediate results. The delete is using LIKE operator, so it needs to escape '_' and '%'.

        This addresses bug HIVE-2456.
        https://issues.apache.org/jira/browse/HIVE-2456

        Diffs


        Diff: https://reviews.apache.org/r/1954/diff

        Testing
        -------

        running unit tests.

        Thanks,

        Ning

        Show
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1954/ ----------------------------------------------------------- (Updated 2011-09-19 17:18:39.180498) Review request for hive. Changes ------- escape '%' and '_' in DELETE statement Summary ------- JDBCStatsAggregator first aggregates stats from all publishers, and then delete these intermediate results. The delete is using LIKE operator, so it needs to escape '_' and '%'. This addresses bug HIVE-2456 . https://issues.apache.org/jira/browse/HIVE-2456 Diffs Diff: https://reviews.apache.org/r/1954/diff Testing ------- running unit tests. Thanks, Ning
        Hide
        nzhang Ning Zhang added a comment -
        Show
        nzhang Ning Zhang added a comment - Review board: https://reviews.apache.org/r/1954/

          People

          • Assignee:
            nzhang Ning Zhang
            Reporter:
            nzhang Ning Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development