Hive
  1. Hive
  2. HIVE-2455

Pass correct remoteAddress in proxy user authentication

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.7.1, 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: Security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      After Hive-2376 its possible to get rid of current hack.
    1. hive-2455_1.patch
      7 kB
      Ashutosh Chauhan
    2. hive-2455.patch
      4 kB
      Ashutosh Chauhan

      Activity

      Hide
      Hudson added a comment -

      Integrated in Hive-trunk-h0.21 #1007 (See https://builds.apache.org/job/Hive-trunk-h0.21/1007/)
      HIVE-2455. Pass correct remoteAddress in proxy user authentication
      (Ashutosh Chauhan via jvs)

      jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1182001
      Files :

      • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
      • /hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java
      • /hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java
      Show
      Hudson added a comment - Integrated in Hive-trunk-h0.21 #1007 (See https://builds.apache.org/job/Hive-trunk-h0.21/1007/ ) HIVE-2455 . Pass correct remoteAddress in proxy user authentication (Ashutosh Chauhan via jvs) jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1182001 Files : /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java /hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java /hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java
      Hide
      John Sichi added a comment -

      Committed to trunk. Thanks Ashutosh!

      Show
      John Sichi added a comment - Committed to trunk. Thanks Ashutosh!
      Hide
      John Sichi added a comment -

      +1. Will commit when tests pass.

      Show
      John Sichi added a comment - +1. Will commit when tests pass.
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/2334/
      -----------------------------------------------------------

      Review request for hive and John Sichi.

      Summary
      -------

      Pass correct remoteAddress in proxy user authentication

      This addresses bug HIVE-2455.
      https://issues.apache.org/jira/browse/HIVE-2455

      Diffs


      trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1179774
      trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 1179774
      trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1179774

      Diff: https://reviews.apache.org/r/2334/diff

      Testing
      -------

      Thanks,

      Ashutosh

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2334/ ----------------------------------------------------------- Review request for hive and John Sichi. Summary ------- Pass correct remoteAddress in proxy user authentication This addresses bug HIVE-2455 . https://issues.apache.org/jira/browse/HIVE-2455 Diffs trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1179774 trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 1179774 trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1179774 Diff: https://reviews.apache.org/r/2334/diff Testing ------- Thanks, Ashutosh
      Hide
      John Sichi added a comment -

      Could you post it to review board?

      Show
      John Sichi added a comment - Could you post it to review board?
      Hide
      Ashutosh Chauhan added a comment -

      Can any committer take a look?

      Show
      Ashutosh Chauhan added a comment - Can any committer take a look?
      Hide
      Devaraj Das added a comment -

      +1

      Show
      Devaraj Das added a comment - +1
      Hide
      Ashutosh Chauhan added a comment -

      Updated patch incorporating Devaraj's comments. Made thread-local variables package private and corrected unintentional indentation problem.

      Show
      Ashutosh Chauhan added a comment - Updated patch incorporating Devaraj's comments. Made thread-local variables package private and corrected unintentional indentation problem.
      Hide
      Devaraj Das added a comment -

      Could we limit the visibility of the thread-local variable to package-private (as opposed to public). The patch introduces a indentation problem in HadoopThriftAuthBridge20S.java. Looks good otherwise.

      Show
      Devaraj Das added a comment - Could we limit the visibility of the thread-local variable to package-private (as opposed to public). The patch introduces a indentation problem in HadoopThriftAuthBridge20S.java. Looks good otherwise.
      Hide
      Ashutosh Chauhan added a comment -

      Now that remoteAddr is never null, get rid of null check while logging.

      Show
      Ashutosh Chauhan added a comment - Now that remoteAddr is never null, get rid of null check while logging.
      Hide
      Ashutosh Chauhan added a comment -

      Attached patch fixes the issues.

      Show
      Ashutosh Chauhan added a comment - Attached patch fixes the issues.

        People

        • Assignee:
          Ashutosh Chauhan
          Reporter:
          Ashutosh Chauhan
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development