Attached patch fixes the issues.

Now that remoteAddr is never null, get rid of null check while logging.

Could we limit the visibility of the thread-local variable to package-private (as opposed to public). The patch introduces a indentation problem in HadoopThriftAuthBridge20S.java. Looks good otherwise.

Updated patch incorporating Devaraj's comments. Made thread-local variables package private and corrected unintentional indentation problem.

+1

Can any committer take a look?

Could you post it to review board?

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2334/
-----------------------------------------------------------

Review request for hive and John Sichi.

Summary
-------

Pass correct remoteAddress in proxy user authentication

This addresses bug HIVE-2455.
https://issues.apache.org/jira/browse/HIVE-2455

Diffs

trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1179774
trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 1179774
trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1179774

Diff: https://reviews.apache.org/r/2334/diff

Testing
-------

Thanks,

Ashutosh

+1. Will commit when tests pass.

Committed to trunk. Thanks Ashutosh!

Integrated in Hive-trunk-h0.21 #1007 (See https://builds.apache.org/job/Hive-trunk-h0.21/1007/)
HIVE-2455. Pass correct remoteAddress in proxy user authentication
(Ashutosh Chauhan via jvs)

jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1182001
Files :

• /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
• /hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java
• /hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java