Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently, we collect a lot of stats per job in MapRedStats, but there is no way to associate these stats with a specific job. Adding the job ID to the class would help to make the association clear.

        Activity

        Carl Steinbach made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Carl Steinbach made changes -
        Fix Version/s 0.9.0 [ 12317742 ]
        Carl Steinbach made changes -
        Fix Version/s 0.8.0 [ 12316178 ]
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #958 (See https://builds.apache.org/job/Hive-trunk-h0.21/958/)
        HIVE-2447. Add job ID to MapRedStats (Kevin Wilfong via Ning Zhang)

        nzhang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171626
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #958 (See https://builds.apache.org/job/Hive-trunk-h0.21/958/ ) HIVE-2447 . Add job ID to MapRedStats (Kevin Wilfong via Ning Zhang) nzhang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171626 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
        Ning Zhang made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.9.0 [ 12317742 ]
        Resolution Fixed [ 1 ]
        Hide
        Ning Zhang added a comment -

        Committed. Thanks Kevin!

        Show
        Ning Zhang added a comment - Committed. Thanks Kevin!
        Hide
        Ning Zhang added a comment -

        +1. Will commit if tests pass.

        Show
        Ning Zhang added a comment - +1. Will commit if tests pass.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1918/#review1917
        -----------------------------------------------------------

        Ship it!

        • Ning

        On 2011-09-15 17:39:49, Kevin Wilfong wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/1918/

        -----------------------------------------------------------

        (Updated 2011-09-15 17:39:49)

        Review request for hive and Ning Zhang.

        Summary

        -------

        I added the job ID to the MapRedStats class. It is populated as part of the constructor.

        This addresses bug HIVE-2447.

        https://issues.apache.org/jira/browse/HIVE-2447

        Diffs

        -----

        trunk/ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java 1171172

        trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1171172

        Diff: https://reviews.apache.org/r/1918/diff

        Testing

        -------

        Verified the job ID was being populated.

        Thanks,

        Kevin

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1918/#review1917 ----------------------------------------------------------- Ship it! Ning On 2011-09-15 17:39:49, Kevin Wilfong wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1918/ ----------------------------------------------------------- (Updated 2011-09-15 17:39:49) Review request for hive and Ning Zhang. Summary ------- I added the job ID to the MapRedStats class. It is populated as part of the constructor. This addresses bug HIVE-2447 . https://issues.apache.org/jira/browse/HIVE-2447 Diffs ----- trunk/ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java 1171172 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1171172 Diff: https://reviews.apache.org/r/1918/diff Testing ------- Verified the job ID was being populated. Thanks, Kevin
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1918/
        -----------------------------------------------------------

        Review request for hive and Ning Zhang.

        Summary
        -------

        I added the job ID to the MapRedStats class. It is populated as part of the constructor.

        This addresses bug HIVE-2447.
        https://issues.apache.org/jira/browse/HIVE-2447

        Diffs


        trunk/ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java 1171172
        trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1171172

        Diff: https://reviews.apache.org/r/1918/diff

        Testing
        -------

        Verified the job ID was being populated.

        Thanks,

        Kevin

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1918/ ----------------------------------------------------------- Review request for hive and Ning Zhang. Summary ------- I added the job ID to the MapRedStats class. It is populated as part of the constructor. This addresses bug HIVE-2447 . https://issues.apache.org/jira/browse/HIVE-2447 Diffs trunk/ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java 1171172 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1171172 Diff: https://reviews.apache.org/r/1918/diff Testing ------- Verified the job ID was being populated. Thanks, Kevin
        Kevin Wilfong made changes -
        Field Original Value New Value
        Attachment HIVE-2447.1.patch.txt [ 12494663 ]
        Kevin Wilfong created issue -

          People

          • Assignee:
            Kevin Wilfong
            Reporter:
            Kevin Wilfong
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development