Hive
  1. Hive
  2. HIVE-2445

The PerfLogger should log the full name of hooks, not just the simple name.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Sometimes the simple name of a hook is not enough to identify it, so the PerfLogger should log the full name instead.

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #955 (See https://builds.apache.org/job/Hive-trunk-h0.21/955/)
        HIVE-2445. The PerfLogger should log the full name of hooks, not just the simple name (Kevin Wilfong via Ning Zhang)

        nzhang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170871
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #955 (See https://builds.apache.org/job/Hive-trunk-h0.21/955/ ) HIVE-2445 . The PerfLogger should log the full name of hooks, not just the simple name (Kevin Wilfong via Ning Zhang) nzhang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170871 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
        Hide
        Ning Zhang added a comment -

        Committed. Thanks Kevin!

        Show
        Ning Zhang added a comment - Committed. Thanks Kevin!
        Hide
        Kevin Wilfong added a comment -

        Sorry, forgot that step, it's up now.

        Show
        Kevin Wilfong added a comment - Sorry, forgot that step, it's up now.
        Hide
        Ning Zhang added a comment -

        Kevin, can you upload the patch to this JIRA? I'll use the patch in the review board for testing for now.

        Show
        Ning Zhang added a comment - Kevin, can you upload the patch to this JIRA? I'll use the patch in the review board for testing for now.
        Hide
        Ning Zhang added a comment -

        +1. Will commit if tests pass.

        Show
        Ning Zhang added a comment - +1. Will commit if tests pass.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1882/#review1893
        -----------------------------------------------------------

        Ship it!

        • Ning

        On 2011-09-14 16:53:49, Kevin Wilfong wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/1882/

        -----------------------------------------------------------

        (Updated 2011-09-14 16:53:49)

        Review request for hive and Ning Zhang.

        Summary

        -------

        I change the method called when logging pre, failure, and post hooks to the PerfLogger to getName instead of getSimpleName.

        This addresses bug HIVE-2445.

        https://issues.apache.org/jira/browse/HIVE-2445

        Diffs

        -----

        trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1170268

        Diff: https://reviews.apache.org/r/1882/diff

        Testing

        -------

        Ran the unit test queries, and verified the intended change in the logs.

        Thanks,

        Kevin

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1882/#review1893 ----------------------------------------------------------- Ship it! Ning On 2011-09-14 16:53:49, Kevin Wilfong wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1882/ ----------------------------------------------------------- (Updated 2011-09-14 16:53:49) Review request for hive and Ning Zhang. Summary ------- I change the method called when logging pre, failure, and post hooks to the PerfLogger to getName instead of getSimpleName. This addresses bug HIVE-2445 . https://issues.apache.org/jira/browse/HIVE-2445 Diffs ----- trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1170268 Diff: https://reviews.apache.org/r/1882/diff Testing ------- Ran the unit test queries, and verified the intended change in the logs. Thanks, Kevin
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1882/
        -----------------------------------------------------------

        Review request for hive and Ning Zhang.

        Summary
        -------

        I change the method called when logging pre, failure, and post hooks to the PerfLogger to getName instead of getSimpleName.

        This addresses bug HIVE-2445.
        https://issues.apache.org/jira/browse/HIVE-2445

        Diffs


        trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1170268

        Diff: https://reviews.apache.org/r/1882/diff

        Testing
        -------

        Ran the unit test queries, and verified the intended change in the logs.

        Thanks,

        Kevin

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1882/ ----------------------------------------------------------- Review request for hive and Ning Zhang. Summary ------- I change the method called when logging pre, failure, and post hooks to the PerfLogger to getName instead of getSimpleName. This addresses bug HIVE-2445 . https://issues.apache.org/jira/browse/HIVE-2445 Diffs trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1170268 Diff: https://reviews.apache.org/r/1882/diff Testing ------- Ran the unit test queries, and verified the intended change in the logs. Thanks, Kevin

          People

          • Assignee:
            Kevin Wilfong
            Reporter:
            Kevin Wilfong
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development