Hive
  1. Hive
  2. HIVE-2431

upgrading thrift version didn't upgrade libthrift.jar symlink correctly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      libthrift.jar and libfb303.jar are symlinks to the current thrift version. With the upgrade to 0.7, there's a bug in the symlink creation.

      1. HIVE-2431.patch
        0.9 kB
        Ning Zhang

        Activity

        Ning Zhang created issue -
        Ning Zhang made changes -
        Field Original Value New Value
        Attachment HIVE-2431.patch [ 12493532 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1740/
        -----------------------------------------------------------

        Review request for hive and Carl Steinbach.

        Summary
        -------

        simple change to fix the libfb303.jar and libthrift.jar symlinks.

        This addresses bug HIVE-2431.
        https://issues.apache.org/jira/browse/HIVE-2431

        Diffs


        trunk/build.xml 1166476

        Diff: https://reviews.apache.org/r/1740/diff

        Testing
        -------

        ant clean package then check build/dist/lib for the correctness.

        Thanks,

        Ning

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1740/ ----------------------------------------------------------- Review request for hive and Carl Steinbach. Summary ------- simple change to fix the libfb303.jar and libthrift.jar symlinks. This addresses bug HIVE-2431 . https://issues.apache.org/jira/browse/HIVE-2431 Diffs trunk/build.xml 1166476 Diff: https://reviews.apache.org/r/1740/diff Testing ------- ant clean package then check build/dist/lib for the correctness. Thanks, Ning
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1740/#review1811
        -----------------------------------------------------------

        Ship it!

        +1

        • Amareshwari

        On 2011-09-08 00:25:14, Ning Zhang wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/1740/

        -----------------------------------------------------------

        (Updated 2011-09-08 00:25:14)

        Review request for hive and Carl Steinbach.

        Summary

        -------

        simple change to fix the libfb303.jar and libthrift.jar symlinks.

        This addresses bug HIVE-2431.

        https://issues.apache.org/jira/browse/HIVE-2431

        Diffs

        -----

        trunk/build.xml 1166476

        Diff: https://reviews.apache.org/r/1740/diff

        Testing

        -------

        ant clean package then check build/dist/lib for the correctness.

        Thanks,

        Ning

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1740/#review1811 ----------------------------------------------------------- Ship it! +1 Amareshwari On 2011-09-08 00:25:14, Ning Zhang wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1740/ ----------------------------------------------------------- (Updated 2011-09-08 00:25:14) Review request for hive and Carl Steinbach. Summary ------- simple change to fix the libfb303.jar and libthrift.jar symlinks. This addresses bug HIVE-2431 . https://issues.apache.org/jira/browse/HIVE-2431 Diffs ----- trunk/build.xml 1166476 Diff: https://reviews.apache.org/r/1740/diff Testing ------- ant clean package then check build/dist/lib for the correctness. Thanks, Ning
        Hide
        Amareshwari Sriramadasu added a comment -

        I just committed this to trunk and branch-0.8. Thanks Ning!

        Show
        Amareshwari Sriramadasu added a comment - I just committed this to trunk and branch-0.8. Thanks Ning!
        Amareshwari Sriramadasu made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.8.0 [ 12316178 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #941 (See https://builds.apache.org/job/Hive-trunk-h0.21/941/)
        HIVE-2431. Fixes symlink creation for libthrift.jar after thrift version upgrade. (Ning Zhang via amareshwari)

        amareshwari : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166528
        Files :

        • /hive/trunk/build.xml
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #941 (See https://builds.apache.org/job/Hive-trunk-h0.21/941/ ) HIVE-2431 . Fixes symlink creation for libthrift.jar after thrift version upgrade. (Ning Zhang via amareshwari) amareshwari : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166528 Files : /hive/trunk/build.xml
        Hide
        Hudson added a comment -

        Integrated in Hive-0.8.0-SNAPSHOT-h0.21 #13 (See https://builds.apache.org/job/Hive-0.8.0-SNAPSHOT-h0.21/13/)
        HIVE-2431. svn merge -r 1166527:1166528 from trunk

        amareshwari : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166529
        Files :

        • /hive/branches/branch-0.8/build.xml
        Show
        Hudson added a comment - Integrated in Hive-0.8.0-SNAPSHOT-h0.21 #13 (See https://builds.apache.org/job/Hive-0.8.0-SNAPSHOT-h0.21/13/ ) HIVE-2431 . svn merge -r 1166527:1166528 from trunk amareshwari : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166529 Files : /hive/branches/branch-0.8/build.xml
        Carl Steinbach made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Ning Zhang
            Reporter:
            Ning Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development