[HIVE-24234] Improve checkHashModeEfficiency in VectorGroupByOperator

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Labels: pull-request-available
• Assignee: Rajesh Balamohan Assign to me
• Reporter: Rajesh Balamohan
• Created: 06/Oct/20 09:07
• Updated: 17/Nov/22 08:48
• Resolved: 13/Oct/20 02:09

Description

Currently, VectorGroupByOperator::checkHashModeEfficiency compares the number of entries with the number input records that have been processed. For grouping sets, it accounts for grouping set length as well.

Issue is that, the condition becomes invalid after processing large number of input records. This prevents the system from switching over to streaming mode.

e.g Assume 500,000 input records processed, with 9 grouping sets, with 100,000 entries in hashtable. Hashtable would never cross 4,500,0000 entries as the max size itself is 1M by default.

It would be good to compare the input records (adjusted for grouping sets) with number of output records (along with size of hashtable size) to determine hashing or streaming mode.

E.g Q67.

Issue Links

• links to: GitHub Pull Request #1560