[HIVE-23946] Improve control flow and error handling in QTest dataset loading/unloading - ASF JIRA

Log work

Agile Board

Rank to Top

Rank to Bottom

Bulk Copy Attachments

Bulk Move Attachments

Add vote

Voters

Watch issue

Watchers

Create sub-task

Convert to sub-task

Move

Link

Clone

Labels

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Open
Priority: Major
Resolution: Unresolved
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
- pull-request-available

Description

This issue focuses mainly on the following methods:
QTestDatasetHandler#initDataset
QTestDatasetHandler#unloadDataset

related to QTest dataset loading and unloading.

The boolean return type in these methods is redundant since they either fail or return true (they never return false).

The methods should throw an Exception instead of an AssertionError to indicate failure. This allows code higher up the stack to perform proper recovery and properly report the failure. At the moment, if an AssertionError is raised from these methods dependent code (eg., CoreCliDriver) fails to notice that the query has failed.

In case of failure in loading/unloading the environment (instance and class variables) is not properly cleaned leading to failures in all subsequent tests.