Hive
  1. Hive
  2. HIVE-2371

sample_islocalmode_hook.q test is non-deterministic

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Activity

      Kevin Wilfong created issue -
      Kevin Wilfong made changes -
      Field Original Value New Value
      Attachment HIVE-2371.1.patch.txt [ 12490198 ]
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/1477/
      -----------------------------------------------------------

      Review request for hive and Siying Dong.

      Summary
      -------

      Adding order by to the two queries used to create the test tables makes the test deterministic.

      This addresses bug HIVE-2371.
      https://issues.apache.org/jira/browse/HIVE-2371

      Diffs


      trunk/ql/src/test/queries/clientpositive/sample_islocalmode_hook.q 1156861
      trunk/ql/src/test/results/clientpositive/sample_islocalmode_hook.q.out 1156861

      Diff: https://reviews.apache.org/r/1477/diff

      Testing
      -------

      I ran the test and verified it passed.

      I also had a person who had been seeing the test fail do to non-determinism run the test and verify that it passed.

      Thanks,

      Kevin

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1477/ ----------------------------------------------------------- Review request for hive and Siying Dong. Summary ------- Adding order by to the two queries used to create the test tables makes the test deterministic. This addresses bug HIVE-2371 . https://issues.apache.org/jira/browse/HIVE-2371 Diffs trunk/ql/src/test/queries/clientpositive/sample_islocalmode_hook.q 1156861 trunk/ql/src/test/results/clientpositive/sample_islocalmode_hook.q.out 1156861 Diff: https://reviews.apache.org/r/1477/diff Testing ------- I ran the test and verified it passed. I also had a person who had been seeing the test fail do to non-determinism run the test and verify that it passed. Thanks, Kevin
      Hide
      Kevin Wilfong added a comment -
      Show
      Kevin Wilfong added a comment - This was committed as part of https://issues.apache.org/jira/browse/HIVE-2322
      Kevin Wilfong made changes -
      Status Open [ 1 ] Resolved [ 5 ]
      Resolution Duplicate [ 3 ]
      Transition Time In Source Status Execution Times Last Executer Last Execution Date
      Open Open Resolved Resolved
      2d 59m 1 Kevin Wilfong 14/Aug/11 02:02

        People

        • Assignee:
          Kevin Wilfong
          Reporter:
          Kevin Wilfong
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development